[jira] Created: (OFBIZ-3012) The content of the FindScreenDecorator is not properly contained in the screenlet-body tag

[Nicolas Malin (Jira)]

The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
------------------------------------------------------------------------------------------

                 Key: OFBIZ-3012
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Bruno Busco
            Priority: Minor
         Attachments: Framework.patch

The attached patch fixes this.
BTW: few better Italian labels included also.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3012:
-------------------------------

    Attachment: Framework.patch

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: Framework.patch
>
>
> The attached patch fixes this.
> BTW: few better Italian labels included also.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3012:
-------------------------------

    Description:
The attached patch fixes this.
BTW: include also:
1) few better Italian labels.
2) "screenlet" decorator removed (not used anymore)

  was:
The attached patch fixes this.
BTW: few better Italian labels included also.

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: Framework.patch
>
>
> The attached patch fixes this.
> BTW: include also:
> 1) few better Italian labels.
> 2) "screenlet" decorator removed (not used anymore)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763594#action_12763594 ]

Adrian Crum commented on OFBIZ-3012:
------------------------------------

Bruno,

It would be best if separate patches were made for each change.

I understand why the screenlet decorator was removed, but I don't understand why the screenlet widget was replaced by a container widget.

What do you mean by "The content of the FindScreenDecorator is not properly contained in the screenlet-body tag?"

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: Framework.patch
>
>
> The attached patch fixes this.
> BTW: include also:
> 1) few better Italian labels.
> 2) "screenlet" decorator removed (not used anymore)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3012:
-------------------------------

    Attachment:     (was: Framework.patch)

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: screenlet.patch, uilabels.patch
>
>
> The attached patch fixes this.
> BTW: include also:
> 1) few better Italian labels.
> 2) "screenlet" decorator removed (not used anymore)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3012:
-------------------------------

    Attachment: screenlet.patch
                uilabels.patch

Hi Adrian,
thank you for reviewing the patch.

I have separated now the patch related to Better Italian labels (uilabels.patch)
from the one related to the FindScreenDecorator (screenlet.patch)

You are right! There is no reason to change the screenlet tag to container. I was convinced that this would have rendered a double screenlet-body section (one from the screenlet widget rendering and one from the explicit container that is in the file) but I have verified that it does not.
I have removed this change from the patch.

For "The content of the FindScreenDecorator is not properly contained in the screenlet-body tag" I mean that in the FindScreenDecorator the code:
                    <container id="search-results">
                        <decorator-section-include name="search-results"/>
                    </container>
is not contained in the "screenlet-body" container and this is different from what is rendered by the screenlet widget where ALL the content is inside the screenlet-container.

The new bluelight theme does not render perfectly if content is not included in the screenlet-body and this is the reason of the change.
Having ALL the content always included in the screenlet-body tag makes the HTML rendered from the screenlet widget exactly equal to the one that is obtained by an FTL or container widget.

-Bruno

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: screenlet.patch, uilabels.patch
>
>
> The attached patch fixes this.
> BTW: include also:
> 1) few better Italian labels.
> 2) "screenlet" decorator removed (not used anymore)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763720#action_12763720 ]

Adrian Crum commented on OFBIZ-3012:
------------------------------------

Bruno,

What I would like to avoid is getting into a "tug-of-war" between markup and visual themes. If I understand you correctly, you want to change the markup to accommodate the Bluelight theme. What do we do if the changed markup breaks other themes? It would be preferable to strive - as much as possible - to keep the markup constant, and come up with themes that render that markup.

The search-results container is just an anchor - it is not used for styling. It might be used by Ajax - but I'm not sure.

If you need to style the table that it contains, then use a CSS descendant selector.

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: screenlet.patch, uilabels.patch
>
>
> The attached patch fixes this.
> BTW: include also:
> 1) few better Italian labels.
> 2) "screenlet" decorator removed (not used anymore)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3012:
-------------------------------

    Attachment:     (was: uilabels.patch)

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: screenlet.patch
>
>
> The attached patch fixes this.
> BTW: include also:
> 1) few better Italian labels.
> 2) "screenlet" decorator removed (not used anymore)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3012:
-------------------------------

    Attachment:     (was: screenlet.patch)

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: screenlet-body.patch
>
>
> The attached patch fixes this.
> BTW: include also:
> 1) few better Italian labels.
> 2) "screenlet" decorator removed (not used anymore)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3012:
-------------------------------

    Attachment: screenlet-body.patch

Adrian,
as discussed, I changed the screenlet macro renderer so that all the screenlet body content is always contained in the screenlet-body div tag.
If a padded="false" attribute is specified in the screenlet a "no-padding" style is added to the screenlet-body so that the CSS can style it with no border and padding.
The themes have also been updated with this CSS.

With this change, actually, an empty screenlet-body div is generated when the screenlet has no body content I was not able to fix this. (Any help is appreciated)

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: screenlet-body.patch
>
>
> The attached patch fixes this.
> BTW: include also:
> 1) few better Italian labels.
> 2) "screenlet" decorator removed (not used anymore)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3012:
-------------------------------

    Description:
The purpose of this patch is to have a all the screenlet content wrapped in the screenlet-body tag regardless of the padded attribute.
The padded attribute only affects an additional "no-padding" style.

  was:
The attached patch fixes this.
BTW: include also:
1) few better Italian labels.
2) "screenlet" decorator removed (not used anymore)

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: screenlet-body.patch
>
>
> The purpose of this patch is to have a all the screenlet content wrapped in the screenlet-body tag regardless of the padded attribute.
> The padded attribute only affects an additional "no-padding" style.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767078#action_12767078 ]

Bruno Busco commented on OFBIZ-3012:
------------------------------------

Is there any chance to commit this patch?
Thanks,
Bruno

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: screenlet-body.patch
>
>
> The purpose of this patch is to have a all the screenlet content wrapped in the screenlet-body tag regardless of the padded attribute.
> The padded attribute only affects an additional "no-padding" style.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767090#action_12767090 ]

Adrian Crum commented on OFBIZ-3012:
------------------------------------

Looks good to me.

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: screenlet-body.patch
>
>
> The purpose of this patch is to have a all the screenlet content wrapped in the screenlet-body tag regardless of the padded attribute.
> The padded attribute only affects an additional "no-padding" style.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767091#action_12767091 ]

Bruno Busco commented on OFBIZ-3012:
------------------------------------

OK,
so now we need a committer with framework access and a little spare time... ;-)

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: screenlet-body.patch
>
>
> The purpose of this patch is to have a all the screenlet content wrapped in the screenlet-body tag regardless of the padded attribute.
> The padded attribute only affects an additional "no-padding" style.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-3012:
----------------------------------

    Assignee: Adrian Crum

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: screenlet-body.patch
>
>
> The purpose of this patch is to have a all the screenlet content wrapped in the screenlet-body tag regardless of the padded attribute.
> The padded attribute only affects an additional "no-padding" style.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-3012.
------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Committed, rev 826469.

Thanks Bruno!

> The content of the FindScreenDecorator is not properly contained in the screenlet-body tag
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3012
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3012
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bruno Busco
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: screenlet-body.patch
>
>
> The purpose of this patch is to have a all the screenlet content wrapped in the screenlet-body tag regardless of the padded attribute.
> The padded attribute only affects an additional "no-padding" style.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.