OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3026) Datafile does not catch lack of lack of delimiter if at end of file.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

42 messages Options

123

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3026) Datafile does not catch lack of delimiter if at end of line.

[ https://issues.apache.org/jira/browse/OFBIZ-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847827#action_12847827 ]

BJ Freeman commented on OFBIZ-3026:
-----------------------------------

I am only in 9.04.
I found what Eclipse does.
when I have done a mod then do an update it creates this comments in the code to show me what is going on.
if I do a revert to the svn then it removes the comments and gives me clean code.

> Datafile does not catch lack of delimiter if at end of line.
> ------------------------------------------------------------
>
> Key: OFBIZ-3026
> URL: https://issues.apache.org/jira/browse/OFBIZ-3026
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 9.04, SVN trunk
> Environment: 9.04 revision 823664
> Reporter: BJ Freeman
> Assignee: Jacques Le Roux
> Fix For: Release Branch 9.04
>
> Attachments: OFBIZ-3026missingdataindatafile.patch, OFBIZ-3026recorditerator.patch, RecordIterator.java, screenshot-1.jpg
>
>
> datafile that does not have the last delimiter before the CRLF.
> 2009-10-10 20:33:19,265 (http-0.0.0.0-8443-2) [ModelDataFileReader.java:135:INFO ] -- getModelDataFile: #1 Loaded dataFile: Product
> 2009-10-10 20:33:19,265 (http-0.0.0.0-8443-2) [ModelDataFileReader.java:74 :INFO ] [ModelDataFileReader.getModelDataFileReader] : returning reader.
> 2009-10-10 20:33:19,265 (http-0.0.0.0-8443-2) [ModelDataFileReader.java:74 :INFO ] [ModelDataFileReader.getModelDataFileReader] : returning reader.
> 2009-10-10 20:33:19,265 (http-0.0.0.0-8443-2) [ ?:? :INFO ]
> ---- exception report ----------------------------------------------------------
> Exception: org.ofbiz.datafile.DataFileException
> Message: Field map could not be read from a line (1) with only 234 chars. (null)
> ---- cause ---------------------------------------------------------------------
> Exception: java.util.NoSuchElementException
> Message: null
> ---- stack trace ---------------------------------------------------------------
> java.util.NoSuchElementException
> java.util.StringTokenizer.nextToken(Unknown Source)
> org.ofbiz.datafile.Record.createDelimitedRecord(Record.java:555)
> org.ofbiz.datafile.RecordIterator.getNextLine(RecordIterator.java:123)
> org.ofbiz.datafile.RecordIterator.setupStream(RecordIterator.java:79)
> org.ofbiz.datafile.RecordIterator.<init>(RecordIterator.java:61)
> org.ofbiz.datafile.DataFile.makeRecordIterator(DataFile.java:165)
> org.ofbiz.datafile.DataFile.readDataFile(DataFile.java:124)
> org.ofbiz.datafile.DataFile.readFile(DataFile.java:63)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3026) Datafile does not catch lack of delimiter if at end of line.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847903#action_12847903 ]

Jacques Le Roux commented on OFBIZ-3026:
----------------------------------------

OK, so the last change was done at http://svn.apache.org/viewvc?view=revision&revision=923829.

This may help you http://fisheye6.atlassian.com/browse/ofbiz/branches/release09.04/framework/datafile/src/org/ofbiz/datafile/Record.java?r1=&r2=#r923829

Good luck

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

123