[jira] Created: (OFBIZ-3061) You don't to distinguish between normal text and URL links in screens

[Nicolas Malin (Jira)]

You don't to distinguish between normal text and URL links in screens
---------------------------------------------------------------------

                 Key: OFBIZ-3061
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
             Project: OFBiz
          Issue Type: Sub-task
            Reporter: Jacques Le Roux
         Attachments: Payments links in a sale invoice.jpg

For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3061:
-----------------------------------

    Attachment: Payments links in a sale invoice.jpg

You can't see they are links at 1st glance. Not good for newbies

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>         Attachments: Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770686#action_12770686 ]

Bilgin Ibryam commented on OFBIZ-3061:
--------------------------------------

You can't see the links even in second glance ;)  I wonder how people use this theme w/o being able to make a distinction between a text and a link?

I propose to underline all links belonging to .basic-table except for the buttons in themes\bizznesstime\webapp\bizznesstime\css\style.css by adding this:

.basic-table td a {
        text-decoration: underline;
}

.basic-table td a.buttontext  {
        text-decoration: none;
}

If there are no other proposals I will commit this soon.

Bilgin

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>         Attachments: Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771472#action_12771472 ]

Jacques Le Roux commented on OFBIZ-3061:
----------------------------------------

Hi Bilgin,

I think it's time to commit, at least we will see something, I was trapped another time :(

Thanks

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>         Attachments: Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-3061.
--------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Bilgin Ibryam

Thanks for the reminder Jacques.

Committed to trunk in r831159.

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771752#action_12771752 ]

Jacques Le Roux commented on OFBIZ-3061:
----------------------------------------

Hi Bilgin,

I agree it's better than before, but I wonder now if we should not only color the link in tables. Because, for instance, underline all buttons is ugly.

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771754#action_12771754 ]

Jacques Le Roux commented on OFBIZ-3061:
----------------------------------------

Mmm, I spoke to fast

I suppose this snippet

+.basic-table td a.buttontext  {
+    text-decoration: none;
+}

Was intended for that, now I wonde why it does not work...

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771755#action_12771755 ]

Jacques Le Roux commented on OFBIZ-3061:
----------------------------------------

Look for parties search results for instance

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771879#action_12771879 ]

Bilgin Ibryam commented on OFBIZ-3061:
--------------------------------------

Jacques,

you are right, colored links would look better .
The above code doesn't work in parties search result because it is ftl and use different css classes for buttons :(
Now I think we should go simpler, by coloring all the links.
Could you try the attached path and tell your opinion?

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: link.patch, Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reopened OFBIZ-3061:
----------------------------------

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: link.patch, Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-3061:
---------------------------------

    Attachment: link.patch

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: link.patch, Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-3061:
---------------------------------

    Attachment:     (was: link.patch)

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-3061:
---------------------------------

    Attachment: link.patch

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: link.patch, Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3061.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 9.04

Thanks Bilgin,

Yes it looks better,  I have commited your patch in trunk at r831238 .
I have also decided to backport this change to R9.04 at r831241 because I believe Bizness Time is barely usable without it

> You don't to distinguish between normal text and URL links in screens
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-3061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3061
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Jacques Le Roux
>            Assignee: Bilgin Ibryam
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: link.patch, Payments links in a sale invoice.jpg
>
>
> For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.