OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

8 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order

Error for productStoreId when click on productId link from showcart of purchase order
-------------------------------------------------------------------------------------

Key: OFBIZ-3077
URL: https://issues.apache.org/jira/browse/OFBIZ-3077
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Brajesh Patel
Fix For: SVN trunk

Steps regenerate error:
1) Hit url: https://localhost:8443/ordermgr/control/orderentry
2) Select purchase order with supplier
3) Add product for order
4) Click on the productId from showcart page

it will generate error as following
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail]: java.lang.NullPointerException: Cannot get property 'productStoreId' on null object (Cannot get property 'productStoreId' on null object)

Thanks Rishi, Mridul and Ratnesh for discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order

[ https://issues.apache.org/jira/browse/OFBIZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769331#action_12769331 ]

Joe Eckard commented on OFBIZ-3077:
-----------------------------------

This error occurs because the product detail & product summary screens assume that a product store will always be present. Fixing this is not as easy as fixing the NPE, because you will need to make some larger changes to the logic and display... e.g. if no store is present, should you hide reviews or show all reviews - what about ratings / surveys, estimated ship date vs vendor lead time, etc.

I started working on this but realized it will take more time than I have available right now - adding the note in case someone else is about to take a look.

> Error for productStoreId when click on productId link from showcart of purchase order
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-3077
> URL: https://issues.apache.org/jira/browse/OFBIZ-3077
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Brajesh Patel
> Fix For: SVN trunk
>
>
> Steps regenerate error:
> 1) Hit url: https://localhost:8443/ordermgr/control/orderentry
> 2) Select purchase order with supplier
> 3) Add product for order
> 4) Click on the productId from showcart page
> it will generate error as following
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail]: java.lang.NullPointerException: Cannot get property 'productStoreId' on null object (Cannot get property 'productStoreId' on null object)
> Thanks Rishi, Mridul and Ratnesh for discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769586#action_12769586 ]

Rishi Solanki commented on OFBIZ-3077:
--------------------------------------

Thanks Joe,
For taking interested in fixing this issue, Will be great if you add some notes. We will look after the issue and upload the patch.

--
Rishi

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770010#action_12770010 ]

Ratnesh Upadhyay commented on OFBIZ-3077:
-----------------------------------------

Thanks Joe for your comment. Please let us know, if its all over from your side or do you have any specific notes for the same. Will help us to start work on it.

-- Ratnesh Upadhyay

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778314#action_12778314 ]

Mridul Pathak commented on OFBIZ-3077:
--------------------------------------

As Joe has already stated that we need to do few adjustments in the code based on presence of productStoreId. I would vote for:

# Showing all reviews.
# Skipping surveys.

The third section, which is the most important one and needs productStoreId is getProductVariantTree service invoked in ProductDetail.groovy (line 232). getProductVariantTree service needs productStoreId to get available inventory. In case of PO's we don't need to check for available inventory at all. Now for being able to use the same code to display product detail page in case of a PO, we will need to make modifications to getProductVariantTree service too, which can be done in two ways:
# Add a boolean IN attribute *checkInventory* to service definition, if its true check the available inventory and if false do not.
# A check on productStoreId in the implementation can serve our purpose too.

I like #1 more as it won't eliminate importance of productStoreId in case of a sales order. Looking forward to suggestions from community to handle this situation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amit Sharma updated OFBIZ-3077:
-------------------------------

Attachment: OFBIZ-3077.patch

Here is the patch for the same.

Thanks Mridul Pathak for providing implementation idea to easily cope with.

Regards,
--
Amit Sharma

> Error for productStoreId when click on productId link from showcart of purchase order
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-3077
> URL: https://issues.apache.org/jira/browse/OFBIZ-3077
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Brajesh Patel
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3077.patch
>
>
> Steps regenerate error:
> 1) Hit url: https://localhost:8443/ordermgr/control/orderentry
> 2) Select purchase order with supplier
> 3) Add product for order
> 4) Click on the productId from showcart page
> it will generate error as following
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail]: java.lang.NullPointerException: Cannot get property 'productStoreId' on null object (Cannot get property 'productStoreId' on null object)
> Thanks Rishi, Mridul and Ratnesh for discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-3077:
------------------------------------------

Assignee: Ashish Vijaywargiya

> Error for productStoreId when click on productId link from showcart of purchase order
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-3077
> URL: https://issues.apache.org/jira/browse/OFBIZ-3077
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Brajesh Patel
> Assignee: Ashish Vijaywargiya
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3077.patch
>
>
> Steps regenerate error:
> 1) Hit url: https://localhost:8443/ordermgr/control/orderentry
> 2) Select purchase order with supplier
> 3) Add product for order
> 4) Click on the productId from showcart page
> it will generate error as following
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail]: java.lang.NullPointerException: Cannot get property 'productStoreId' on null object (Cannot get property 'productStoreId' on null object)
> Thanks Rishi, Mridul and Ratnesh for discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-3077.
--------------------------------------

Resolution: Fixed

Thanks Amit / Mridul for the collaborative contribution - Your changes are committed at trunk r882618.

--
Ashish Vijaywargiya

> Error for productStoreId when click on productId link from showcart of purchase order
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-3077
> URL: https://issues.apache.org/jira/browse/OFBIZ-3077
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Brajesh Patel
> Assignee: Ashish Vijaywargiya
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3077.patch
>
>
> Steps regenerate error:
> 1) Hit url: https://localhost:8443/ordermgr/control/orderentry
> 2) Select purchase order with supplier
> 3) Add product for order
> 4) Click on the productId from showcart page
> it will generate error as following
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail]: java.lang.NullPointerException: Cannot get property 'productStoreId' on null object (Cannot get property 'productStoreId' on null object)
> Thanks Rishi, Mridul and Ratnesh for discussion.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.