[jira] Created: (OFBIZ-3097) help link in example is not working

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
help link in example is not working
-----------------------------------

                 Key: OFBIZ-3097
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Erwan de FERRIERES
             Fix For: SVN trunk


when clicking the help link in the example app, the showHelp request is not recognised.
-> added an include in the example controller to the commonext controller
-> created the ExampleHelpData file
-> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3097:
--------------------------------------

    Attachment: OFBIZ-3097.diff

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770856#action_12770856 ]

Hans Bakker commented on OFBIZ-3097:
------------------------------------

Hi Erwan,

sure we can add this, i see now however a dependency on the commonext controller which is also in the webtools controller, only for the 'showHelp' request.....anybody a suggestion how to solve this?

Regards,
Hans

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker reassigned OFBIZ-3097:
----------------------------------

    Assignee: Hans Bakker

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770862#action_12770862 ]

Erwan de FERRIERES commented on OFBIZ-3097:
-------------------------------------------

Hi Hans,

maybe we can add a specific controller just for the help, or copy the request showHelp in the Example component or move the request in the common-controller ?

Regards,

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770864#action_12770864 ]

Hans Bakker commented on OFBIZ-3097:
------------------------------------

also with your solutions the dependency is still there....

in the example controller there will be a line:

<view-map name="showHelp" type="screen" page="component://commonext/widget/HelpScreens.xml#ShowHelp"/>

we could let the 'help' button check if the commonext and content component is active and not show when both are not there.....

inside the controller file there is still a dependency, however no error will be shown because the help button is missing...

anybody a better solution?

Regards,
Hans



> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770896#action_12770896 ]

Erwan de FERRIERES commented on OFBIZ-3097:
-------------------------------------------

Actually, I've seen that there was an error in this patch. the example is loaded before content and then produces error.
I will provide a new version of this patch during the day

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3097:
--------------------------------------

    Attachment: OFBIZ-3097.2.diff

the updated file

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.2.diff, OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772502#action_12772502 ]

Jacques Le Roux commented on OFBIZ-3097:
----------------------------------------

Hi Erwan,

There is still a dependency from framework to applications through
<include location="component://commonext/webapp/WEB-INF/controller.xml"/>
included in
framework/example/webapp/example/WEB-INF/controller.xml



> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.2.diff, OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3097:
--------------------------------------

    Attachment: OFBIZ-3097.3.diff

Hi Jacques,

in this patch, I removed the call to the commonext controller, and added the needed request  and view maps.

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.2.diff, OFBIZ-3097.3.diff, OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3097.
----------------------------------

    Resolution: Fixed

Thanks Erwan,

Your patch is in trunk at r832368.

I fixed a bug at r832371  



> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.2.diff, OFBIZ-3097.3.diff, OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773066#action_12773066 ]

Erwan de FERRIERES commented on OFBIZ-3097:
-------------------------------------------

Hi Jacques,

when commiting, you forgot the files added in the patch.


> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.2.diff, OFBIZ-3097.3.diff, OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773091#action_12773091 ]

Jacques Le Roux commented on OFBIZ-3097:
----------------------------------------

Thanks Erwan,

Done at r832472

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.2.diff, OFBIZ-3097.3.diff, OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES reopened OFBIZ-3097:
---------------------------------------


some entries in the controller.xml are missing, since the remove of the commonext include.

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.2.diff, OFBIZ-3097.3.diff, OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3097:
--------------------------------------

    Attachment: OFBIZ-3097.4.diff

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.2.diff, OFBIZ-3097.3.diff, OFBIZ-3097.4.diff, OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773431#action_12773431 ]

Jacques Le Roux commented on OFBIZ-3097:
----------------------------------------

Hi Erwan,

I'm still unsure it works. I know it does not come from you but all this seems badly syntaxed. For instance see belomw

    <view-map name="showHelp" type="screen" page="component://commonext/widget/HelpScreens.xml#ShowHelp"/>
    <view-map name="ShowDocument" type="screen" page="component://commonext/widget/HelpScreens.xml#showDocument"/>

In you opininon is there a resaon why the case are inversed for showHelp and ShowDocument. Is there a reason why there is no ShowDocument resquest map, even in commonxet ?

Anyway, as it's certainly better your patch is in trunk at r832688. I keep it open for now, feel free to close if you think it should be.

Thanks


> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.2.diff, OFBIZ-3097.3.diff, OFBIZ-3097.4.diff, OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3097) help link in example is not working

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785392#action_12785392 ]

Jacques Le Roux commented on OFBIZ-3097:
----------------------------------------

Bump! Should we no close ?

> help link in example is not working
> -----------------------------------
>
>                 Key: OFBIZ-3097
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3097
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3097.2.diff, OFBIZ-3097.3.diff, OFBIZ-3097.4.diff, OFBIZ-3097.diff
>
>
> when clicking the help link in the example app, the showHelp request is not recognised.
> -> added an include in the example controller to the commonext controller
> -> created the ExampleHelpData file
> -> added the needed line to load the data in the Example ofbiz-component file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.