[jira] Created: (OFBIZ-3126) quantities incorrect when canceling partially shipped items

[Nicolas Malin (Jira)]

 quantities incorrect when canceling partially shipped items
------------------------------------------------------------

                 Key: OFBIZ-3126
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3126
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: Release Branch 9.04, SVN trunk
            Reporter: Si Chen
             Fix For: Release Branch 9.04, SVN trunk


 if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3  because 2 had already been shipped. See enclosed screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen updated OFBIZ-3126:
---------------------------

    Attachment: Picture 9.png

>  quantities incorrect when canceling partially shipped items
> ------------------------------------------------------------
>
>                 Key: OFBIZ-3126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3126
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Si Chen
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: Picture 9.png
>
>
>  if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3  because 2 had already been shipped. See enclosed screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-3126:
----------------------------------------

    Attachment: jira-3126.patch

This fixes two  issues:
  cancelOrderItem was not accounting for the issued quantity, the patched version only canceled the remaining quantity
  reserveInventory was not accounting for the issued quantity, the patched version only re reserve the remaining quantity

>  quantities incorrect when canceling partially shipped items
> ------------------------------------------------------------
>
>                 Key: OFBIZ-3126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3126
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Si Chen
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: jira-3126.patch, Picture 9.png
>
>
>  if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3  because 2 had already been shipped. See enclosed screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-3126:
---------------------------------

    Assignee: Scott Gray

>  quantities incorrect when canceling partially shipped items
> ------------------------------------------------------------
>
>                 Key: OFBIZ-3126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3126
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Si Chen
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: jira-3126.patch, Picture 9.png
>
>
>  if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3  because 2 had already been shipped. See enclosed screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776949#action_12776949 ]

Scott Gray commented on OFBIZ-3126:
-----------------------------------

Was this tested against the trunk?  It doesn't compile.

>  quantities incorrect when canceling partially shipped items
> ------------------------------------------------------------
>
>                 Key: OFBIZ-3126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3126
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Si Chen
>            Assignee: Scott Gray
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: jira-3126.patch, Picture 9.png
>
>
>  if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3  because 2 had already been shipped. See enclosed screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reassigned OFBIZ-3126:
---------------------------------

    Assignee:     (was: Scott Gray)

>  quantities incorrect when canceling partially shipped items
> ------------------------------------------------------------
>
>                 Key: OFBIZ-3126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3126
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Si Chen
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: jira-3126.patch, Picture 9.png
>
>
>  if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3  because 2 had already been shipped. See enclosed screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781573#action_12781573 ]

Albert Mayo commented on OFBIZ-3126:
------------------------------------

By the way, I believe I had this same issue in release 4.0.

>  quantities incorrect when canceling partially shipped items
> ------------------------------------------------------------
>
>                 Key: OFBIZ-3126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3126
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Si Chen
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: jira-3126.patch, Picture 9.png
>
>
>  if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3  because 2 had already been shipped. See enclosed screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Albert Mayo updated OFBIZ-3126:
-------------------------------

    Attachment: cancel quantitys 4.0.patch

I cannot officially contribute, but hopefully the attached patch helps whoever takes it on. The patch is from my own local SVN repository so ignore the revision numbers, but the modifications were done on an OFBiz 4.0 release.

>  quantities incorrect when canceling partially shipped items
> ------------------------------------------------------------
>
>                 Key: OFBIZ-3126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3126
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Si Chen
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: cancel quantitys 4.0.patch, jira-3126.patch, Picture 9.png
>
>
>  if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3  because 2 had already been shipped. See enclosed screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781592#action_12781592 ]

Adrian Crum commented on OFBIZ-3126:
------------------------------------

Albert,

We appreciate your help, but a patch that references a different repository will be unusable. It would help us if you could check out the R 4.0 version, copy your modified file(s) over to it, and then create a patch.

>  quantities incorrect when canceling partially shipped items
> ------------------------------------------------------------
>
>                 Key: OFBIZ-3126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3126
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Si Chen
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: cancel quantitys 4.0.patch, jira-3126.patch, Picture 9.png
>
>
>  if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3  because 2 had already been shipped. See enclosed screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3126:
-----------------------------------

    Issue Type: Sub-task  (was: Bug)
        Parent: OFBIZ-3268

>  quantities incorrect when canceling partially shipped items
> ------------------------------------------------------------
>
>                 Key: OFBIZ-3126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3126
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: order
>    Affects Versions: Release Branch 9.04, SVN trunk
>            Reporter: Si Chen
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: cancel quantitys 4.0.patch, jira-3126.patch, Picture 9.png
>
>
>  if you create a sales order for quantity 5 of a product, and then partially pack and ship 2 of this item, then go back and cancel all the item, the quantity canceled its 5 but should be 3  because 2 had already been shipped. See enclosed screenshot.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.