[jira] Created: (OFBIZ-3159) Move geoAutoCompleter.js from ecommerce to ordermgr

[Nicolas Malin (Jira)]

Move geoAutoCompleter.js from ecommerce to ordermgr
---------------------------------------------------

                 Key: OFBIZ-3159
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3159
             Project: OFBiz
          Issue Type: Improvement
          Components: order, specialpurpose/ecommerce
    Affects Versions: SVN trunk
            Reporter: Mridul Pathak
            Priority: Minor
             Fix For: SVN trunk


geoAutoCompleter.js currently resides in specialpurpose/ecommerce component.  But now it is also used in OrderViewScreen.xml#OrderHeaderView screen.  First of all we can't have dependency of ordermgr on ecommerce component.  Secondly, if I am developing a custom ecommerce application with mount point /ecommerce, thus overriding specialpurpose/ecommerce webapp, and copying the geoAutoCompleter.js to my custom application (to customize) in a directory structure other than that of specialpurpose/ecommerce, then the JS file is not loaded in OrderHeaderView screen due to change of location.  The only reason is the dependency stated above.  Hence this change is vital.

While doing this change, all the references to geoAutoCompleter.js will need to be updated too.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Singh Pandya updated OFBIZ-3159:
--------------------------------------

    Attachment: OFBIZ-3159.patch

Hello Mridul,
Here is patch for the same with needful changes. Please have a look.

> Move geoAutoCompleter.js from ecommerce to ordermgr
> ---------------------------------------------------
>
>                 Key: OFBIZ-3159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3159
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Mridul Pathak
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3159.patch
>
>
> geoAutoCompleter.js currently resides in specialpurpose/ecommerce component.  But now it is also used in OrderViewScreen.xml#OrderHeaderView screen.  First of all we can't have dependency of ordermgr on ecommerce component.  Secondly, if I am developing a custom ecommerce application with mount point /ecommerce, thus overriding specialpurpose/ecommerce webapp, and copying the geoAutoCompleter.js to my custom application (to customize) in a directory structure other than that of specialpurpose/ecommerce, then the JS file is not loaded in OrderHeaderView screen due to change of location.  The only reason is the dependency stated above.  Hence this change is vital.
> While doing this change, all the references to geoAutoCompleter.js will need to be updated too.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773818#action_12773818 ]

Mridul Pathak commented on OFBIZ-3159:
--------------------------------------

Thanks for the patch Arpit, looks good to me.

> Move geoAutoCompleter.js from ecommerce to ordermgr
> ---------------------------------------------------
>
>                 Key: OFBIZ-3159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3159
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Mridul Pathak
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3159.patch
>
>
> geoAutoCompleter.js currently resides in specialpurpose/ecommerce component.  But now it is also used in OrderViewScreen.xml#OrderHeaderView screen.  First of all we can't have dependency of ordermgr on ecommerce component.  Secondly, if I am developing a custom ecommerce application with mount point /ecommerce, thus overriding specialpurpose/ecommerce webapp, and copying the geoAutoCompleter.js to my custom application (to customize) in a directory structure other than that of specialpurpose/ecommerce, then the JS file is not loaded in OrderHeaderView screen due to change of location.  The only reason is the dependency stated above.  Hence this change is vital.
> While doing this change, all the references to geoAutoCompleter.js will need to be updated too.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-3159.
--------------------------------------

    Resolution: Fixed

Thanks Arpit / Mridul - Done at r833026.

--
Ashish Vijaywargiya

> Move geoAutoCompleter.js from ecommerce to ordermgr
> ---------------------------------------------------
>
>                 Key: OFBIZ-3159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3159
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Mridul Pathak
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3159.patch
>
>
> geoAutoCompleter.js currently resides in specialpurpose/ecommerce component.  But now it is also used in OrderViewScreen.xml#OrderHeaderView screen.  First of all we can't have dependency of ordermgr on ecommerce component.  Secondly, if I am developing a custom ecommerce application with mount point /ecommerce, thus overriding specialpurpose/ecommerce webapp, and copying the geoAutoCompleter.js to my custom application (to customize) in a directory structure other than that of specialpurpose/ecommerce, then the JS file is not loaded in OrderHeaderView screen due to change of location.  The only reason is the dependency stated above.  Hence this change is vital.
> While doing this change, all the references to geoAutoCompleter.js will need to be updated too.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-3159:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Move geoAutoCompleter.js from ecommerce to ordermgr
> ---------------------------------------------------
>
>                 Key: OFBIZ-3159
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3159
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Mridul Pathak
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3159.patch
>
>
> geoAutoCompleter.js currently resides in specialpurpose/ecommerce component.  But now it is also used in OrderViewScreen.xml#OrderHeaderView screen.  First of all we can't have dependency of ordermgr on ecommerce component.  Secondly, if I am developing a custom ecommerce application with mount point /ecommerce, thus overriding specialpurpose/ecommerce webapp, and copying the geoAutoCompleter.js to my custom application (to customize) in a directory structure other than that of specialpurpose/ecommerce, then the JS file is not loaded in OrderHeaderView screen due to change of location.  The only reason is the dependency stated above.  Hence this change is vital.
> While doing this change, all the references to geoAutoCompleter.js will need to be updated too.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.