[jira] Created: (OFBIZ-3168) Adding pagination icons to Bluelight theme

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3168) Adding pagination icons to Bluelight theme

Nicolas Malin (Jira)
Adding pagination icons to Bluelight theme
------------------------------------------

                 Key: OFBIZ-3168
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3168
             Project: OFBiz
          Issue Type: Improvement
            Reporter: Bruno Busco
            Priority: Minor


In the attached patch there is a change that allows a theme to replace the "Prev" "Next" labels with icons.
This is actually done on Bluelight

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3168) Adding pagination icons to Bluelight theme

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3168:
-------------------------------

    Attachment: pag.JPG
                OFBIZ-3168 pagination.patch

> Adding pagination icons to Bluelight theme
> ------------------------------------------
>
>                 Key: OFBIZ-3168
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3168
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3168 pagination.patch, pag.JPG
>
>
> In the attached patch there is a change that allows a theme to replace the "Prev" "Next" labels with icons.
> This is actually done on Bluelight

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3168) Adding pagination icons to Bluelight theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774240#action_12774240 ]

Jacques Le Roux commented on OFBIZ-3168:
----------------------------------------

Hi Bruno,

I like it. Should we close or rename to use for other themes ?

> Adding pagination icons to Bluelight theme
> ------------------------------------------
>
>                 Key: OFBIZ-3168
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3168
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3168 pagination.patch, pag.JPG
>
>
> In the attached patch there is a change that allows a theme to replace the "Prev" "Next" labels with icons.
> This is actually done on Bluelight

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3168) Adding pagination icons to Bluelight theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774267#action_12774267 ]

Bruno Busco commented on OFBIZ-3168:
------------------------------------

Sorry Jacques,
when I said "This is actually done on Bluelight" I meant in the attached patch tha needs still to be committed.

I was not able to commit because it is framework.
In any case all the gifs are already been commited to bluelight.

Thank you for reviewing and possibly commit it.


> Adding pagination icons to Bluelight theme
> ------------------------------------------
>
>                 Key: OFBIZ-3168
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3168
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: OFBIZ-3168 pagination.patch, pag.JPG
>
>
> In the attached patch there is a change that allows a theme to replace the "Prev" "Next" labels with icons.
> This is actually done on Bluelight

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3168) Adding pagination icons to Bluelight theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3168.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Thanks Bruno,

Your patch is in trunk at r833378  


> Adding pagination icons to Bluelight theme
> ------------------------------------------
>
>                 Key: OFBIZ-3168
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3168
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Bruno Busco
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3168 pagination.patch, pag.JPG
>
>
> In the attached patch there is a change that allows a theme to replace the "Prev" "Next" labels with icons.
> This is actually done on Bluelight

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.