[jira] Created: (OFBIZ-3175) The icon used for accessing the lookups should be defined by the theme

[Nicolas Malin (Jira)]

The icon used for accessing the lookups should be defined by the theme
----------------------------------------------------------------------

                 Key: OFBIZ-3175
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
            Reporter: Bruno Busco


Hi,
in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3175:
-------------------------------

    Attachment: OFBIZ-3175 lookupfieldicon.patch

If this is OK I will submit a similar patch for the datetime field.

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: OFBIZ-3175 lookupfieldicon.patch
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774746#action_12774746 ]

Pierre Smits commented on OFBIZ-3175:
-------------------------------------

Hi Bruno,

+1 for your proposal. Furthermore, I believe that all image are style related. So the location of the image files should be in a sub folder of the theme folder.

Keep up the good work.

Regards,

Pierre

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: OFBIZ-3175 lookupfieldicon.patch
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774808#action_12774808 ]

Jacques Le Roux commented on OFBIZ-3175:
----------------------------------------

Hi Bruno,

I get a conflict in style.css. I guess it's because if have commited "Collapsible Field Groups with clickable title". Could you please update ?

Thanks

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: OFBIZ-3175 lookupfieldicon.patch
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3175:
-------------------------------

    Attachment: OFBIZ-3175+lookupfieldicon.patch

Hi Jacques,
I do not find any conflict when applying the patch to the latest trunk.
In any case please find attached a more recent patch.

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>         Attachments: OFBIZ-3175 lookupfieldicon.patch, OFBIZ-3175+lookupfieldicon.patch
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3175.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Bruno Busco

Thanks Bruno,

I tried to patch with Eclipse/clipboard and a guess a 3 (default is 2). I retried with 4 and it worked, sorry to disturb you.

Your patch is in trunk at r833937  

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3175 lookupfieldicon.patch, OFBIZ-3175+lookupfieldicon.patch
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker reopened OFBIZ-3175:
--------------------------------


lookup image hiding behing the related field in the flatgrey theme

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3175 lookupfieldicon.patch, OFBIZ-3175+lookupfieldicon.patch, Screenshot.png
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker updated OFBIZ-3175:
-------------------------------

    Attachment: Screenshot.png

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3175 lookupfieldicon.patch, OFBIZ-3175+lookupfieldicon.patch, Screenshot.png
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker closed OFBIZ-3175.
------------------------------

    Resolution: Fixed

never mind, browser cache problem....

sorry for the noise....

Regards,
Hans

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3175 lookupfieldicon.patch, OFBIZ-3175+lookupfieldicon.patch, Screenshot.png
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783635#action_12783635 ]

Jens Falsmar Oechsler commented on OFBIZ-3175:
----------------------------------------------

How about the various ftl files with forms using the hardcoded image? Should they be chaged also or maybe replaced with form widgets? Sorry if this is silly question :)

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3175 lookupfieldicon.patch, OFBIZ-3175+lookupfieldicon.patch, Screenshot.png
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783662#action_12783662 ]

Bruno Busco commented on OFBIZ-3175:
------------------------------------

Hi Jens,
this is not a silly question.
I did something related to what you are writing here.
I have it not yet finished but now that I know that is somebody interested to this I have done the patch that I add here.
Please fill free to review and eventually continue it. ;-)

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3175 lookupfieldicon.patch, OFBIZ-3175+lookupfieldicon.patch, Screenshot.png
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3175:
-------------------------------

    Attachment: OFBIZ-3175 FtlWidgetsMacros.patch

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3175 FtlWidgetsMacros.patch, OFBIZ-3175 lookupfieldicon.patch, OFBIZ-3175+lookupfieldicon.patch, Screenshot.png
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784154#action_12784154 ]

Jens Falsmar Oechsler commented on OFBIZ-3175:
----------------------------------------------

Works nicely here. Can the fieldLookup and renderLookupField macros not share some of the implementation? They just seemed similar to my uninformed eyes.

> The icon used for accessing the lookups should be defined by the theme
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-3175
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3175
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Bruno Busco
>            Assignee: Bruno Busco
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3175 FtlWidgetsMacros.patch, OFBIZ-3175 lookupfieldicon.patch, OFBIZ-3175+lookupfieldicon.patch, Screenshot.png
>
>
> Hi,
> in the attached patch there is a proposal to change the lookup field renderer to have the link image not as a static img field but specified by the theme through a style class.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.