Recent Markup Changes Break Layout
---------------------------------- Key: OFBIZ-3206 URL: https://issues.apache.org/jira/browse/OFBIZ-3206 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Adrian Crum Priority: Minor Recent HTML markup changes have broken the layout of the Flat Grey theme. In order for visual themes to work, the markup can not change - it must remain constant. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-3206: ------------------------------- Attachment: TabBarTrunk.JPG TabBar904.JPG The attached screen shots show the broken layout. The tab-bar CSS class is a button-bar decorator - it is NOT intended to be used alone. > Recent Markup Changes Break Layout > ---------------------------------- > > Key: OFBIZ-3206 > URL: https://issues.apache.org/jira/browse/OFBIZ-3206 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Reporter: Adrian Crum > Priority: Minor > Attachments: TabBar904.JPG, TabBarTrunk.JPG > > > Recent HTML markup changes have broken the layout of the Flat Grey theme. In order for visual themes to work, the markup can not change - it must remain constant. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778179#action_12778179 ] Bruno Busco commented on OFBIZ-3206: ------------------------------------ Hi Adrian, I apologize. What caused this issue is the OFBIZ-3156+newtabbar.patch I attached to OFBIZ-3156. This has been committed to rev. 836044. (its a framework commit I cannot do. Jacques, would you mind?) Also changes 836143 and 836137 are related to this and need to be reverted. (I will revert those two) I did not know of the logic used (a base class style plus optional decorators) but now I have read about it here http://docs.ofbiz.org/display/OFBIZ/OFBiz+maincss.css+HTML+Element+Collection+Styles and I will try to find a different solution to have the Dropping crumbs theme looking like I want without changing the markup. Thank you, Bruno > Recent Markup Changes Break Layout > ---------------------------------- > > Key: OFBIZ-3206 > URL: https://issues.apache.org/jira/browse/OFBIZ-3206 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Reporter: Adrian Crum > Priority: Minor > Attachments: TabBar904.JPG, TabBarTrunk.JPG > > > Recent HTML markup changes have broken the layout of the Flat Grey theme. In order for visual themes to work, the markup can not change - it must remain constant. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778183#action_12778183 ] Jacques Le Roux commented on OFBIZ-3206: ---------------------------------------- Adrian, Bruno, I was also not aware ogh the logic used. I tested all themes but Flat Grey :(. I'm not even sure I would have caught it anyway. I will revert as soon as svn will be available : http://twitter.com/infrabot/statuses/5745621781 If someone beat me on it I will not be vexed, time to sleep here ;) > Recent Markup Changes Break Layout > ---------------------------------- > > Key: OFBIZ-3206 > URL: https://issues.apache.org/jira/browse/OFBIZ-3206 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Reporter: Adrian Crum > Priority: Minor > Attachments: TabBar904.JPG, TabBarTrunk.JPG > > > Recent HTML markup changes have broken the layout of the Flat Grey theme. In order for visual themes to work, the markup can not change - it must remain constant. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778226#action_12778226 ] Bruno Busco commented on OFBIZ-3206: ------------------------------------ I reverted changes 836143 and 836137 into trunk At revision: 880628 Still to be reverted chage 836044 (framework access needed). > Recent Markup Changes Break Layout > ---------------------------------- > > Key: OFBIZ-3206 > URL: https://issues.apache.org/jira/browse/OFBIZ-3206 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Reporter: Adrian Crum > Priority: Minor > Attachments: TabBar904.JPG, TabBarTrunk.JPG > > > Recent HTML markup changes have broken the layout of the Flat Grey theme. In order for visual themes to work, the markup can not change - it must remain constant. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778256#action_12778256 ] Jacques Le Roux commented on OFBIZ-3206: ---------------------------------------- I reverted r836044 at r880658 > Recent Markup Changes Break Layout > ---------------------------------- > > Key: OFBIZ-3206 > URL: https://issues.apache.org/jira/browse/OFBIZ-3206 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Reporter: Adrian Crum > Priority: Minor > Attachments: TabBar904.JPG, TabBarTrunk.JPG > > > Recent HTML markup changes have broken the layout of the Flat Grey theme. In order for visual themes to work, the markup can not change - it must remain constant. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3206. ------------------------------ Resolution: Fixed > Recent Markup Changes Break Layout > ---------------------------------- > > Key: OFBIZ-3206 > URL: https://issues.apache.org/jira/browse/OFBIZ-3206 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Reporter: Adrian Crum > Priority: Minor > Attachments: TabBar904.JPG, TabBarTrunk.JPG > > > Recent HTML markup changes have broken the layout of the Flat Grey theme. In order for visual themes to work, the markup can not change - it must remain constant. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |