[jira] Created: (OFBIZ-3229) Fix two minor issues with the accounting controller.xml

[Nicolas Malin (Jira)]

Fix two minor issues with the accounting controller.xml
-------------------------------------------------------

                 Key: OFBIZ-3229
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3229
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Bob Morley


We have some code that can walk through the controller to services/screens and in doing so we ran into two minor issues that I have fixed here.

a) FixedAssetGeoLocation had its error response going to the wrong view "EditFacility" (which did not exist in this controller).
b) taxAuthorityVATReport was pointing to a view-map entry that was commented out; these are not used and were marked for removal so I have removed both

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3229:
------------------------------

    Attachment: OFBIZ-3229_FixMinorAccountingControllerIssues.patch

> Fix two minor issues with the accounting controller.xml
> -------------------------------------------------------
>
>                 Key: OFBIZ-3229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3229
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3229_FixMinorAccountingControllerIssues.patch
>
>
> We have some code that can walk through the controller to services/screens and in doing so we ran into two minor issues that I have fixed here.
> a) FixedAssetGeoLocation had its error response going to the wrong view "EditFacility" (which did not exist in this controller).
> b) taxAuthorityVATReport was pointing to a view-map entry that was commented out; these are not used and were marked for removal so I have removed both

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780171#action_12780171 ]

Jacques Le Roux commented on OFBIZ-3229:
----------------------------------------

Thanks Bob,

Both are mine :/

I will fix the 1st but will keep the 2d as I still hope to find some time to work on it

> Fix two minor issues with the accounting controller.xml
> -------------------------------------------------------
>
>                 Key: OFBIZ-3229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3229
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3229_FixMinorAccountingControllerIssues.patch
>
>
> We have some code that can walk through the controller to services/screens and in doing so we ran into two minor issues that I have fixed here.
> a) FixedAssetGeoLocation had its error response going to the wrong view "EditFacility" (which did not exist in this controller).
> b) taxAuthorityVATReport was pointing to a view-map entry that was commented out; these are not used and were marked for removal so I have removed both

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780175#action_12780175 ]

Bob Morley commented on OFBIZ-3229:
-----------------------------------

Sounds fine -- can we just comment out the request in #1 like you have with the view-map entries?  My walker finds the request-map and then tries to find the associated view-map and reports an error ...

> Fix two minor issues with the accounting controller.xml
> -------------------------------------------------------
>
>                 Key: OFBIZ-3229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3229
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3229_FixMinorAccountingControllerIssues.patch
>
>
> We have some code that can walk through the controller to services/screens and in doing so we ran into two minor issues that I have fixed here.
> a) FixedAssetGeoLocation had its error response going to the wrong view "EditFacility" (which did not exist in this controller).
> b) taxAuthorityVATReport was pointing to a view-map entry that was commented out; these are not used and were marked for removal so I have removed both

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780287#action_12780287 ]

Jacques Le Roux commented on OFBIZ-3229:
----------------------------------------

Yes sure I will do that rather, or even maybe I will remove them and will create a local patch...

> Fix two minor issues with the accounting controller.xml
> -------------------------------------------------------
>
>                 Key: OFBIZ-3229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3229
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3229_FixMinorAccountingControllerIssues.patch
>
>
> We have some code that can walk through the controller to services/screens and in doing so we ran into two minor issues that I have fixed here.
> a) FixedAssetGeoLocation had its error response going to the wrong view "EditFacility" (which did not exist in this controller).
> b) taxAuthorityVATReport was pointing to a view-map entry that was commented out; these are not used and were marked for removal so I have removed both

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3229.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 9.04
         Assignee: Jacques Le Roux

Thanks Bob,

Fixed in a slightly different way in trunk at r882326, R9.04 at r882330

> Fix two minor issues with the accounting controller.xml
> -------------------------------------------------------
>
>                 Key: OFBIZ-3229
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3229
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 9.04, SVN trunk
>
>         Attachments: OFBIZ-3229_FixMinorAccountingControllerIssues.patch
>
>
> We have some code that can walk through the controller to services/screens and in doing so we ran into two minor issues that I have fixed here.
> a) FixedAssetGeoLocation had its error response going to the wrong view "EditFacility" (which did not exist in this controller).
> b) taxAuthorityVATReport was pointing to a view-map entry that was commented out; these are not used and were marked for removal so I have removed both

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.