[jira] Created: (OFBIZ-3373) Adding menu merging feature

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876024#action_12876024 ]

Scott Gray commented on OFBIZ-3373:
-----------------------------------

Bruno,

Hmm that is strange, I was sure it was all working at the time and I doubt anything has changed in the framework that would have caused it to stop working.  I really don't have time to look into it right now but I'm sure whatever the problem is it could be solved with a minimal amount of debugging.  The controller injections are much simpler than than the menu injections.

When constructed the controller just asks the component config class for any injections and then loads them in, that's really all there is to it.

> Adding menu merging feature
> ---------------------------
>
>                 Key: OFBIZ-3373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3373
>             Project: OFBiz
>          Issue Type: Wish
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of this feature:
> in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876028#action_12876028 ]

Bruno Busco commented on OFBIZ-3373:
------------------------------------

Thank you Scott,
I will find out.

> Adding menu merging feature
> ---------------------------
>
>                 Key: OFBIZ-3373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3373
>             Project: OFBiz
>          Issue Type: Wish
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of this feature:
> in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880558#action_12880558 ]

Bruno Busco commented on OFBIZ-3373:
------------------------------------

I am sorry to say that I was not able to fix this.
Could someone interested, and more expert than me with java, try to fix the patch so that could be committed?
I think it will definitively help in the framework separation.

Thank you,
Bruno

> Adding menu merging feature
> ---------------------------
>
>                 Key: OFBIZ-3373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3373
>             Project: OFBiz
>          Issue Type: Wish
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of this feature:
> in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880571#action_12880571 ]

Scott Gray commented on OFBIZ-3373:
-----------------------------------

I'll try and find some time today to at least get it working again.  That won't make it commit ready though, the roughness I originally mentioned will still be there.

> Adding menu merging feature
> ---------------------------
>
>                 Key: OFBIZ-3373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3373
>             Project: OFBiz
>          Issue Type: Wish
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of this feature:
> in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880620#action_12880620 ]

Scott Gray commented on OFBIZ-3373:
-----------------------------------

There are two problems:
# There is a typo in the googlebase ofbiz-component file, three slashes instead of two for the google base controller location
# Adam made a change to the way URLs are returned from a call to ConfigXMLReader.getControllerConfigUrl(...) in r948439 which means I can no longer use the absolute file path as the key for retrieving injections.  I haven't figured out a way around it yet and won't have the time to look at it again for a while.

> Adding menu merging feature
> ---------------------------
>
>                 Key: OFBIZ-3373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3373
>             Project: OFBiz
>          Issue Type: Wish
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of this feature:
> in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880645#action_12880645 ]

Adam Heath commented on OFBIZ-3373:
-----------------------------------

The url returned by ServletContext.getResource() can not be used outside of the servlet context that it is associated with.  This is why catalina can return those jndi type urls.  You may think that it works fine in catalina, but other containers can do different things.

Also, ServletContext.getRealPath() can return null.

> Adding menu merging feature
> ---------------------------
>
>                 Key: OFBIZ-3373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3373
>             Project: OFBiz
>          Issue Type: Wish
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: googlebase-inject.patch, injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of this feature:
> in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray updated OFBIZ-3373:
------------------------------

    Attachment: injections.patch

Here's a somewhat hackish but working patch.  Not intended for commit but useful for trying the injections stuff.

> Adding menu merging feature
> ---------------------------
>
>                 Key: OFBIZ-3373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3373
>             Project: OFBiz
>          Issue Type: Wish
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: googlebase-inject.patch, injections.patch, injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of this feature:
> in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896799#action_12896799 ]

Bruno Busco commented on OFBIZ-3373:
------------------------------------

Scott,
what you think it should be done better in the patch to be committed?

> Adding menu merging feature
> ---------------------------
>
>                 Key: OFBIZ-3373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3373
>             Project: OFBiz
>          Issue Type: Wish
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: googlebase-inject.patch, injections.patch, injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of this feature:
> in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896827#action_12896827 ]

Scott Gray commented on OFBIZ-3373:
-----------------------------------

Not sure :-)
I sort of threw it together as a proof of concept without putting much effort into code quality or naming conventions.  

Either this weekend coming or the one after I'll brush it off, give it another look and hopefully a tidy up, I do want to get it committed sometime soon.  Thanks for the reminder :-)

> Adding menu merging feature
> ---------------------------
>
>                 Key: OFBIZ-3373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3373
>             Project: OFBiz
>          Issue Type: Wish
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: googlebase-inject.patch, injections.patch, injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of this feature:
> in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896867#action_12896867 ]

Bruno Busco commented on OFBIZ-3373:
------------------------------------

That's great!
Once commited I will try to use the new feature to get more components independence.

> Adding menu merging feature
> ---------------------------
>
>                 Key: OFBIZ-3373
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3373
>             Project: OFBiz
>          Issue Type: Wish
>          Components: framework
>            Reporter: Bruno Busco
>            Priority: Minor
>         Attachments: googlebase-inject.patch, injections.patch, injections.patch, links.jpg, partymenu.JPG
>
>
> Hi devs,
> while discussing in the ML about modules and framework separation I thought to this new feature that I would like to discuss here with you.
> We have now the possibility to extend a menu from one other. This is great in order to have an high level of code reuse and great consistency all over OFBiz.
> I was thinking to a sort of "merges-to" property for the menu widget.
> This would allow a new module to specify an already exixting menu name (in the framework core or in a lower level module) that should be somewhat changed by the actual menu.
> For instance, in the attached image partymenu.jpg there is a a tipical use of this feature:
> in the party module there are lot of links that co to order application, account etc. Those menu link could be used defining a simple menu (say it partylinks_menu) in the party application that contains only party or framework related links (i.e. profile); additional components like order or accounting could define more menus that merges-to the partylinks_manu so that when the menu is rendered IN THE PARTY APPLICATION the new menu items added in the order and accounting applications are also rendered.
> This would allow us to dramatically reduce the component dependence and help us to have the framework-only distribution.
> To eventually implement this I think there should be an entity that defines such mergin menus and the menu rendered should lookup the entity to check if one or more merges to the actually rendering menu is defined.
> I would appreciate to hear from you if this idea can help.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.