[jira] Created: (OFBIZ-3469) Link back to login page from Forgot Password page

[Nicolas Malin (Jira)]

Link back to login page from Forgot Password page
-------------------------------------------------

                 Key: OFBIZ-3469
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
             Project: OFBiz
          Issue Type: Bug
          Components: party
    Affects Versions: SVN trunk
         Environment: Demo site, IE 8
            Reporter: Koon Sang
            Priority: Trivial


There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3469.
----------------------------------

      Assignee: Jacques Le Roux
    Resolution: Won't Fix

The browser back button is enough, else please provide a patch...

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-3469:
------------------------------

    Attachment: back.patch

Here is the patch which fixes the issue.

HTH :)

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: back.patch
>
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868142#action_12868142 ]

Jacques Le Roux commented on OFBIZ-3469:
----------------------------------------

Thanks Ankit,

Your patch is in trunk at r945037  

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: back.patch
>
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-3469:
------------------------------------


Ankit,

I reverted r945037 at r945042  

Because I found it's not right when going back from  logout -> forgot password, I got this error message

org.ofbiz.webapp.control.RequestHandlerException: Unknown request [authview]; this request does not exist or cannot be called directly.

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: back.patch
>
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-3469:
------------------------------

    Attachment: BACK.patch

Hello Jacques,

i found the reason its because some controller dont have the request [authview] ,so at some places like content,.. its giving the above error but working at many places like party, accounting, order,...

So i add the request in common-controller & attached the patch for it.

Thanks :)

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: BACK.patch, back.patch
>
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3469.
----------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Thanks Ankit,

Your last patch is in trunk at r945061  

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: BACK.patch, back.patch
>
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-3469:
------------------------------

    Attachment: controller.patch

Hi jacques,

In this patch i just removed the extra code from the controllers, the request is already in the common-controller . So dont need to write the request[authView] twice...

Thanks :)

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: BACK.patch, back.patch, controller.patch
>
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872896#action_12872896 ]

Jacques Le Roux commented on OFBIZ-3469:
----------------------------------------

Hi Ankit,

I agree but then there are plenty others. I listed more than a dozen, just look for uri="authview"...

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: BACK.patch, back.patch, controller.patch
>
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-3469:
------------------------------

    Attachment: updated_3469.patch

Thanks Jacques ,

Here is the patch in this i removed the rest (which i forgot) requests from the other controllers too, which includes common-controller.xml .

Thanks jacques for reminding me :)

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: BACK.patch, back.patch, controller.patch, updated_3469.patch
>
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872925#action_12872925 ]

Jacques Le Roux commented on OFBIZ-3469:
----------------------------------------

Thanks Ankit,

Your patch is in trunk at r949142  

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: BACK.patch, back.patch, controller.patch, updated_3469.patch
>
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872927#action_12872927 ]

Ankit Jain commented on OFBIZ-3469:
-----------------------------------

Thanks Jacques
HTH :)

> Link back to login page from Forgot Password page
> -------------------------------------------------
>
>                 Key: OFBIZ-3469
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3469
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Demo site, IE 8
>            Reporter: Koon Sang
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: BACK.patch, back.patch, controller.patch, updated_3469.patch
>
>
> There should be a link back to login page in Forgot Password page (https://ofbiz-vm.apache.org/partymgr/control/forgotPassword) in case the user wants to cancel his operation.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.