[jira] Created: (OFBIZ-3490) Create theme build script
Locked
12
12
[jira] Created: (OFBIZ-3490) Create theme build script
 
|
Create theme build script
------------------------- Key: OFBIZ-3490 URL: https://issues.apache.org/jira/browse/OFBIZ-3490 Project: OFBiz Issue Type: New Feature Affects Versions: SVN trunk Environment: ant build Reporter: BJ Freeman Priority: Minor I liked the build script for a new component, so I decided to make one for themes. unfortunately I am not able to do a patch so included the script. I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3490) Create theme build script
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BJ Freeman updated OFBIZ-3490: ------------------------------ Attachment: themesbuild.txt this is not a patch for the actual script > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: SVN trunk > Environment: ant build > Reporter: BJ Freeman > Priority: Minor > Attachments: themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835919#action_12835919 ] BJ Freeman commented on OFBIZ-3490: ----------------------------------- once a create an new theme I compare between the new one and one I did not use as a source to see what needs to be changed. > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Priority: Minor > Attachments: themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BJ Freeman updated OFBIZ-3490: ------------------------------ Affects Version/s: Release Branch 9.04 > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Priority: Minor > Attachments: themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BJ Freeman updated OFBIZ-3490: ------------------------------ Attachment: themebutildpatch.txt hear is the patch > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Priority: Minor > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BJ Freeman closed OFBIZ-3490. ----------------------------- Fix Version/s: SVN trunk Resolution: Fixed I see a create-theme in the build can not find the commit for it so can not reference when it was put in. so closing this issue. > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856792#action_12856792 ] Jacques Le Roux commented on OFBIZ-3490: ---------------------------------------- Hi BJ, I think the create-theme target you saw is your own because there are none in the build file. BTW I wonder what's the point since it's easy to simply copy a theme dir and then poke in. Did you do something more in your patch (I did not take the time to review)? Thanks > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856958#action_12856958 ] BJ Freeman commented on OFBIZ-3490: ----------------------------------- your are probably correct. as far as the script, if you copy you are ask to rename the top folder but the sub-folders and files are not renamed. like the data file and the folder under webapp. it is not a big thing but it is easier than remembering what has to done. > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Reopened: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-3490: ------------------------------------ Assignee: Jacques Le Roux I see, then I will review it. From what I laready saw I think we should improve the comment at end, say we ask for the dir names, and it would be great to also rename inside of files but I don't think it's easy (even feasible?) with ant Thanks > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857044#action_12857044 ] BJ Freeman commented on OFBIZ-3490: ----------------------------------- if you want to go that far then a java class would be used, if I remember right. will look into expanding it. since is say create should ask of things like graphics to replace in the directories. > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857051#action_12857051 ] Jacques Le Roux commented on OFBIZ-3490: ---------------------------------------- I'd not worry too much. We could simply improve the documentation (ie messages on screen) to inform people what to do by hand and such. What do you think? > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857460#action_12857460 ] BJ Freeman commented on OFBIZ-3490: ----------------------------------- good enough for a start can always improve latter if the inclination hits me. > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857663#action_12857663 ] BJ Freeman commented on OFBIZ-3490: ----------------------------------- A thought occurs to me that with Multi tenant, there will be a need to let the tenant create there own theme. so this may be a mute point since that code would be in the content component. > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860194#action_12860194 ] Jacques Le Roux commented on OFBIZ-3490: ---------------------------------------- Interesting idea about tenant theme... I agree that we should think about a mechanism for them. But I don't think that OOTB we should have to much themes, maintaining them all begins to be burden... > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860250#action_12860250 ] BJ Freeman commented on OFBIZ-3490: ----------------------------------- I agree. if you think the script if worth putting in the build fine, if not fine. My last comment was that eventually there will be stuff in configure and content to create themes so this would not be needed. since they would be loaded from the configure no reboot would be necessary. content would write the files and configure of the Defualt would load the data into the tenants db. > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860255#action_12860255 ] Jacques Le Roux commented on OFBIZ-3490: ---------------------------------------- Yes, I will commit, not exactly as is as, as I said, I'd like to add some "documentation" in ant messages to help users to complete the task manually. If you take care of it, fine. Else I will do when I will get a chance. > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860259#action_12860259 ] BJ Freeman commented on OFBIZ-3490: ----------------------------------- I will review it and see what more I can document. if you want to point me in a direction I will do my best to put it in. > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860298#action_12860298 ] Jacques Le Roux commented on OFBIZ-3490: ---------------------------------------- * You ask for theme name when it's actually the name of the dir containing the theme which is asked/used. * We could also explain in the last message that the user will need to change visualThemeId and resourceValue in the ${source-theme}ThemeData.xml file before they try their new theme It's all what I remember, there are maybe some other stuff that could added later... Thanks > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860301#action_12860301 ] Jacques Le Roux commented on OFBIZ-3490: ---------------------------------------- * Ha also inside the ofbiz-component.xml file! > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3490) Create theme build script
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860684#action_12860684 ] BJ Freeman commented on OFBIZ-3490: ----------------------------------- Just walked through doing this and it is more than a script can handle even in doc. so going to do a wiki on how to do themes then put a link in the script. > Create theme build script > ------------------------- > > Key: OFBIZ-3490 > URL: https://issues.apache.org/jira/browse/OFBIZ-3490 > Project: OFBiz > Issue Type: New Feature > Affects Versions: Release Branch 9.04, SVN trunk > Environment: ant build > Reporter: BJ Freeman > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: themebutildpatch.txt, themesbuild.txt > > > I liked the build script for a new component, so I decided to make one for themes. > unfortunately I am not able to do a patch so included the script. > I made it so you can pick a theme as the template and copy the files over to the new theme. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |