[jira] Created: (OFBIZ-3537) Not all sales invoice item types are showing in listInvoiceItems screen

[Nicolas Malin (Jira)]

Not all sales invoice item types are showing in listInvoiceItems screen
-----------------------------------------------------------------------

                 Key: OFBIZ-3537
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3537
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Willem Janssen
             Fix For: SVN trunk
         Attachments: invoiceitemtypes.diff

Hello,

In the listInvoiceItems screen, in the 'Invoice Item Type' dropdown item types are missing.

In the GetInvoiceItemTypes.groovy file the query on the InvoiceItemType entity does not look for item types with:

- invoiceItemTypeId = SINVOICE_HEAD_ADJ
- parenttypeId = SINVOICE_HEAD_ADJ
- invoiceItemTypeId = SINVOICE_ITM_ADJ
- parenttypeId = SINVOICE_ITM_ADJ

and the invoice item types that are missing answer the above parameters.

The patch adds these parameters to the groovy file.

This seems to be a solutions that's not finished yet, because the splitting of item types between Purchase and Sales invoice item types looks uncompleted. On the one hand there is a parentItemType PINVOICE_ADJ, but there's no SINVOICE_ADJ. Same goes for PINV_PROD_ITEM and no SINV_PROD_ITEM. And there's a SINVOICE_HEAD_ADJ, but no PINVOICE_HEAD_ADJ.

If somebody can tell me which invoiceitemtypes should be grouped in which parenttypes I'd be happy to make a patch for that...



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Janssen updated OFBIZ-3537:
----------------------------------

    Attachment: invoiceitemtypes.diff

> Not all sales invoice item types are showing in listInvoiceItems screen
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3537
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3537
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Willem Janssen
>             Fix For: SVN trunk
>
>         Attachments: invoiceitemtypes.diff
>
>
> Hello,
> In the listInvoiceItems screen, in the 'Invoice Item Type' dropdown item types are missing.
> In the GetInvoiceItemTypes.groovy file the query on the InvoiceItemType entity does not look for item types with:
> - invoiceItemTypeId = SINVOICE_HEAD_ADJ
> - parenttypeId = SINVOICE_HEAD_ADJ
> - invoiceItemTypeId = SINVOICE_ITM_ADJ
> - parenttypeId = SINVOICE_ITM_ADJ
> and the invoice item types that are missing answer the above parameters.
> The patch adds these parameters to the groovy file.
> This seems to be a solutions that's not finished yet, because the splitting of item types between Purchase and Sales invoice item types looks uncompleted. On the one hand there is a parentItemType PINVOICE_ADJ, but there's no SINVOICE_ADJ. Same goes for PINV_PROD_ITEM and no SINV_PROD_ITEM. And there's a SINVOICE_HEAD_ADJ, but no PINVOICE_HEAD_ADJ.
> If somebody can tell me which invoiceitemtypes should be grouped in which parenttypes I'd be happy to make a patch for that...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray updated OFBIZ-3537:
------------------------------

    Attachment: InvoiceItemType.txt

Willem, I don't know if it's of any use to you but I'm attaching a tree of all of the InvoiceItemTypes which may help you see that some types aren't missing, they are just inconsistently named.

> Not all sales invoice item types are showing in listInvoiceItems screen
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-3537
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3537
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Willem Janssen
>             Fix For: SVN trunk
>
>         Attachments: InvoiceItemType.txt, invoiceitemtypes.diff
>
>
> Hello,
> In the listInvoiceItems screen, in the 'Invoice Item Type' dropdown item types are missing.
> In the GetInvoiceItemTypes.groovy file the query on the InvoiceItemType entity does not look for item types with:
> - invoiceItemTypeId = SINVOICE_HEAD_ADJ
> - parenttypeId = SINVOICE_HEAD_ADJ
> - invoiceItemTypeId = SINVOICE_ITM_ADJ
> - parenttypeId = SINVOICE_ITM_ADJ
> and the invoice item types that are missing answer the above parameters.
> The patch adds these parameters to the groovy file.
> This seems to be a solutions that's not finished yet, because the splitting of item types between Purchase and Sales invoice item types looks uncompleted. On the one hand there is a parentItemType PINVOICE_ADJ, but there's no SINVOICE_ADJ. Same goes for PINV_PROD_ITEM and no SINV_PROD_ITEM. And there's a SINVOICE_HEAD_ADJ, but no PINVOICE_HEAD_ADJ.
> If somebody can tell me which invoiceitemtypes should be grouped in which parenttypes I'd be happy to make a patch for that...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.