[jira] Created: (OFBIZ-3592) application - workeffort

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3592) application - workeffort

Nicolas Malin (Jira)
application - workeffort
------------------------

                 Key: OFBIZ-3592
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3592
             Project: OFBiz
          Issue Type: Sub-task
            Reporter: Bob Morley




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3592) application - workeffort

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3592:
------------------------------

    Attachment: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch

> application - workeffort
> ------------------------
>
>                 Key: OFBIZ-3592
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3592
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>         Attachments: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3592) application - workeffort

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3592:
------------------------------

    Attachment: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch

Complete replacement of previous patch.  I had forgotten to scan for extra "suppresswarnings" annotations which brought up a number of additional changes.  These were mostly due to adding a generic list to a non-generic collection form a third party library.  I added a new method to UtilMisc named collectionAddAll (consistent with other collection methods) that everyone can use in these cases to avoid the warning messages.  (This in affect buries the warning into one method much like a number of the UtilGenerics methods do).

The depreciated TimeOfDayRange temporal expression was in here and I understand it can not be removed at this time.  I removed the import and fully specified the package name where it was used that was with-in a method that suppresses that warning.  After next release the entire class / visitor artifacts can be removed.

> application - workeffort
> ------------------------
>
>                 Key: OFBIZ-3592
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3592
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3592) application - workeffort

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3592:
------------------------------

    Attachment:     (was: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch)

> application - workeffort
> ------------------------
>
>                 Key: OFBIZ-3592
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3592
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (OFBIZ-3592) application - workeffort

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley resolved OFBIZ-3592.
-------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

> application - workeffort
> ------------------------
>
>                 Key: OFBIZ-3592
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3592
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (OFBIZ-3592) application - workeffort

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley reopened OFBIZ-3592:
-------------------------------


> application - workeffort
> ------------------------
>
>                 Key: OFBIZ-3592
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3592
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-3592) application - workeffort

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-3592:
----------------------------------

    Assignee: Adrian Crum

> application - workeffort
> ------------------------
>
>                 Key: OFBIZ-3592
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3592
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>            Assignee: Adrian Crum
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3592) application - workeffort

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-3592.
------------------------------

    Resolution: Fixed

Fixed, rev 930626. Thanks Bob!

I didn't apply the patch to ICalRecurConverter because a utility method isn't needed. Most of those ical4j classes extend ArrayList, so they can be cast to a List to fix the warnings. Even after doing that, the code starts to look really messy. I decided to leave it as-is for now and check to see if a newer version of ical4j is available that is written for Java 5 or later.


> application - workeffort
> ------------------------
>
>                 Key: OFBIZ-3592
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3592
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Bob Morley
>            Assignee: Adrian Crum
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3592_ResolveJavaWarningsWorkeffort.patch
>
>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.