[jira] Created: (OFBIZ-362) Adding Tax ID in invoice header

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
27 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
Adding Tax ID in invoice header
-------------------------------

                 Key: OFBIZ-362
                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: accounting
            Reporter: Eriks Dobelis
            Priority: Minor
         Attachments: headerTaxID.diff

In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Eriks Dobelis updated OFBIZ-362:
--------------------------------

    Attachment: headerTaxID.diff

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>            Priority: Minor
>         Attachments: headerTaxID.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Eriks Dobelis updated OFBIZ-362:
--------------------------------

    Attachment: invoicetaxid.diff

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>            Priority: Minor
>         Attachments: headerTaxID.diff, invoicetaxid.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Eriks Dobelis updated OFBIZ-362:
--------------------------------

    Attachment: viewinvoice.ftl.diff

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>            Priority: Minor
>         Attachments: headerTaxID.diff, invoicetaxid.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Eriks Dobelis updated OFBIZ-362:
--------------------------------

    Attachment: invoicetaxid.diff

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>            Priority: Minor
>         Attachments: headerTaxID.diff, invoicetaxid.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-362?page=comments#action_12440263 ]
           
Eriks Dobelis commented on OFBIZ-362:
-------------------------------------

This is a newer version, which also shows Tax ID of the billing party in a similar manner.

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>            Priority: Minor
>         Attachments: headerTaxID.diff, invoicetaxid.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Eriks Dobelis updated OFBIZ-362:
--------------------------------

    Attachment: invoicetaxid.diff

This fixes a bug in the patch. Use only the latest invoicetaxid.diff

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>            Priority: Minor
>         Attachments: headerTaxID.diff, invoicetaxid.diff, invoicetaxid.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Jacopo Cappellato updated OFBIZ-362:
------------------------------------

    Attachment:     (was: invoicetaxid.diff)

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>            Priority: Minor
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Jacopo Cappellato updated OFBIZ-362:
------------------------------------

    Attachment:     (was: invoicetaxid.diff)

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>            Priority: Minor
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Eriks Dobelis updated OFBIZ-362:
--------------------------------

    Attachment: invoicetaxid.diff

Sorry for so many changes, but this is one more bugfix to protect from situations when billingAddress cannot be determined.

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>            Priority: Minor
>         Attachments: headerTaxID.diff, invoicetaxid.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Jacopo Cappellato updated OFBIZ-362:
------------------------------------

    Attachment:     (was: invoicetaxid.diff)

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>            Priority: Minor
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Jacques Le Roux reassigned OFBIZ-362:
-------------------------------------

    Assignee: Jacques Le Roux

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-362?page=all ]

Jacques Le Roux closed OFBIZ-362.
---------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Committed in revision 453663, tested in simple case, works well. Thanks Eriks

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-362?page=comments#action_12440515 ]
           
Si Chen commented on OFBIZ-362:
-------------------------------

Jacques,

Before you commit this change, I think we'd better discuss how to handle changes like this in general.  Displaying one's tax id on invoices is definitely not a standard practice here in the United States.  In fact, it's not even done.  So should we make the company header configurable, just leave it to the user to customize, or incorporate all the possible customizations like this one which may make it better for some countries but not as good for others?

Si

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-362?page=comments#action_12440520 ]
           
Jacopo Cappellato commented on OFBIZ-362:
-----------------------------------------

Si,

we could leave the mods to the bsh script and simply comment out the mods to the ftl files (maybe adding a comment about the meaning of the two fields)... does it make sense?



> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-362?page=comments#action_12440532 ]
           
Jacques Le Roux commented on OFBIZ-362:
---------------------------------------

Si,

If you agree with Jacopo proposition I might make the changes and comments in BSH. What do you think ?

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-362?page=comments#action_12440535 ]
           
Si Chen commented on OFBIZ-362:
-------------------------------

Yes, that sounds good.  

I'm just getting concerned about this companyheader.  If you remember, a long long time ago (by ofbiz standards, anyway--about 15 months), I created this file as a separate file.  My original intent was actually to have a text file which people would edit and put their logo and whatever they wanted.  Then over time it's been enhanced, and now I see more and more customizations being added which might really just be features needed by a particular end user, and it's becoming harder and harder to work with this file.

Also, just out of curiosity, have you tested what effect this patch has on the company header for sales and purchase orders?

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-362?page=comments#action_12440544 ]
           
Jacques Le Roux commented on OFBIZ-362:
---------------------------------------

Ok, for the moment I comment out mods and add some comments in the bsh.

I tested it only in a simple sale case (DemoCustomer buying an item from eCommerce).

From your explanations I wonder if splitting the viewInvoice.fo.ftl file would not be a solution, what do you think ?

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-362?page=comments#action_12440549 ]
           
Jacques Le Roux commented on OFBIZ-362:
---------------------------------------

I commented out mods and add some comments in the bsh. Committed in revision 453703.

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-362) Adding Tax ID in invoice header

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-362?page=comments#action_12440653 ]
           
Eriks Dobelis commented on OFBIZ-362:
-------------------------------------

This is not a requirement of just one specific case, it generally applies to all 25 EU countries as far as I know and probably many more having VAT tax regulation.

If there is no Country level tax authority associated, then the Tax ID is just not printed, so I don't see a problem for users who don't care about Tax ID - they just don't enter those and invoice is created without them. So I don't see the need for commenting out - it is checked in the if statement anyway, and I can add some more conditionals if it still gets printed when it shouldn't.

The correct solution would be to separate Sales tax from VAT tax, and if the company doesn't have VAT tax id - then don't print it (as would be the case in US), if it has then - print it (as it is most probably required). This would require a lot of effort throughout the Ofbiz as Sales tax and VAT tax are currently treated as being the same though they are not.

> Adding Tax ID in invoice header
> -------------------------------
>
>                 Key: OFBIZ-362
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-362
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Eriks Dobelis
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: headerTaxID.diff, invoicetaxid.diff, viewinvoice.ftl.diff
>
>
> In certain countries if the invoice contains VAT you have to display VAT tax ID on the invoice. My patch checks whether the company has registered with tax authority in the country of the billing address, and if yes then includes Tax ID in the invoice header.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
12