OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3621) XHTML validation errors (themes)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

17 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3621) XHTML validation errors (themes)

XHTML validation errors (themes)
--------------------------------

Key: OFBIZ-3621
URL: https://issues.apache.org/jira/browse/OFBIZ-3621
Project: OFBiz
Issue Type: Bug
Components: themes
Affects Versions: SVN trunk
Reporter: Blas Rodriguez Somoza
Priority: Trivial
Fix For: SVN trunk

XHTML validation errors

* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

Other errors:

Header.ftl
Line 108. Wrong markup. Div can't be inside <a>
<a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>

Style.css
Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
background: url(../images/ofbiz_logo.png) no-repeat;

Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.

Patch attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3621) XHTML validation errors (themes)

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> Patch attached.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3621:
-----------------------------------------

Description:
XHTML validation errors

* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

Other errors:

Header.ftl (tomahawk & droppingcrumbs)
Line 108. Wrong markup. Div can't be inside <a>
<a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>

Style.css (tomahawk & droppingcrumbs)
Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
background: url(../images/ofbiz_logo.png) no-repeat;

Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.

appbarOpen.ftl (droppingcrumbs)
Line 99, unclosed <li> and <ul>

header.ftl (bizznesstime)
Line 111. div can't be inside span.

Updated patch attached (v2)

was:
XHTML validation errors

* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.

Other errors:

Header.ftl
Line 108. Wrong markup. Div can't be inside <a>
<a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>

Style.css
Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
background: url(../images/ofbiz_logo.png) no-repeat;

Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.

Patch attached.

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco reassigned OFBIZ-3621:
----------------------------------

Assignee: Bruno Busco

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3621:
-------------------------------

Attachment: black_space.JPG

Hi Blas,
I tested this patch but I have got an issue with the new logo handling (please see black_space.jpg).
At least in the tomahawk theme there is a black like just below the logo.
Could you please check it?
I use FF 3.6.2

Thank you,
Bruno

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851671#action_12851671 ]

Blas Rodriguez Somoza edited comment on OFBIZ-3621 at 3/31/10 12:31 AM:
------------------------------------------------------------------------

Hello Bruno

It's true, although I don't note it previously.
The dark line appear because the height of the li element is greater than the height of the image due to an error in the browser implementation, only Opera seems to do the right thing.
See the li_img_error.jpg (the yellow rectangle is the image outer box and the red rectangle is the ul outter box)
To solve the problem, the ul height must be fixed in the "masthead li ul" css entry. Before my patches, this height is fixed in the logo-area css entry which now is obsolete.
I make the correction for tomahawk and droppingcrumbs

I added a corrected patch (v3)

was (Author: brsomoza):
Hello Bruno

It's true, although I don't note it previously.
The problem because the height of the li element are greater than the height of the image due to an error in the browser implementation, only Opera seems to do the right thing.
See the li_img_error.jpg (the yellow rectangle is the image outer box and the red rectangle is the ul outter box)
To solve the problem, the ul height must be fixed in the "masthead li ul" css entry. Before my patches, this height is fixed in the logo-area css entry which now is obsolete.
I make the correction for tomahawk and droppingcrumbs

I added a corrected patch (v3)

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851733#action_12851733 ]

Bruno Busco commented on OFBIZ-3621:
------------------------------------

Hi Blas,
with this latest implementation we have the img jpg file definet in the markup (and that is fine since the backoffice UI has toos to set this) while the jpg height should be set in the CSS.
I think this is not a good solution since we should be able to have all the stuff set in one of the two, the markup OR the css.
Do you agree?

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff, OFBIZ-3621_themes_xhtml_v4.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851803#action_12851803 ]

Blas Rodriguez Somoza commented on OFBIZ-3621:
----------------------------------------------

Hi Bruno

Yes I do, editing css to change the logo height is not a good solution.
It should be possible to change the logo ans its size from the ui or replacing the files without need to edit the css.

Removing the height from css, AFAIK there are two solutions to solve the error in LI height:
1.- Increase background height. header_top_bg.gif height should be 4 pixel greater than ofbiz_logo.gif.
2.- Decrease ul size with css (margin-bottom: - n px)

But solution 1 don't work for droppingcrumbs, so I use solution 2.

I tested using FF 3.5, IE 7, Opera 10 and Chrome. The errors are 4px Firefox, 2px IE and 0px (no error) in Opera and Chrome.

I also changed the background css from repeat-x to repeat, because this change don't modify the default theme display and allow someone to use a background with smaller height than the logo.

With the new patch (v4) , the logo and its size can be changed without editing css, using the UI or replacing the logo file.

Is this a good solution for you ?

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff, OFBIZ-3621_themes_xhtml_v4.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852484#action_12852484 ]

Blas Rodriguez Somoza commented on OFBIZ-3621:
----------------------------------------------

I've found a better solution, which seems to work for all the browsers without errors.
I'll attach it ASAP.

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff, OFBIZ-3621_themes_xhtml_v4.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff, OFBIZ-3621_themes_xhtml_v4.diff, OFBIZ-3621_themes_xhtml_v5.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852621#action_12852621 ]

Blas Rodriguez Somoza commented on OFBIZ-3621:
----------------------------------------------

Hi Bruno.

Thanks for your time.

Finally your comments shows me that changing the logo url from css to markup could be disrupting and I look again for a simpler solution, which I didn't find initially.
And I find it, the new patch (v5) only replaces div with span and changes the css sizing from the div to the li element which contain the logo, this is enough to render the page header exactly as it is now and avoid the xhtml validation error.

Regards.
Blas

Note: Although I'll not use it, I've found the way to avoid the LI height error in FF and IE (using line-height:0 and font-size:0)

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff, OFBIZ-3621_themes_xhtml_v4.diff, OFBIZ-3621_themes_xhtml_v5.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-3621) XHTML validation errors (themes)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco closed OFBIZ-3621.
------------------------------

Resolution: Fixed

Thank you Blas,
your patch is in trunk at revision: 931665

> XHTML validation errors (themes)
> --------------------------------
>
> Key: OFBIZ-3621
> URL: https://issues.apache.org/jira/browse/OFBIZ-3621
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: black_space.JPG, li_img_error.jpg, OFBIZ-3621_themes_xhtml_v2.diff, OFBIZ-3621_themes_xhtml_v3.diff, OFBIZ-3621_themes_xhtml_v4.diff, OFBIZ-3621_themes_xhtml_v5.diff, OFBIZ_3621-themes_xhtml.diff
>
>
> XHTML validation errors
> * Unclosed INPUT
> * attributes without values (checked, selected, disabled, etc)
> * attribute values without "
> * Uppercase tags or attributes.
> * Unencoded ampersands in urls.
> Other errors:
> Header.ftl (tomahawk & droppingcrumbs)
> Line 108. Wrong markup. Div can't be inside <a>
> <a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
> Style.css (tomahawk & droppingcrumbs)
> Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
> background: url(../images/ofbiz_logo.png) no-repeat;
> Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
> The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
> appbarOpen.ftl (droppingcrumbs)
> Line 99, unclosed <li> and <ul>
> header.ftl (bizznesstime)
> Line 111. div can't be inside span.
> Updated patch attached (v2)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.