[jira] Created: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
Fix .classpath for hamcrest.jar inclusion
-----------------------------------------

                 Key: OFBIZ-3630
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
             Project: OFBiz
          Issue Type: Bug
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Bob Morley
             Fix For: SVN trunk


It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley updated OFBIZ-3630:
------------------------------

    Attachment: OFBIZ-3630_AddHamcrestToClasspath.patch

> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Morley resolved OFBIZ-3630.
-------------------------------

    Resolution: Fixed

> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851982#action_12851982 ]

Adrian Crum commented on OFBIZ-3630:
------------------------------------

I'm confused. How can this issue be fixed if it hasn't been committed? If you close an issue before it is committed, then how will committers find it when they search for open issues?


> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851987#action_12851987 ]

Bob Morley commented on OFBIZ-3630:
-----------------------------------

Hey Adrian, I had talked a bit with Jacques on the use of "resolved" in JIRA.  The line of thinking was if a non-contributor applies a patch to a JIRA ticket that resolves the issue then they can move it to that status so that there is some distinguishing status vs. normal created JIRAs that report bugs (but have no solution).  From my understanding contributors can pickup resolved (but not closed) issues to review the patch and commit it and then close the issue.  I believe if everyone was ok with this it was going to be modified in the best practices.

Let's start a dialog if we think this is incorrect usage of the "resolved" status.  The current best practices suggested things were moved directly to closed so it was currently not being used at all.

In this case can we just commit the patch?  :)

> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851986#action_12851986 ]

Tim Ruppert commented on OFBIZ-3630:
------------------------------------

Thanks for asking that Adrian - I thought it, but figured I must've been missing something.  

> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851990#action_12851990 ]

Adrian Crum commented on OFBIZ-3630:
------------------------------------

Bob,

Thanks for the explanation. From my perspective, no additional discussion is needed - I understand now.


> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851991#action_12851991 ]

Adam Heath commented on OFBIZ-3630:
-----------------------------------

Resolved is used by the person who actually fixes the problem.  Closed is used when the fix has been confirmed.

> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath reopened OFBIZ-3630:
-------------------------------


> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851993#action_12851993 ]

Scott Gray commented on OFBIZ-3630:
-----------------------------------

Standard Jira issue navigation only displays issues with an unresolved status by default, so resolving the issue does a lot to hide it from committers.

> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851994#action_12851994 ]

Adam Heath commented on OFBIZ-3630:
-----------------------------------

Additionally, for obviously simple problems, going straight to close is ok in my opinion.

> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3630) Fix .classpath for hamcrest.jar inclusion

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath closed OFBIZ-3630.
-----------------------------

    Resolution: Fixed

fixed in version 929640.

> Fix .classpath for hamcrest.jar inclusion
> -----------------------------------------
>
>                 Key: OFBIZ-3630
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3630
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3630_AddHamcrestToClasspath.patch
>
>
> It appears that the hamcrest.jar has been added to help in some of the cache related unit tests.  This just adds it to the .classpath so that the project can compile in Eclipse.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.