[jira] Created: (OFBIZ-3647) Create dataResource from content
Locked
[jira] Created: (OFBIZ-3647) Create dataResource from content
 
|
Create dataResource from content
-------------------------------- Key: OFBIZ-3647 URL: https://issues.apache.org/jira/browse/OFBIZ-3647 Project: OFBiz Issue Type: Improvement Components: content Affects Versions: SVN trunk Reporter: nicolas malin When you create a content, you need create a data resource and return to content for create association. If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3647) Create dataResource from content
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3647: --------------------------------- Priority: Minor (was: Major) > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: nicolas malin > Priority: Minor > Attachments: content.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3647: --------------------------------- Attachment: content.patch > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: nicolas malin > Attachments: content.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray reassigned OFBIZ-3647: --------------------------------- Assignee: Scott Gray > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Scott Gray > Priority: Minor > Attachments: content.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854036#action_12854036 ] Scott Gray commented on OFBIZ-3647: ----------------------------------- Hi Nicolas, Thanks for the patch, here is my review: # createDataResourceAndGiveType has the following problems: ## It is unnecessary, I can't see any reason why you have switched from using the event that was already there ## The description is wrong ## I don't like using the service response code to return values, this is what events are for ## In the implementation there is no need to do an entity-one because createDataResource returns the GenericValue # createDataResourceAndAssocToContent ## the "template" service attribute should be a boolean or at the very least a char or Character and why not make the name more verbose like useTemplateDataResourceId? ## please correct the indentation of the if-compare + else elements ## use the updateContent service, you should almost never persist an entity directly > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Scott Gray > Priority: Minor > Attachments: content.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854388#action_12854388 ] Hans Bakker commented on OFBIZ-3647: ------------------------------------ did you have a look at the 'persistContentAndAssoc' service? it looks like it is doing what you want? Regards, hans > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Scott Gray > Priority: Minor > Attachments: content.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854395#action_12854395 ] nicolas malin commented on OFBIZ-3647: -------------------------------------- Oh, I missed a service, I look at it tonight Hans Nicolas > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Scott Gray > Priority: Minor > Attachments: content.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856563#action_12856563 ] nicolas malin commented on OFBIZ-3647: -------------------------------------- To Hans : The persistContentAndAssoc service create a content and a dataressource. It's not my purpose. I search to create a content by generic screen and assoc a dataresource directly by the generic dataResource screen To Scott : Thanks Scott or the review, my response ;) : 1.1 I have a memory brainless :( I hate java event call and i propably tried to pass this call to a service call ;) . I can remove this code in the patch. 1.2 arf 1.3 I understand, I had a different view before your comment but I find the java event complex and daunting 1.4 :) your right, 'll teach me not to read the service 2.1 ok for useTemplateDataResourceId, no pb. I change it in the next patch 2.2 ok same 2.1 2.3 Your right, It's stupid to store directly. I create a new patch without createDataResourceAndGiveType service in few days (I hope). Nicolas > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Scott Gray > Priority: Minor > Attachments: content.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3647: --------------------------------- Attachment: OFBIZ-3647.patch Hi Scott I update the patch improvement has you wish. Sorry for the latency :/ Nicolas > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Scott Gray > Priority: Minor > Attachments: content.patch, OFBIZ-3647.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881611#action_12881611 ] Erwan de FERRIERES commented on OFBIZ-3647: ------------------------------------------- Hi Scott, did you got a chance to take a new look at the patch provided by Nicolas ? Do you think there is more to go, or can this be committed to trunk ? Thanks, Erwan > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Scott Gray > Priority: Minor > Attachments: content.patch, OFBIZ-3647.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881617#action_12881617 ] Scott Gray commented on OFBIZ-3647: ----------------------------------- Hi Erwan, I'm sorry I should have unassigned myself from it, I originally took it on because I was working on content related stuff at the time. I haven't had a chance to review the latest patch, if you want to take it on then by all means please do so. Thanks Scott > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Scott Gray > Priority: Minor > Attachments: content.patch, OFBIZ-3647.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES updated OFBIZ-3647: -------------------------------------- Assignee: Erwan de FERRIERES (was: Scott Gray) > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Priority: Minor > Attachments: content.patch, OFBIZ-3647.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-3647. ------------------------------------- Resolution: Fixed > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Priority: Minor > Attachments: content.patch, OFBIZ-3647.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3647) Create dataResource from content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906840#action_12906840 ] Erwan de FERRIERES commented on OFBIZ-3647: ------------------------------------------- Doen at r993395 Thanks Nicolas > Create dataResource from content > -------------------------------- > > Key: OFBIZ-3647 > URL: https://issues.apache.org/jira/browse/OFBIZ-3647 > Project: OFBiz > Issue Type: Improvement > Components: content > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Erwan de FERRIERES > Priority: Minor > Attachments: content.patch, OFBIZ-3647.patch > > > When you create a content, you need create a data resource and return to content for create association. > If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |