OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

19 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

CSS Style for select wrong in tomahawk theme
--------------------------------------------

Key: OFBIZ-3653
URL: https://issues.apache.org/jira/browse/OFBIZ-3653
Project: OFBiz
Issue Type: Bug
Components: themes
Affects Versions: SVN trunk
Reporter: Blas Rodriguez Somoza
Priority: Minor
Fix For: SVN trunk

The css style of select in style.css

select {
background-color: #fffcea;
border: #999999 solid 0.1em;
font-size: 1.1em;
height: 1.6em; /* force ctrl to scale with text */
margin: 0.1em;
}

uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
this gives a ugly look and in IE could cut the lower part of the text.

input[type="text"],input[type="password"] {
background-color: #fffcea;
border:0.1em solid #999999;
font-size: 1.1em;
margin: 0.2em;
padding:0.4em 0;
}

The proposed css style for select is (height and margin changed, padding added)

select {
background-color: #fffcea;
border: #999999 solid 0.1em;
font-size: 1.1em;
height: 2.1em; /* force ctrl to scale with text */
margin: 0.2em;
padding: 0.1em;
}

Attached images of IE, FF and Chrome with the existing style and the proposed one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3653:
-----------------------------------------

Attachment: tomahawk_chrome_before.jpg
tomahawk_ie_before.jpg
tomahawk_ff_before.jpg

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select in style.css
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> Attached images of IE, FF and Chrome with the existing style and the proposed one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3653:
-----------------------------------------

Attachment: tomahawk_chrome_after.jpg
tomahawk_ie_after.jpg
tomahawk_ff_after.jpg

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3653:
-----------------------------------------

Description:
The css style of select tag in style.css
uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
this gives a ugly look and in IE could cut the lower part of the text.

existing style.css:

select {
background-color: #fffcea;
border: #999999 solid 0.1em;
font-size: 1.1em;
height: 1.6em; /* force ctrl to scale with text */
margin: 0.1em;
}

input[type="text"],input[type="password"] {
background-color: #fffcea;
border:0.1em solid #999999;
font-size: 1.1em;
margin: 0.2em;
padding:0.4em 0;
}

The proposed css style for select is the following (height and margin changed, padding added)

select {
background-color: #fffcea;
border: #999999 solid 0.1em;
font-size: 1.1em;
height: 2.1em; /* force ctrl to scale with text */
margin: 0.2em;
padding: 0.1em;
}

The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.

Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

was:
The css style of select in style.css

select {
background-color: #fffcea;
border: #999999 solid 0.1em;
font-size: 1.1em;
height: 1.6em; /* force ctrl to scale with text */
margin: 0.1em;
}

uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
this gives a ugly look and in IE could cut the lower part of the text.

input[type="text"],input[type="password"] {
background-color: #fffcea;
border:0.1em solid #999999;
font-size: 1.1em;
margin: 0.2em;
padding:0.4em 0;
}

The proposed css style for select is (height and margin changed, padding added)

select {
background-color: #fffcea;
border: #999999 solid 0.1em;
font-size: 1.1em;
height: 2.1em; /* force ctrl to scale with text */
margin: 0.2em;
padding: 0.1em;
}

Attached images of IE, FF and Chrome with the existing style and the proposed one.

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco reassigned OFBIZ-3653:
----------------------------------

Assignee: Bruno Busco

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco closed OFBIZ-3653.
------------------------------

Resolution: Fixed

Thank you Blas,
your patch is in trunk at revision: 931618

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Reopened: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco reopened OFBIZ-3653:
--------------------------------

Hi Blas,
I have found that this change actually breaks the select in the pagination bar. Please see the pagination_select.jpg screenshot.
Can you find a better solution?

Thank you Bruno.

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855709#action_12855709 ]

Blas Rodriguez Somoza commented on OFBIZ-3653:
----------------------------------------------

Hi Bruno

A quick solution, adding "height:auto" to the .nav-pager select solve the issue
I added also margin-top:0; with it the select seems better vertically centered.

.nav-pager select{
background-color: #ACABA9;
margin-left:10px;
border:none;
height: auto;
margin-top: 0;
}

Is this OK for you ?

I can't send you the patch file because I've other pending changes in my local copy.

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco closed OFBIZ-3653.
------------------------------

Resolution: Fixed

Yes,
this seems fine.
Committed to the trunk at revision 932895

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Reopened: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza reopened OFBIZ-3653:
------------------------------------------

Hello Bruno

I've found that tables with inner forms (like the one in Content Manager -> Content Setup) need more work in the css.

The patch I attach takes care of that and even enhances the layout of non list forms.

There are 2 more issues with forms that you can see, for example, at :
AR -> Payments -> Edit -> Header (wrong layout)
Acc->Fixed Assets-> Edit -> Standard costs (asterisk of from date appear in a new line)

Those 2 problems are not related with css. The source of the problems is that field-lookup and calendar-view are rendered as <div>(block) and should be <span>(inline)
I've those 2 problems solved in my local copy and I'll open the jira entry, with the patch, when I finish with the xhtml patches.

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3653_css.diff, pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3653_css.diff, pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza updated OFBIZ-3653:
-----------------------------------------

Attachment: OFBIZ-3653_before2_listform.jpg
OFBIZ-3653_before2_halign.jpg
OFBIZ-3653_after2_listform.jpg

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3653_after2_halign.jpg, OFBIZ-3653_after2_listform.jpg, OFBIZ-3653_before2_halign.jpg, OFBIZ-3653_before2_listform.jpg, OFBIZ-3653_css.diff, pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3653_after2_halign.jpg, OFBIZ-3653_after2_listform.jpg, OFBIZ-3653_before2_halign.jpg, OFBIZ-3653_before2_listform.jpg, OFBIZ-3653_css.diff, pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857623#action_12857623 ]

Blas Rodriguez Somoza commented on OFBIZ-3653:
----------------------------------------------

I've added 4 new screenshots to show the effect of the patch. Those starting with OFBIZ-3653

As can be seen in the halign example, the previous small vertical misalignment between selects and text fields disappear.

The listform don't need comments, it is clear enough by itself.

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3653_after2_halign.jpg, OFBIZ-3653_after2_listform.jpg, OFBIZ-3653_before2_halign.jpg, OFBIZ-3653_before2_listform.jpg, OFBIZ-3653_css.diff, pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858113#action_12858113 ]

Bruno Busco commented on OFBIZ-3653:
------------------------------------

Thank you Blas,
your patch is in trunk at revision: 935149

BTW I noted another wrong alignment that I will show you with a screenshot.

Thank you for all your work on these topics.
Bruno

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3653_after2_halign.jpg, OFBIZ-3653_after2_listform.jpg, OFBIZ-3653_before2_halign.jpg, OFBIZ-3653_before2_listform.jpg, OFBIZ-3653_css.diff, pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-3653:
-------------------------------

Attachment: fieldname_alignment.jpg

There are several vertical alignment issues between field names and the textbox, select etc.
This is not caused by the committed patch but related in subject.

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: fieldname_alignment.jpg, OFBIZ-3653_after2_halign.jpg, OFBIZ-3653_after2_listform.jpg, OFBIZ-3653_before2_halign.jpg, OFBIZ-3653_before2_listform.jpg, OFBIZ-3653_css.diff, pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858125#action_12858125 ]

Blas Rodriguez Somoza commented on OFBIZ-3653:
----------------------------------------------

Hi Bruno

This is exactly the problem that I refer to in my comment 11/Apr/10 10:50 PM

AR -> Payments -> Edit -> Header (wrong layout)

I've a patch for this also, but I need OFBIZ-3671 committed before, because the solution for those problems imply not only styles, but also htmlFormMacroLibrary.flt

I'll close this issue.

I'll open a new JIRA issue with the patch for this problem as soon as OFBIZ-3671 is closed.

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: fieldname_alignment.jpg, OFBIZ-3653_after2_halign.jpg, OFBIZ-3653_after2_listform.jpg, OFBIZ-3653_before2_halign.jpg, OFBIZ-3653_before2_listform.jpg, OFBIZ-3653_css.diff, pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-3653) CSS Style for select wrong in tomahawk theme

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blas Rodriguez Somoza closed OFBIZ-3653.
----------------------------------------

Resolution: Fixed

> CSS Style for select wrong in tomahawk theme
> --------------------------------------------
>
> Key: OFBIZ-3653
> URL: https://issues.apache.org/jira/browse/OFBIZ-3653
> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: SVN trunk
> Reporter: Blas Rodriguez Somoza
> Assignee: Bruno Busco
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: fieldname_alignment.jpg, OFBIZ-3653_after2_halign.jpg, OFBIZ-3653_after2_listform.jpg, OFBIZ-3653_before2_halign.jpg, OFBIZ-3653_before2_listform.jpg, OFBIZ-3653_css.diff, pagination_select.JPG, tomahawk_chrome_after.jpg, tomahawk_chrome_before.jpg, tomahawk_ff_after.jpg, tomahawk_ff_before.jpg, tomahawk_ie_after.jpg, tomahawk_ie_before.jpg
>
>
> The css style of select tag in style.css
> uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em
> this gives a ugly look and in IE could cut the lower part of the text.
> existing style.css:
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 1.6em; /* force ctrl to scale with text */
> margin: 0.1em;
> }
> input[type="text"],input[type="password"] {
> background-color: #fffcea;
> border:0.1em solid #999999;
> font-size: 1.1em;
> margin: 0.2em;
> padding:0.4em 0;
> }
> The proposed css style for select is the following (height and margin changed, padding added)
> select {
> background-color: #fffcea;
> border: #999999 solid 0.1em;
> font-size: 1.1em;
> height: 2.1em; /* force ctrl to scale with text */
> margin: 0.2em;
> padding: 0.1em;
> }
> The result in IE is not good because IE 7 don't support select styling correctly, but it is better than previously.
> Attached images of FF 3.5 , IE 7 and Chrome with the existing style and the proposed one.