[jira] Created: (OFBIZ-3659) Download cobertura code coverage jar so it can be used to compile and execute tests with

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854819#action_12854819 ]

Bob Morley commented on OFBIZ-3659:
-----------------------------------

Scott -- I have just left the two targets here that can be invoked manually.  After verifying and doing a check-in, can you modify the Buildbot to do an ant download-cobertura after the svn checkout (but before the run-install).

Adrian -- I hunted around Apache Commons; but not being very familiar I was not sure what I was looking for.  I looked at IO because it had an old Cobertura report generated from 2008; but it appears they no longer generate code coverage that way.  Commons Lang has code coverage but they use Bamboo/Clover.  The one build file that had download-dependency target (it was for junit) was very nice, but all it really did was have their "run-tests" have dependency on it ...

Whatever we do, if we are going to move the deployment of the jar so it is not a pre-req for our build, we will have to refactor so we can build our Cobertura integration pieces after the fact.  This could manifest in a "run-coverage-tests" target, or something else -- but some work would have to be done.

> Download cobertura code coverage jar so it can be used to compile and execute tests with
> ----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3659
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3659
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch
>
>
> Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process.  Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container).  Net result is when we run our tests we will now get very nice code coverage metrics being generated.
> There is an existing target to generate the cobertura report (html) which is not automatically being executed.  Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854830#action_12854830 ]

Adrian Crum commented on OFBIZ-3659:
------------------------------------

Bob,

You can't see the man behind the curtain if your gaze is focused on the smokey image in front of you. Browse the Apache Commons repository to see how things are set up. Or do a checkout of one of their projects. I would recommend commons/sandbox/convert ;-).

> Download cobertura code coverage jar so it can be used to compile and execute tests with
> ----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3659
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3659
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch
>
>
> Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process.  Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container).  Net result is when we run our tests we will now get very nice code coverage metrics being generated.
> There is an existing target to generate the cobertura report (html) which is not automatically being executed.  Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854837#action_12854837 ]

Bob Morley commented on OFBIZ-3659:
-----------------------------------

Adrian -- That is precisely what I did and I don't really see what you are getting at.  I just went and grabbed the fantastic mr. convert as well ... It is not distinctively different from what we are doing, if you ignore the fact that we can not use ant junit targets because we have to invoke our tests through start.  They have a nicely isolated dependency grab; but the compile depends on it ... the only piece I see is it can be shutoff based on a a sysclasspath.  What am I missing?

> Download cobertura code coverage jar so it can be used to compile and execute tests with
> ----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3659
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3659
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch
>
>
> Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process.  Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container).  Net result is when we run our tests we will now get very nice code coverage metrics being generated.
> There is an existing target to generate the cobertura report (html) which is not automatically being executed.  Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854842#action_12854842 ]

Adrian Crum commented on OFBIZ-3659:
------------------------------------

The metrics are not run unless you invoke Maven - "mvn site:site". The normal build does not include metrics. So, we could have something similar (hopefully without Maven) that produces metrics outside a basic build.

> Download cobertura code coverage jar so it can be used to compile and execute tests with
> ----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3659
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3659
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch
>
>
> Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process.  Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container).  Net result is when we run our tests we will now get very nice code coverage metrics being generated.
> There is an existing target to generate the cobertura report (html) which is not automatically being executed.  Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901361#action_12901361 ]

Erwan de FERRIERES commented on OFBIZ-3659:
-------------------------------------------

Hi all,
what is missing on this issue to be integrated ?

Cheers,

> Download cobertura code coverage jar so it can be used to compile and execute tests with
> ----------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3659
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3659
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Bob Morley
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3659_AutomateDownloadOfCobertura.patch
>
>
> Framework executed around allowing use of cobertura to create code coverage metrics as part of the Ofbiz build process.  Licensing restricts distribution of cobertura with Ofbiz, so we have taken the approach to attempt to download it before doing our build so it is available for any container that wants instrumentation turned on (currently only test-container).  Net result is when we run our tests we will now get very nice code coverage metrics being generated.
> There is an existing target to generate the cobertura report (html) which is not automatically being executed.  Once we get more reasonable code coverage via unit testing we can automatically generate this and expose it as appropriate.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.