[jira] Created: (OFBIZ-3702) provide better user help

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859840#action_12859840 ]

chris snow commented on OFBIZ-3702:
-----------------------------------

Hi Adrian,

My second example fieldLabelTooltip_DO_NOT_COMMIT.patch uses the ofbiz properties files for storing the entity field descriptions.  My first example, was using the description attribute in entitymodel and this early attempt would have to altered the entitymodel xsd to support i18n.

Many thanks again,

Chris

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859851#action_12859851 ]

Adrian Crum commented on OFBIZ-3702:
------------------------------------

Chris,

I'm not sure what your last comment means. I don't see anything in your latest patch that utilizes the existing entity field description internationalization. Please see how it is implemented in the Example component.

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859936#action_12859936 ]

chris snow commented on OFBIZ-3702:
-----------------------------------

Hi Adrian, sorry for the misunderstanding. I have taken a look at the example component and that implementation will help a lot. Many thanks, chris

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

chris snow updated OFBIZ-3702:
------------------------------

    Attachment: fieldLabelTooltip2__DO_NOT_COMMIT.patch

The patch "fieldLabelTooltip2__DO_NOT_COMMIT.patch" provides tooltips using the entity resource files as pointed out by Adrian.

This approach requires only a few small change to ofbiz:

1) provide code for looking up the entity description (e.g. TooltipHelp.java)
2) refactor the ftl macro renderFieldTitle so that title is rename to fieldTitle
3) make the entity-name specific in some form definitions (see the statusId field in the patch)

What do you think dev's?  Is this approach ok?  I may be able to get the patch in the 10.04 deadline...

Many thanks,

Chris

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

chris snow updated OFBIZ-3702:
------------------------------

    Attachment: fieldLabelTooltip2.png

screenshot of example component using the patch "fieldLabelTooltip2_DO_NOT_COMMIT.patch"

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860905#action_12860905 ]

chris snow commented on OFBIZ-3702:
-----------------------------------

Hi Devs, any comments on fieldLabelTooltip2__DO_NOT_COMMIT.patch ?

Many thanks,

Chris

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860961#action_12860961 ]

Adrian Crum commented on OFBIZ-3702:
------------------------------------

The getHelp method looks good. I haven't tried the patch.

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861301#action_12861301 ]

Jacques Le Roux commented on OFBIZ-3702:
----------------------------------------

Hi Chris,

I agree with Adrian, but the tabs ;) Also when you create a patch, please create it from root rather than anywhere else: easier to apply

Like Scott, I think we should have a property somewhere (widget.properties) to be able to quickly switching off all the help.

I quickly tried the patch but was unable to see anything under the fields of a newly created example using this URL https://localhost:8443/example/control/EditExample?exampleId=10000. What could I have missed?

My concern was to not have a too short delay before the help shows. Else we would better have an icon as you 1st suggested...

Also I got this error while trying under Inventory Store fields

2010-04-27 10:10:03,812 (http-0.0.0.0-28443-1) [      ScreenFactory.java:128:INFO ] Got 22 screens in 0.016s
2010-04-27 10:10:05,062 (http-0.0.0.0-28443-1) [        TooltipHelp.java:40 :ERROR]
---- exception report ----------------------------------------------------------
Exception: org.ofbiz.entity.GenericModelException
Message: Could not find definition for entity name
---- stack trace ---------------------------------------------------------------
org.ofbiz.entity.GenericModelException: Could not find definition for entity name
org.ofbiz.entity.model.ModelReader.getModelEntity(ModelReader.java:452)
org.ofbiz.widget.form.TooltipHelp.getHelp(TooltipHelp.java:30)
org.ofbiz.widget.form.MacroFormRenderer.renderFieldTitle(MacroFormRenderer.java:1213)
org.ofbiz.widget.form.ModelForm.renderSingleFormString(ModelForm.java:1051)
org.ofbiz.widget.form.ModelForm.renderFormString(ModelForm.java:837)
org.ofbiz.widget.screen.ModelScreenWidget$Form.renderWidgetString(ModelScreenWidget.java:839)
org.ofbiz.widget.screen.MacroScreenRenderer.renderScreenletSubWidget(MacroScreenRenderer.java:710)
org.ofbiz.widget.screen.ModelScreenWidget$Screenlet.renderWidgetString(ModelScreenWidget.java:406)

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

chris snow updated OFBIZ-3702:
------------------------------

    Attachment: fieldTooltipHelp3.patch

In this patch, I have:

- fixed the exception reported by Jacques
- use a widget.properties attribute to globally control tooltip help (widget.form.displayhelpText=Y)

I don't think we can control the popup delay without using css or javascript, which would mean every page having to have the correct script or style entries.

Anyone willing to commit?

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861517#action_12861517 ]

chris snow edited comment on OFBIZ-3702 at 4/27/10 4:07 PM:
------------------------------------------------------------

In this patch (fieldTooltipHelp3.patch), I have:

- fixed the exception reported by Jacques
- use a widget.properties attribute to globally control tooltip help (widget.form.displayhelpText=Y)

I don't think we can control the popup delay without using css or javascript, which would mean every page having to have the correct script or style entries.

Anyone willing to commit?

      was (Author: snowch):
    In this patch, I have:

- fixed the exception reported by Jacques
- use a widget.properties attribute to globally control tooltip help (widget.form.displayhelpText=Y)

I don't think we can control the popup delay without using css or javascript, which would mean every page having to have the correct script or style entries.

Anyone willing to commit?
 

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3702:
--------------------------------------

    Assignee: Jacques Le Roux

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Jacques Le Roux
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3702.
----------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed

Thanks Chris,

Your (slightly modified ) patch is in trunk at r938844  

I have just removed the author reference as we prefer to keep them out of OFBiz code (it's not an Apache rule only a convention between OFBiz developers)

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861753#action_12861753 ]

chris snow commented on OFBIZ-3702:
-----------------------------------

Thanks Jacques!  In my spare time, I now have the big task of providing patches with all the help text!

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861758#action_12861758 ]

Jacques Le Roux commented on OFBIZ-3702:
----------------------------------------

It would be very good indeed.

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray reopened OFBIZ-3702:
-------------------------------


http://markmail.org/message/xpbtj6oxnnwaqplv

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

chris snow updated OFBIZ-3702:
------------------------------

    Attachment: fieldTooltipHelp4.patch

The attached patch (fieldTooltipHelp4.patch) addresses the concerns mentioned by Scott, except for changes required to the templates *FormMacroLibrary.ftl, for which I have a question:

How does the following code snippet work (from csvFormMacroLibrary.ftl?

{code}<#macro renderFieldTitle style title><@renderField title />, </#macro>{code}

Many thanks,

Chris

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, fieldTooltipHelp4.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861945#action_12861945 ]

chris snow commented on OFBIZ-3702:
-----------------------------------

Perhaps the solution would be to change the renderFieldTitle methods as below.  The changes below only add a new optional parameter for the fieldHelpText leaving the title parameter unchanged, this would minimise the impact to existing code, but is slightly confusing because the title parameter does not provide the content for the span's title attribute.

Any thoughts?

{code}
HtmlFormMacroLibrary.ftl

<#macro renderFieldTitle style title fieldHelpText="">
    <#if fieldHelpText?has_content>
        <span title="${fieldHelpText}"><#t/>
    </#if>
    <#if style?has_content>
        <span class="${style}"><#t/>
    </#if>
    ${title}<#t/>
    <#if style?has_content>
        </span><#t/>
    </#if>
    <#if fieldHelpText?has_content>
        </span><#t/>
    </#if>    
</#macro>

foFormMacroLibrary.ftl

<#macro renderFieldTitle style title fieldHelpText="">${title?default("")}</#macro>

xmlFormMacroLibrary.ftl

<#macro renderFieldTitle style title fieldHelpText=""></#macro>

textFormMacroLibrary.ftl

<#macro renderFieldTitle style title fieldHelpText=""><@renderField title /></#macro>

csvFormMacroLibrary.ftl

<#macro renderFieldTitle style title fieldHelpText=""><@renderField title />, </#macro>
{code}

Many thanks,

Chris

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, fieldTooltipHelp4.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862113#action_12862113 ]

Jacques Le Roux commented on OFBIZ-3702:
----------------------------------------

Thanks Chris,

Your patch is in trunk at r939216. For me your proposition above is ok, could you provide a patch please?

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, fieldTooltipHelp4.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862125#action_12862125 ]

chris snow commented on OFBIZ-3702:
-----------------------------------

Thanks Jacques - I will provide the other patch tonight when I get home from work...

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, fieldTooltipHelp4.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

chris snow updated OFBIZ-3702:
------------------------------

    Attachment: fieldTooltipHelp5.patch

fieldTooltipHelp5.patch fixes the remaining macro templates

> provide better user help
> ------------------------
>
>                 Key: OFBIZ-3702
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3702
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Release Candidate Branch 10.04, SVN trunk
>            Reporter: chris snow
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: entity_field_tooltip_screenshot.png, fieldLabelTooltip.png, fieldLabelTooltip2.png, fieldLabelTooltip2__DO_NOT_COMMIT.patch, fieldLabelTooltip_DO_NOT_COMMIT.patch, fieldTooltipHelp3.patch, fieldTooltipHelp4.patch, fieldTooltipHelp5.patch, help.png, product_entitymodel.patch, tooltip_help_DO_NOT_COMMIT.patch
>
>
> Please see http://n4.nabble.com/Providing-users-with-help-td1840416.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.