[jira] Created: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
Locked
123
123
[jira] Commented: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858249#action_12858249 ] Adam Heath commented on OFBIZ-3708: ----------------------------------- Sure, div and span are different. There default css properties are different. But you can change that easily enough. I did review the screenshots. Which is why I knew I could make my comment. <html> <head> <style> div { border:1px solid red; } .span { display:inline; } </style> </head> <body> before <div class="div"> a div </div> middle <div class="span"> another div </div> after </body> </html> > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Issue Comment Edited: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858249#action_12858249 ] Adam Heath edited comment on OFBIZ-3708 at 4/17/10 9:05 PM: ------------------------------------------------------------ Sure, div and span are different. There default css properties are different. But you can change that easily enough. I did review the screenshots. Which is why I knew I could make my comment. The following html shows a div being displayed inline, no newline before or after. Very simple to do. <html> <head> <style> div { border:1px solid red; } .span { display:inline; } </style> </head> <body> before <div class="div"> a div </div> middle <div class="span"> another div </div> after </body> </html> was (Author: doogie): Sure, div and span are different. There default css properties are different. But you can change that easily enough. I did review the screenshots. Which is why I knew I could make my comment. <html> <head> <style> div { border:1px solid red; } .span { display:inline; } </style> </head> <body> before <div class="div"> a div </div> middle <div class="span"> another div </div> after </body> </html> > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858251#action_12858251 ] Adam Heath commented on OFBIZ-3708: ----------------------------------- To restate, changing from div to span, just to fix alignment/display issues, is not the correct fix. My example shows that a div can be displayed perfectly inline. Now, if there is some problem with a div being *inside* a span, or other inline-type element, then that can be discussed, and implemented separately. However, my gut reaction is that the html and css specs don't forbid that(I could be wrong on this). > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858253#action_12858253 ] Blas Rodriguez Somoza commented on OFBIZ-3708: ---------------------------------------------- Hi Adam I agree with you here, making unneeded changes is always a bad solution. But I don't like making changes greater that those really needed, and so I don't switch to span without a reason. Of course you don't know me and so you can't know what kind of things I do. Yes, xhtml forbids a block element (like div) to be inside a inline element (like span). I attach a very simple xhtml page which contains a div inside a span and which you can test at w3c validator. Just go to http://validator.w3.org/#validate_by_input and copy and paste the following xhtml page -------------------------- <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html lang="en" dir="ltr" xmlns="http://www.w3.org/1999/xhtml"> <head> <title>div span example</title> </head> <body> <span> <div> Text </div> </span> </body> </html> -------------------------- As you can see the W3C validator give you a validation error with the following text: ------------------------- Line 9, Column 7: document type does not allow element "div" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag The mentioned element is not allowed to appear in the context in which you've placed it; the other mentioned elements are the only ones that are both allowed there and can contain the element mentioned. This might mean that you need a containing element, or possibly that you've forgotten to close a previous element. One possible cause for this message is that you have attempted to put a block-level element (such as "<p>" or "<table>") inside an inline element (such as "<a>", "<span>", or "<font>"). ------------------------- As you can see in the last line, putting block elements (DIV) inside a inline elements (SPAN) is not allowed. You can get a more lengthly explanation in the HTML standard sections 7.5.3 and 7.5.4 (http://www.w3.org/TR/html401/struct/global.html#h-7.5.3) What do you think now ? > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858254#action_12858254 ] Adrian Crum commented on OFBIZ-3708: ------------------------------------ I agree with Blas. A div is a block element and a span is an inline element. If a field row is a block element, then using spans within that block element to style the individual artifacts (icons, indicators, etc) in that block is appropriate. Putting those inline elements inside a ul element is incorrect also. As far as I can tell, the markup in the patch is semantically correct. > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858255#action_12858255 ] Adam Heath commented on OFBIZ-3708: ----------------------------------- You gave a list of 3 items as to why using div was bad. However, the first 2 were not accurate, as the css allows you to change alignments and end-of-line stuff. Changing to span when the field is already in some inline type element is fine. However, I hope the patch is minimal, and only fixes these inline problems, and doesn't just change all the div field stuff to span to fix some possible display problem. > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858257#action_12858257 ] Blas Rodriguez Somoza commented on OFBIZ-3708: ---------------------------------------------- Hi Adam I partially agree about the 2 first items, I suppose it could be resolved, but I don't how difficult it could be and how each browser will behave. The solution could be easy or a nightmare, but surely it will make css styles more complex and not easier. Anyway, If we agree that those fields must be valid to be included inside a inline element, then patch attached is the minimal one. 1.- DIV changed to SPAN 2.- Removed UL and LI because UL is a block element and LI must be inside a list. (As Adrian says in his comment) 3.- CSS styles corrected to match the changes. (display changed from block to inline-block and alignment changed to maintain the vertical position) Is this OK for you ? > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858258#action_12858258 ] Adam Heath commented on OFBIZ-3708: ----------------------------------- Yes. I'm a happy little butterfly, flapping my wings, causing eddies in the air, which ripple upward, affecting incoming cosmic rays, that deflect to your hard-drive, causing your code to magically be to my liking. > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Issue Comment Edited: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858257#action_12858257 ] Blas Rodriguez Somoza edited comment on OFBIZ-3708 at 4/17/10 10:30 PM: ------------------------------------------------------------------------ Hi Adam I partially agree about the 2 first items, I suppose it could be resolved, but I don't how difficult it could be and how each browser will behave. The solution could be easy or a nightmare, but surely it will make css styles more complex and not easier. Anyway, If we agree that those fields must be valid to be included inside a inline element, then patch attached is the minimal one. In html FormMacroLibrary (macros renderDateTimeField, renderRadioField, renderDateFindField and renderLookupField) - DIV changed to SPAN - Removed UL and LI because UL is a block element and LI must be inside a list. (As Adrian says in his comment) In themes CSS files - Styles corrected to match the changes. (display changed from block to inline-block and alignment changed to maintain the vertical position) Is this OK for you ? was (Author: brsomoza): Hi Adam I partially agree about the 2 first items, I suppose it could be resolved, but I don't how difficult it could be and how each browser will behave. The solution could be easy or a nightmare, but surely it will make css styles more complex and not easier. Anyway, If we agree that those fields must be valid to be included inside a inline element, then patch attached is the minimal one. 1.- DIV changed to SPAN 2.- Removed UL and LI because UL is a block element and LI must be inside a list. (As Adrian says in his comment) 3.- CSS styles corrected to match the changes. (display changed from block to inline-block and alignment changed to maintain the vertical position) Is this OK for you ? > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Issue Comment Edited: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858257#action_12858257 ] Blas Rodriguez Somoza edited comment on OFBIZ-3708 at 4/17/10 10:31 PM: ------------------------------------------------------------------------ Hi Adam I partially agree about the 2 first items, I suppose it could be resolved, but I don't how difficult it could be and how each browser will behave. The solution could be easy or a nightmare, but surely it will make css styles more complex and not easier. Anyway, If we agree that those fields must be valid to be included inside a inline element, then the patch attached is the minimal one. In html FormMacroLibrary (macros renderDateTimeField, renderRadioField, renderDateFindField and renderLookupField) - DIV changed to SPAN - Removed UL and LI because UL is a block element and LI must be inside a list. (As Adrian say in his comment) In themes CSS files - Styles corrected to match the changes. (display changed from block to inline-block and alignment changed to maintain the vertical position) Is this OK for you ? was (Author: brsomoza): Hi Adam I partially agree about the 2 first items, I suppose it could be resolved, but I don't how difficult it could be and how each browser will behave. The solution could be easy or a nightmare, but surely it will make css styles more complex and not easier. Anyway, If we agree that those fields must be valid to be included inside a inline element, then patch attached is the minimal one. In html FormMacroLibrary (macros renderDateTimeField, renderRadioField, renderDateFindField and renderLookupField) - DIV changed to SPAN - Removed UL and LI because UL is a block element and LI must be inside a list. (As Adrian says in his comment) In themes CSS files - Styles corrected to match the changes. (display changed from block to inline-block and alignment changed to maintain the vertical position) Is this OK for you ? > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
Re: [jira] Commented: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
Adam Heath (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858258#action_12858258 ] > > Adam Heath commented on OFBIZ-3708: > ----------------------------------- > > Yes. I'm a happy little butterfly, flapping my wings, causing eddies in the air, which ripple upward, affecting incoming cosmic rays, that deflect to your hard-drive, causing your code to magically be to my liking. http://xkcd.com/378/ |
[jira] Closed: (OFBIZ-3708) Fields should be defined with span not div. (radio, date, lookup)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-3708. ------------------------------ Assignee: Bruno Busco Resolution: Fixed Thank you Blas, thank you Adam and Adrian for reviews. Blas, your patch is in trunk at revision: 935312 > Fields should be defined with span not div. (radio, date, lookup) > ----------------------------------------------------------------- > > Key: OFBIZ-3708 > URL: https://issues.apache.org/jira/browse/OFBIZ-3708 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Reporter: Blas Rodriguez Somoza > Assignee: Bruno Busco > Priority: Minor > Fix For: SVN trunk > > Attachments: CAL_bizznesstime_after.jpg, CAL_bizznesstime_before.jpg, CAL_bluelight_after.jpg, CAL_bluelight_before.jpg, CAL_droppingcrumbs_after.jpg, CAL_droppingcrumbs_before.jpg, CAL_flatgrey_after.jpg, CAL_flatgrey_before.jpg, CAL_tomahawk_after.jpg, CAL_tomahawk_before.jpg, LOOKUP_CAL_bizznesstime_after.jpg, LOOKUP_CAL_bizznesstime_before.jpg, LOOKUP_CAL_bluelight_after.jpg, LOOKUP_CAL_bluelight_before.jpg, LOOKUP_CAL_droppingcrumbs_after.jpg, LOOKUP_CAL_droppingcrumbs_before.jpg, LOOKUP_CAL_flatgrey_after.jpg, LOOKUP_CAL_flatgrey_before.jpg, LOOKUP_CAL_tomahawk_after.jpg, LOOKUP_CAL_tomahawk_before.jpg, OFBIZ-3708_framework_divspan.diff > > > Field markup should be a valid inline element. > Defining fields with div (block) instead of span (inline) creates several problems: > - Missalignments in screen. (See LOOKUP_CAL screenshots) > - Implies a end-of-line after the div. (See CAL screenshots) > - If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log) > Because this is a markup problem, it spans to all the themes. > This patch contains 2 files in the framework/widget area and 5 in the themes area. > Because the source of the problem is in the framework/widget area, I opt to assign the bug to the framework area. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |