[jira] Created: (OFBIZ-3801) Set webside Id in context filter

[Nicolas Malin (Jira)]

Set webside Id in context filter
--------------------------------

                 Key: OFBIZ-3801
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Sascha Rodekamp
            Priority: Minor
             Fix For: SVN trunk


Here is a better way to write the webSiteId in the Session.

Cheers
Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3801:
-----------------------------------

    Attachment: OFBIZ-3801_ContextFilter.java.patch

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3801.
----------------------------------

      Assignee: Jacques Le Roux
    Resolution: Fixed

Thanks Sascha,

Your patch is in trunk at 951119  

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879285#action_12879285 ]

Jacques Le Roux commented on OFBIZ-3801:
----------------------------------------

I think I will have to revert because of the issue "V.S" found (see user ML). I have no time right now too look at it closely, maybe it can be rather solved another way upstream (ie in WebSiteWorker)

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-3801:
------------------------------------

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879286#action_12879286 ]

Jacques Le Roux commented on OFBIZ-3801:
----------------------------------------

Here is the thread http://markmail.org/message/psxv4ankkeloux2s

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3801:
-----------------------------------

    Attachment: OFBIZ-3801_ContextFilter.java.patch

Hm i think i have a patch for this issue. The servelet Context should be called before the webSite Id is set not after.

Have a nice day
Sascha

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch, OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879732#action_12879732 ]

Jacques Le Roux commented on OFBIZ-3801:
----------------------------------------

Hi Sascha,

Valentin tried and he said it does not work (see user ML)

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch, OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879737#action_12879737 ]

Sascha Rodekamp commented on OFBIZ-3801:
----------------------------------------

Ok Jacques i see the problem i'm still working on a solution....

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch, OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3801:
-----------------------------------

    Attachment: OFBIZ-3801_ContextFilter.java.patch

Hey,
here is a patch that should solve the problem. :-)

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch, OFBIZ-3801_ContextFilter.java.patch, OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3801.
----------------------------------

    Resolution: Fixed

Thanks Sascha,

Your patch is in trunk at r955631  

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch, OFBIZ-3801_ContextFilter.java.patch, OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880094#action_12880094 ]

Jacques Le Roux commented on OFBIZ-3801:
----------------------------------------

Hi Sascha,

As it was not a big deal I forgot to ask you why you put this test? Scott just asked on dev ML, thanks

> Set webside Id in context filter
> --------------------------------
>
>                 Key: OFBIZ-3801
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3801
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3801_ContextFilter.java.patch, OFBIZ-3801_ContextFilter.java.patch, OFBIZ-3801_ContextFilter.java.patch
>
>
> Here is a better way to write the webSiteId in the Session.
> Cheers
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.