[jira] Created: (OFBIZ-3841) jQuery Lookup Layer Transformation
Locked
12
12
[jira] Closed: (OFBIZ-3841) jQuery Lookup Layer Transformation
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3841. ---------------------------------- Resolution: Fixed Thanks Sascha, Your patch is committed at r987057. It's weird though that the default value was passed from elsewhere in the trunk and overrided this one, and it's not working here, any ideas why? > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3841) jQuery Lookup Layer Transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900597#action_12900597 ] Sascha Rodekamp commented on OFBIZ-3841: ---------------------------------------- Not really Jacques, it's also weird why a default size of 20px is set in this macro. I can't find any lookups which have a benefit from a width and height with 20 px. > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3841) jQuery Lookup Layer Transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900636#action_12900636 ] Jacques Le Roux commented on OFBIZ-3841: ---------------------------------------- Hi Sascha, Yes, anyway I believe we can forget it ;) It has been added by Bilgin this way (see http://fisheye6.atlassian.com/changelog/ofbiz?cs=930660) but we clearly don't need it in jQuery branch... BTW I thought that we will definitively throw Dojo away (I was upset by how they handled their Tree compatibility) but I wonder about Prototype. Because with its OO approach it allows to build/extends new things in a way that JQuery does not. And maybe at some point this could be useful. The only cost is to keep compatilitiy with jQuery() instead of $()... > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3841) jQuery Lookup Layer Transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900782#action_12900782 ] Sascha Rodekamp commented on OFBIZ-3841: ---------------------------------------- Hi Jacques, hm i don't know if i can agree with you. Our goal was to have only one JS Libary in the framework and when we know starting to think about keeping Prototype we are exactly at the same point where we started, aren't we? Furthermore jQuery support also OO programming and extending other stuff (look at all the plugins or the code from the lookups is slightly OO). If you need the common OO programming shortcuts we can use a jQuery plugin which gives us these shortcuts. But the jQuery core can do OO as well as prototype. It just looks a little bit different... So from my point of view we should remove both dojo and prototype :-) Have a good evening Sascha > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3841) jQuery Lookup Layer Transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900821#action_12900821 ] Jacques Le Roux commented on OFBIZ-3841: ---------------------------------------- Thanks for your comment Sascha, Yes it's maybe wiser to keep only jQuery, it was more a question. And actually nobody expressed any concerns about keeping only jQuery... > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3841) jQuery Lookup Layer Transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900993#action_12900993 ] Sascha Rodekamp commented on OFBIZ-3841: ---------------------------------------- Jep and when we need an Tutorial about OO in jQuery i can maybe write a few lines. > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Reopened: (OFBIZ-3841) jQuery Lookup Layer Transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-3841: ------------------------------------ Hi Sascha, Not sure if you did it intentionnaly but lookups are any longer at top left but centered... This is close to the 20px issue. At large it looks like if the default parameters defined in the XSD are not passed down... Coud you please have a look? Thanks > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-3841) jQuery Lookup Layer Transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3841: ----------------------------------- Attachment: OFBIZ-3841_LookupPositionFix.patch Hey Jacques, no problem, here the patch for fixing the positioning issue. Default: topleft! Cheers Sascha > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, OFBIZ-3841_LookupPositionFix.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3841) jQuery Lookup Layer Transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901061#action_12901061 ] Jacques Le Roux commented on OFBIZ-3841: ---------------------------------------- Sascha, For the tutorial (if ever ;o) I guess these links would be helpful, there are simple, general, though complete enough http://en.wikipedia.org/wiki/Prototype-based_programming http://en.wikipedia.org/wiki/JavaScript > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, OFBIZ-3841_LookupPositionFix.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-3841) jQuery Lookup Layer Transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3841. ---------------------------------- Resolution: Fixed Sascha, Your patch is committed at r987804 . > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, OFBIZ-3841_LookupPositionFix.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-3841) jQuery Lookup Layer Transformation
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901068#action_12901068 ] Sascha Rodekamp commented on OFBIZ-3841: ---------------------------------------- Hey Jacques, thanks for the comitt. jep the articel about the prototype based programming is nice to read. I hope i'll find time to write a few lines. Cross youre fingers :-) Have a good evening Cheers Sascha > jQuery Lookup Layer Transformation > ---------------------------------- > > Key: OFBIZ-3841 > URL: https://issues.apache.org/jira/browse/OFBIZ-3841 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS > Affects Versions: jQuery > Reporter: Sascha Rodekamp > Assignee: Jacques Le Roux > Fix For: jQuery > > Attachments: fieldlookup.js.rej, OFBIZ-3841_jQueryLookupTransform.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix.patch, OFBIZ-3841_LookupFix_SizeProblem.patch, OFBIZ-3841_LookupPositionFix.patch, screenshot-1.jpg > > > Hey, > here is my next patch for the layer Transformationen. It's not totally done yet, but i hope some have the time to do some tests. > * i only changed the Tomahawk CSS (there are some Layout issues). > * i did not really clean the Code :-) (because the patch is for first testing purposes) > * there is a calendar issue in recursive lookup calling ... the icon disapears > * the basic functionality works :-) > * tested in FF, IE8, IE7 > * i did not touch ftl's where the lookup is called directly > * there is a quiete bad workaround when calling the modifySubmitButton Function after loading the Content. > I use a timeout to wait until the content is totally loaded .ready() didn't work for me. Maybe someone have > a better idea. > Have a good day and i'm looking fowoard to your comments and tests ;) > Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |