[jira] Created: (OFBIZ-3854) Separate AddPartyRole form to main and second role

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-3854) Separate AddPartyRole form to main and second role

Nicolas Malin (Jira)
Separate AddPartyRole form to main and second role
--------------------------------------------------

                 Key: OFBIZ-3854
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3854
             Project: OFBiz
          Issue Type: Improvement
    Affects Versions: SVN trunk
            Reporter: Nicolas Malin
            Priority: Minor
             Fix For: SVN trunk
         Attachments: simpleRoleAddingForm.patch

Currently add a role to a party isn't esaier because the addPartyRole form show all recond that contains RoleType entity and this list is ordered for english people but for language it's not the case. Conclusion,  it's really friendly killer for end user.

To solve the problem, I can find a solution to reorder the list after uiLabel resolution but I propose in first time to separate the list in to category : main role and second role.

When a user want to add a role, he select a main role and add or select a main role then select a second role that depend to main to add it.

For other case, the generic form is always available :)

I'm available also for any suggest ;)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3854) Separate AddPartyRole form to main and second role

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3854:
---------------------------------

    Attachment: simpleRoleAddingForm.patch

> Separate AddPartyRole form to main and second role
> --------------------------------------------------
>
>                 Key: OFBIZ-3854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3854
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: simpleRoleAddingForm.patch
>
>
> Currently add a role to a party isn't esaier because the addPartyRole form show all recond that contains RoleType entity and this list is ordered for english people but for language it's not the case. Conclusion,  it's really friendly killer for end user.
> To solve the problem, I can find a solution to reorder the list after uiLabel resolution but I propose in first time to separate the list in to category : main role and second role.
> When a user want to add a role, he select a main role and add or select a main role then select a second role that depend to main to add it.
> For other case, the generic form is always available :)
> I'm available also for any suggest ;)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3854) Separate AddPartyRole form to main and second role

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3854:
--------------------------------------

    Assignee: Erwan de FERRIERES

> Separate AddPartyRole form to main and second role
> --------------------------------------------------
>
>                 Key: OFBIZ-3854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3854
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: simpleRoleAddingForm.patch
>
>
> Currently add a role to a party isn't esaier because the addPartyRole form show all recond that contains RoleType entity and this list is ordered for english people but for language it's not the case. Conclusion,  it's really friendly killer for end user.
> To solve the problem, I can find a solution to reorder the list after uiLabel resolution but I propose in first time to separate the list in to category : main role and second role.
> When a user want to add a role, he select a main role and add or select a main role then select a second role that depend to main to add it.
> For other case, the generic form is always available :)
> I'm available also for any suggest ;)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3854) Separate AddPartyRole form to main and second role

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900728#action_12900728 ]

Erwan de FERRIERES commented on OFBIZ-3854:
-------------------------------------------

Hi Nicolas,
I tested your patch. Although it's working well, there is just a value returned which is displayed in the first drop-down. I'm waiting for your correction to commit your patch to the trunk.
Regards

> Separate AddPartyRole form to main and second role
> --------------------------------------------------
>
>                 Key: OFBIZ-3854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3854
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: simpleRoleAddingForm.patch
>
>
> Currently add a role to a party isn't esaier because the addPartyRole form show all recond that contains RoleType entity and this list is ordered for english people but for language it's not the case. Conclusion,  it's really friendly killer for end user.
> To solve the problem, I can find a solution to reorder the list after uiLabel resolution but I propose in first time to separate the list in to category : main role and second role.
> When a user want to add a role, he select a main role and add or select a main role then select a second role that depend to main to add it.
> For other case, the generic form is always available :)
> I'm available also for any suggest ;)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-3854) Separate AddPartyRole form to main and second role

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3854:
---------------------------------

    Attachment: simpleRoleAddingForm-v2.patch

Ok Erwan, I review it, you can test with version 2

> Separate AddPartyRole form to main and second role
> --------------------------------------------------
>
>                 Key: OFBIZ-3854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3854
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: simpleRoleAddingForm-v2.patch, simpleRoleAddingForm.patch
>
>
> Currently add a role to a party isn't esaier because the addPartyRole form show all recond that contains RoleType entity and this list is ordered for english people but for language it's not the case. Conclusion,  it's really friendly killer for end user.
> To solve the problem, I can find a solution to reorder the list after uiLabel resolution but I propose in first time to separate the list in to category : main role and second role.
> When a user want to add a role, he select a main role and add or select a main role then select a second role that depend to main to add it.
> For other case, the generic form is always available :)
> I'm available also for any suggest ;)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-3854) Separate AddPartyRole form to main and second role

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES closed OFBIZ-3854.
-------------------------------------

    Resolution: Fixed

> Separate AddPartyRole form to main and second role
> --------------------------------------------------
>
>                 Key: OFBIZ-3854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3854
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: simpleRoleAddingForm-v2.patch, simpleRoleAddingForm.patch
>
>
> Currently add a role to a party isn't esaier because the addPartyRole form show all recond that contains RoleType entity and this list is ordered for english people but for language it's not the case. Conclusion,  it's really friendly killer for end user.
> To solve the problem, I can find a solution to reorder the list after uiLabel resolution but I propose in first time to separate the list in to category : main role and second role.
> When a user want to add a role, he select a main role and add or select a main role then select a second role that depend to main to add it.
> For other case, the generic form is always available :)
> I'm available also for any suggest ;)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-3854) Separate AddPartyRole form to main and second role

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906820#action_12906820 ]

Erwan de FERRIERES commented on OFBIZ-3854:
-------------------------------------------

Done at r993381. Thanks Nicolas.
BTW, I put uilabels in the forms' titles as you forget them.

> Separate AddPartyRole form to main and second role
> --------------------------------------------------
>
>                 Key: OFBIZ-3854
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3854
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: simpleRoleAddingForm-v2.patch, simpleRoleAddingForm.patch
>
>
> Currently add a role to a party isn't esaier because the addPartyRole form show all recond that contains RoleType entity and this list is ordered for english people but for language it's not the case. Conclusion,  it's really friendly killer for end user.
> To solve the problem, I can find a solution to reorder the list after uiLabel resolution but I propose in first time to separate the list in to category : main role and second role.
> When a user want to add a role, he select a main role and add or select a main role then select a second role that depend to main to add it.
> For other case, the generic form is always available :)
> I'm available also for any suggest ;)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.