[jira] Created: (OFBIZ-3907) Product Promo Worker description patch

[Nicolas Malin (Jira)]

Product Promo Worker description patch
--------------------------------------

                 Key: OFBIZ-3907
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3907
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Sascha Rodekamp
            Priority: Minor
             Fix For: SVN trunk
         Attachments: OFBIZ-3907ProductPromoWorker.java.patch

This patch extend the order adjustment creation. If an order adjustment is created from a product promo the promo text will stores in the order adjustment description. This helps identifying the order adjustment and later on the invoice item type : ITM_PROMOTION_ADJ.

So long
Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3907:
-----------------------------------

    Attachment: OFBIZ-3907ProductPromoWorker.java.patch

> Product Promo Worker description patch
> --------------------------------------
>
>                 Key: OFBIZ-3907
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3907
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3907ProductPromoWorker.java.patch
>
>
> This patch extend the order adjustment creation. If an order adjustment is created from a product promo the promo text will stores in the order adjustment description. This helps identifying the order adjustment and later on the invoice item type : ITM_PROMOTION_ADJ.
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903802#action_12903802 ]

Scott Gray commented on OFBIZ-3907:
-----------------------------------

Hi Sascha,

You've written the exact same 13 lines of code in two places, instead please consider supplying a new patch with a separate method: something like getProductPromoDescription() which is called from the two other methods to retrieve the adjustment description.

Thanks
Scott

> Product Promo Worker description patch
> --------------------------------------
>
>                 Key: OFBIZ-3907
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3907
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3907ProductPromoWorker.java.patch
>
>
> This patch extend the order adjustment creation. If an order adjustment is created from a product promo the promo text will stores in the order adjustment description. This helps identifying the order adjustment and later on the invoice item type : ITM_PROMOTION_ADJ.
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3907:
-----------------------------------

    Attachment: OFBIZ-3907ProductPromoWorker.java.patch

Hi Scott,
yes that was necessary, here is the refactored code.

Thanks
Sascha

> Product Promo Worker description patch
> --------------------------------------
>
>                 Key: OFBIZ-3907
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3907
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3907ProductPromoWorker.java.patch, OFBIZ-3907ProductPromoWorker.java.patch
>
>
> This patch extend the order adjustment creation. If an order adjustment is created from a product promo the promo text will stores in the order adjustment description. This helps identifying the order adjustment and later on the invoice item type : ITM_PROMOTION_ADJ.
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921990#action_12921990 ]

Sascha Rodekamp commented on OFBIZ-3907:
----------------------------------------

Anything new here?

> Product Promo Worker description patch
> --------------------------------------
>
>                 Key: OFBIZ-3907
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3907
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3907ProductPromoWorker.java.patch, OFBIZ-3907ProductPromoWorker.java.patch
>
>
> This patch extend the order adjustment creation. If an order adjustment is created from a product promo the promo text will stores in the order adjustment description. This helps identifying the order adjustment and later on the invoice item type : ITM_PROMOTION_ADJ.
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3907.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Sascha,

Your patch is in trunk at r1024177  

> Product Promo Worker description patch
> --------------------------------------
>
>                 Key: OFBIZ-3907
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3907
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3907ProductPromoWorker.java.patch, OFBIZ-3907ProductPromoWorker.java.patch
>
>
> This patch extend the order adjustment creation. If an order adjustment is created from a product promo the promo text will stores in the order adjustment description. This helps identifying the order adjustment and later on the invoice item type : ITM_PROMOTION_ADJ.
> So long
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.