[jira] Created: (OFBIZ-3995) Updating Email Address say Contact Mechanism Successfully Updated

[Nicolas Malin (Jira)]

Updating Email Address say Contact Mechanism Successfully Updated
-----------------------------------------------------------------

                 Key: OFBIZ-3995
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3995
             Project: OFBiz
          Issue Type: Bug
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Sascha Rodekamp
            Priority: Minor
             Fix For: SVN trunk


Hm, i had a little bit trouble when i tried to update my address data (shop). The result message was Contact Mechanism Successfully Updated. The service (updateContactMech) tries to differ between email, phone, web ... address changes.

But the conditions are always false , because he can't read the from the parameter fields. This patch  make the service read the parameters in the right way.

Have a good day
Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3995:
-----------------------------------

    Attachment: OFBIZ-3995_ContactMechServices.patch

> Updating Email Address say Contact Mechanism Successfully Updated
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3995
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3995
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3995_ContactMechServices.patch
>
>
> Hm, i had a little bit trouble when i tried to update my address data (shop). The result message was Contact Mechanism Successfully Updated. The service (updateContactMech) tries to differ between email, phone, web ... address changes.
> But the conditions are always false , because he can't read the from the parameter fields. This patch  make the service read the parameters in the right way.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-3995.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Sascha,

I was surprised by this one as it's there ["from the beginning" (at least since OFBiz is A TLP at the ASF)|https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/party/script/org/ofbiz/party/contact/ContactMechServices.xml?r=490457#l37]. A bit dissapointed too, not that you found it now, that's great, but that nobody reported it before... But finally it seems only used inside ContactMechServices.xml. And I guess most people use rather updatePartyContactMech, updateFacilityContactMech or even updateOrderContactMech and that is certainly not used much outside ContactMechServices.xml.

Anyway your patch is in trunk at r1023842  

Thanks

> Updating Email Address say Contact Mechanism Successfully Updated
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3995
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3995
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3995_ContactMechServices.patch
>
>
> Hm, i had a little bit trouble when i tried to update my address data (shop). The result message was Contact Mechanism Successfully Updated. The service (updateContactMech) tries to differ between email, phone, web ... address changes.
> But the conditions are always false , because he can't read the from the parameter fields. This patch  make the service read the parameters in the right way.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922119#action_12922119 ]

Jacques Le Roux commented on OFBIZ-3995:
----------------------------------------

Sorry Sascha,

[We have a test issue|http://ci.apache.org/builders/ofbiz-trunk/builds/661/steps/compile_1/logs/stdio] (look for "--> partyContactMech-tests.testUpdatePartyTelecomNumber"). I guess the test is false, could you please check it?

Thanks

> Updating Email Address say Contact Mechanism Successfully Updated
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3995
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3995
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3995_ContactMechServices.patch
>
>
> Hm, i had a little bit trouble when i tried to update my address data (shop). The result message was Contact Mechanism Successfully Updated. The service (updateContactMech) tries to differ between email, phone, web ... address changes.
> But the conditions are always false , because he can't read the from the parameter fields. This patch  make the service read the parameters in the right way.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922485#action_12922485 ]

Sascha Rodekamp commented on OFBIZ-3995:
----------------------------------------

ok Jacques, found the issue will provide a patch soon ...

Cheers

> Updating Email Address say Contact Mechanism Successfully Updated
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3995
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3995
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3995_ContactMechServices.patch
>
>
> Hm, i had a little bit trouble when i tried to update my address data (shop). The result message was Contact Mechanism Successfully Updated. The service (updateContactMech) tries to differ between email, phone, web ... address changes.
> But the conditions are always false , because he can't read the from the parameter fields. This patch  make the service read the parameters in the right way.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-3995:
-----------------------------------

    Attachment: OFBIZ-3995_ContactMechServices_JunitTestsFix.patch

Hi Jacques,

i think the problem was, that updateContactMech method is canceled, when you try to update an postalAddress or TelecomNumber. The Method suggest to use the updatePostalAddress and/ or updateTelecomNumber service (which is right indeed) , but these services call the updateContactMech and here we stuck.

updateTelecomNumber --> calls updateContactMech --> updateContctMech notice that you want to update a telecom number and retunred an error and cancel the service.
I changed the error to an warning, so everyone who calls the update contact mech directly will remind that he should use the updateTelecomNumber instead.

Or is there another special reason why the updateContactMech method abort and return an error?!

Have a good day
Sascha

> Updating Email Address say Contact Mechanism Successfully Updated
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3995
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3995
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3995_ContactMechServices.patch, OFBIZ-3995_ContactMechServices_JunitTestsFix.patch
>
>
> Hm, i had a little bit trouble when i tried to update my address data (shop). The result message was Contact Mechanism Successfully Updated. The service (updateContactMech) tries to differ between email, phone, web ... address changes.
> But the conditions are always false , because he can't read the from the parameter fields. This patch  make the service read the parameters in the right way.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923350#action_12923350 ]

Sascha Rodekamp commented on OFBIZ-3995:
----------------------------------------

Hi Jacques, the patch is obsolete,
David fixed this issue in r1025838 by commending the lines out.

Task closed :)

Have a good day
Sascha

> Updating Email Address say Contact Mechanism Successfully Updated
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3995
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3995
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3995_ContactMechServices.patch, OFBIZ-3995_ContactMechServices_JunitTestsFix.patch
>
>
> Hm, i had a little bit trouble when i tried to update my address data (shop). The result message was Contact Mechanism Successfully Updated. The service (updateContactMech) tries to differ between email, phone, web ... address changes.
> But the conditions are always false , because he can't read the from the parameter fields. This patch  make the service read the parameters in the right way.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923363#action_12923363 ]

Jacques Le Roux commented on OFBIZ-3995:
----------------------------------------

Hi Sascha,

Looks like we did not do a good job here. I must take my part and should have taken testUpdatePartyTelecomNumber more seriously. The 2 1st tests in updateContactMech were wrong but it was our error to not check further after testUpdatePartyTelecomNumber popped up, lesson learned.

I thought about opening an issue about the note David left in r1025838 comment
{quote}
this fixes that bug for now, and if this really should be a constraint the higher level services need to be changed to do something else, ie to not call the updateContactMech/etc services
{quote}
But I think it's really old (wrong) code that have been neglicted until you stumbled upon. We could even remove the whole commented block. But I guess David prefered to keep it in case it would help someone with an old version to understand the change.

> Updating Email Address say Contact Mechanism Successfully Updated
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3995
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3995
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3995_ContactMechServices.patch, OFBIZ-3995_ContactMechServices_JunitTestsFix.patch
>
>
> Hm, i had a little bit trouble when i tried to update my address data (shop). The result message was Contact Mechanism Successfully Updated. The service (updateContactMech) tries to differ between email, phone, web ... address changes.
> But the conditions are always false , because he can't read the from the parameter fields. This patch  make the service read the parameters in the right way.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923366#action_12923366 ]

Sascha Rodekamp commented on OFBIZ-3995:
----------------------------------------

Yes Jacques, i think keeping the comments is better for understanding. That's why i prefered the log messages in my patch
OFBIZ-3995_ContactMechServices_JunitTestsFix.patch. That helps users to notice what happened :-) But comment Blocks are also a good think.

Cheers

> Updating Email Address say Contact Mechanism Successfully Updated
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-3995
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3995
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Sascha Rodekamp
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3995_ContactMechServices.patch, OFBIZ-3995_ContactMechServices_JunitTestsFix.patch
>
>
> Hm, i had a little bit trouble when i tried to update my address data (shop). The result message was Contact Mechanism Successfully Updated. The service (updateContactMech) tries to differ between email, phone, web ... address changes.
> But the conditions are always false , because he can't read the from the parameter fields. This patch  make the service read the parameters in the right way.
> Have a good day
> Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.