[jira] Created: (OFBIZ-4051) i18n for elrte editor

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-4051:
------------------------------------


I reopen in order to track the issue Dukian reported...

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elret-zh_TW-modified-result.jpg, elrte_i18n.patch, elrte_i18n.zip, OFBIZ-4051_zh_TW.patch
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970681#action_12970681 ]

dukian commented on OFBIZ-4051:
-------------------------------

Mr. Tad responded it works for him.

It's weird, so I dived into elRTE's code. Please ref. https://github.com/Studio-42/elRTE/commits/stable/src/elrte/js/elRTE.js

commit ba88b196(Sept 18): .lang be converted to lower case in line 30:

    bq. this.lang = (''+this.options.lang).toLowerCase();

commit e341aedf(Sept 15): uses .lang directly in line 45:

    bq. this._i18n = new eli18n({textdomain : 'rte', messages : { rte : this.i18Messages[this.options.lang] || {}} });

Mr. Tad translated zh_TW file be commited Sept 15 (http://elrte.org/redmine/issues/192), but elRTE 1.1 releases Spet 20, so it's sadly for zh_TW users ...

I reported to elRTE project several days ago, they correct this problem and follow ICU rules (http://userguide.icu-project.org/locale). Please ref. http://elrte.org/redmine/issues/311, https://github.com/Studio-42/elRTE/blob/stable/src/elrte/js/elRTE.js . Mr. Nevelin says it'll be fixed in version 1.2.

My suggestion is keep current works, and wait elRTE next version.

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elret-zh_TW-modified-result.jpg, elrte_i18n.patch, elrte_i18n.zip, OFBIZ-4051_zh_TW.patch
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971231#action_12971231 ]

Sascha Rodekamp commented on OFBIZ-4051:
----------------------------------------

Thanks for you're comment and clarification dukian. Think waiting for the next version is a good idea and makes live easier ;)

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elret-zh_TW-modified-result.jpg, elrte_i18n.patch, elrte_i18n.zip, OFBIZ-4051_zh_TW.patch
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971237#action_12971237 ]

Jacques Le Roux commented on OFBIZ-4051:
----------------------------------------

Thanks Dukian and Sascha,

I agree

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elret-zh_TW-modified-result.jpg, elrte_i18n.patch, elrte_i18n.zip, OFBIZ-4051_zh_TW.patch
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-4051:
-----------------------------------

    Attachment: elrteUpdateTo1.2.zip

Hi,
here is the update to the new elRte 1.2 Version. It seems that see zh_TW Bug is fixed, the language is loaded correctly.

@dukian can you please doublecheck?

To apply the patch:
* extract the zip file
* copy the files under the jquery/plugins/elrte folder

Thanks
Sascha

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elret-zh_TW-modified-result.jpg, elrte_i18n.patch, elrte_i18n.zip, elrteUpdateTo1.2.zip, OFBIZ-4051_zh_TW.patch
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988586#action_12988586 ]

Jacques Le Roux commented on OFBIZ-4051:
----------------------------------------

Sascha,

I just tried, I don't see the headers and fonts names in Chinese (tried zh, zh_CN and zh_TW)

Though I see they have changed the 1108 line

from
this.lang      = (''+this.options.lang).toLowerCase();
to
this.lang      = (''+this.options.lang);

Could I have missed something?  BTW, it does not work either in French... (I still see English) No errors in OFBiz log nor in js console.

I tried seeing nodes at https://localhost:8443/content/control/WebSiteCms?webSiteId=CmsSite.

What and where did you see it working?

Thanks

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elret-zh_TW-modified-result.jpg, elrte_i18n.patch, elrte_i18n.zip, elrteUpdateTo1.2.zip, OFBIZ-4051_zh_TW.patch
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989069#comment-12989069 ]

Sascha Rodekamp commented on OFBIZ-4051:
----------------------------------------

Hi Jacques, i think the problem with the CMS site is, that the Editor is called directly from the FTL.

I only checked the call from from a form like here:
https://demo-trunk.ofbiz.apache.org/content/control/EditBlogArticle?articleContentId=BLG10000&blogContentId=BLOGROOTBIGAL

French works for me. Or did i get something wrong?

Cheers
Sascha

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: OFBIZ-4051_zh_TW.patch, elret-zh_TW-modified-result.jpg, elrteUpdateTo1.2.zip, elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989146#comment-12989146 ]

Jacques Le Roux commented on OFBIZ-4051:
----------------------------------------

Hi Sascha,

Yes you are right, so it was already working w/out your changes here (I did not commit anything yet).

I noticed some weird things though.
* If you get to the url you C/pasted directly w/out changing the language it does not work.
* If after changing the language you get to another page and get back again it does not work either
* If you get back from changing language after being at https://demo-trunk.ofbiz.apache.org/content/control/WebSiteCms?webSiteId=CmsSite you get a weird screen (we need to create a new issue for that...)

We will have to see at least what's happenning with FTL 1st, so I don't close...

Thanks!

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: OFBIZ-4051_zh_TW.patch, elret-zh_TW-modified-result.jpg, elrteUpdateTo1.2.zip, elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4051.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 11.04
         Assignee: Jacques Le Roux  (was: Erwan de FERRIERES)

Fixed at
trunk r1178175  
R11.04 r1178181  


               

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 11.04, SVN trunk, jQuery
>
>         Attachments: OFBIZ-4051_zh_TW.patch, elret-zh_TW-modified-result.jpg, elrteUpdateTo1.2.zip, elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira