OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

28 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

Bug In Jquery Integration - js File Not Found
---------------------------------------------

Key: OFBIZ-4060
URL: https://issues.apache.org/jira/browse/OFBIZ-4060
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Priority: Minor

I'm getting this error in the log:

2010-12-15 09:58:38,203 (http-0.0.0.0-8443-2) [ComponentLocationResolver.java:43 :WARN ] Unable to get file URL for component location; expanded location was [C:/ofbiz/framework/images/webapp/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-en-US.js], original location was [component://images/webapp/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-en-US.js]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4060:
-----------------------------------

Issue Type: Sub-task (was: Bug)
Parent: OFBIZ-3814

> Bug In Jquery Integration - js File Not Found
> ---------------------------------------------
>
> Key: OFBIZ-4060
> URL: https://issues.apache.org/jira/browse/OFBIZ-4060
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Priority: Minor
>
> I'm getting this error in the log:
> 2010-12-15 09:58:38,203 (http-0.0.0.0-8443-2) [ComponentLocationResolver.java:43 :WARN ] Unable to get file URL for component location; expanded location was [C:/ofbiz/framework/images/webapp/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-en-US.js], original location was [component://images/webapp/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-en-US.js]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971770#action_12971770 ]

Jacques Le Roux commented on OFBIZ-4060:
----------------------------------------

It should be normally handled by this snippet in framework/common/widget/CommonScreens.xml, maybe there is a flaw, though I seriously tested it. Have you a specific URL?

{code}
<set field="initialLocaleComplete" type="String" value="${groovy:parameters?.userLogin?.lastLocale}" default-value="${groovy:locale.toString()}"/>
<set field="initialLocale" type="String" value="${groovy:parameters?.userLogin?.lastLocale?.substring(0,2)}" default-value="${groovy:locale.toString()?.substring(0,2)?:'en'}"/>
<set field="localeFileNameComplete" type="String" value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocaleComplete}.js"/>
<set field="localeFileNameComplete" type="String" value="${groovy: localeFileNameComplete.replace('_', '-')}"/> 
<set field="fileNameComplete" type="String" value="${groovy: org.ofbiz.base.location.FlexibleLocation.resolveLocation('component://images/webapp' + localeFileNameComplete)}"/>
<set field="localeFileName" type="String" value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js"/>
<set field="localeJsFile" type="String" value="${groovy: fileNameComplete ? localeFileNameComplete : localeFileName}"/>
<set field="layoutSettings.javaScripts[+0]" value="${localeJsFile}" global="true"/>
{code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972045#action_12972045 ]

Jacques Le Roux commented on OFBIZ-4060:
----------------------------------------

Hi Adrian,

Actually, with my algorithm above, if I don't find a file for the language.country couple I expect a file for the language to exist. By default there is no jquery.ui.datepicker-en-US.js file. But, weirdly (it seems), there is also no jquery.ui.datepicker-en.js, only jquery.ui.datepicker-en-GB.js. The reason is there is no jquery.ui.datepicker-en.js file is because it's the default coded in the script and used as last ressource.

Before closing, we have 2 alternatives here:
* Create an appropriate jquery.ui.datepicker-en-US.js and even a copy as jquery.ui.datepicker-en.js (should it be a copy of jquery.ui.datepicker-en-GB.js or jquery.ui.datepicker-en-US.js? As I'm French I let you the choice, though it's en-US in the script :) ). I let you handle that as I'm sure you will do better than me (I guess only the dateFormat is concerned).
* Forget it as anyway en-US is the default used (jquery.ui.datepicker.js[54]). It will still show the warning. We could then rather add a warning explaining message for this peculiar case...

Your choice?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972068#action_12972068 ]

Sascha Rodekamp commented on OFBIZ-4060:
----------------------------------------

Third:
* Write a method which checks if the file exists. If true load the file, if false load nothing.

But i prefer the first option. That have the disadvantage that we have more overhead to update the files, but we are in line with the system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972074#action_12972074 ]

Jacques Le Roux commented on OFBIZ-4060:
----------------------------------------

Yes Sascha,

That what I wrote initially. But then for optimisation I removed the exist file check stuff. I did not thought about this issues though...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972074#action_12972074 ]

Jacques Le Roux edited comment on OFBIZ-4060 at 12/16/10 8:22 AM:
------------------------------------------------------------------

Yes Sascha,

That what I wrote initially. But then for optimisation I removed the exist file check stuff. I did not thought about this issue...

was (Author: jacques.le.roux):
Yes Sascha,

That what I wrote initially. But then for optimisation I removed the exist file check stuff. I did not thought about this issues though...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972081#action_12972081 ]

Adrian Crum commented on OFBIZ-4060:
------------------------------------

I like the idea of checking to see if the file exists before using it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Sascha Rodekamp-3

Re: [jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

Ok Adrian, Jacques,
i will handle this.
Cheers
Sascha

2010/12/16 Adrian Crum (JIRA) <[hidden email]>

>
> [
> https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972081#action_12972081]
>
> Adrian Crum commented on OFBIZ-4060:
> ------------------------------------
>
> I like the idea of checking to see if the file exists before using it.
>
> > Bug In Jquery Integration - js File Not Found
> > ---------------------------------------------
> >
> > Key: OFBIZ-4060
> > URL: https://issues.apache.org/jira/browse/OFBIZ-4060
> > Project: OFBiz
> > Issue Type: Sub-task
> > Components: framework
> > Affects Versions: SVN trunk
> > Reporter: Adrian Crum
> > Priority: Minor
> >
> > I'm getting this error in the log:
> > 2010-12-15 09:58:38,203 (http-0.0.0.0-8443-2)
> [ComponentLocationResolver.java:43 :WARN ] Unable to get file URL for
> component location; expanded location was
> [C:/ofbiz/framework/images/webapp/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-en-US.js],
> original location was
> [component://images/webapp/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-en-US.js]
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

--
Sascha Rodekamp
Lynx-Consulting GmbH
Johanniskirchplatz 6
D-33615 Bielefeld
http://www.lynx.de

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972371#action_12972371 ]

Scott Gray commented on OFBIZ-4060:
-----------------------------------

I have an improvement coming that will help deal with this if you wait a few days

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972373#action_12972373 ]

Sascha Rodekamp commented on OFBIZ-4060:
----------------------------------------

Sure Scott thanks for the info.
Have a good day ( hopefully with not so much snow like here in Germany, driving is a pity today )

Cheers Sascha

Sascha Rodekamp
Consultant
Lynx-Consulting GmbH
Johanniskirchplatz 6
33615 Bielefeld
Deutschland
Fon: +49 521 5247-0
Fax: +49 521 5247-250
Mobil: +49 151 140 698 93

Company and Management Headquarters:
Lynx-Consulting GmbH, Johanniskirchplatz 6, 33615 Bielefeld, Deutschland
Fon: +49 521 5247-0, Fax: +49 521 5247-250, www.lynx.de

Court Registration: Amtsgericht Bielefeld HRB 35946
Chief Executive Officers: Karsten Noss, Dirk Osterkamp

----------------------------------------------------------------------------------------------------
This e-mail may contain trade secrets or privileged, undisclosed, or otherwise confidential information. If you have received this e-mail in error, you are hereby notified that any review, copying, or distribution of it is strictly prohibited. Please inform us immediately and destroy the original transmittal. Thank you for your cooperation.
----------------------------------------------------------------------------------------------------

*****************************************************************************

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973841#action_12973841 ]

Jacques Le Roux commented on OFBIZ-4060:
----------------------------------------

Hi Sascha,

Could you please your comment above? (I guess sent from a mobile)

Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973841#action_12973841 ]

Jacques Le Roux edited comment on OFBIZ-4060 at 12/21/10 3:06 PM:
------------------------------------------------------------------

Hi Sascha,

Could you please clear your comment above? (I guess sent from a mobile)

Thanks

was (Author: jacques.le.roux):
Hi Sascha,

Could you please your comment above? (I guess sent from a mobile)

Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974082#action_12974082 ]

Sascha Rodekamp commented on OFBIZ-4060:
----------------------------------------

Ups,
yes i sent it from my mobile. In response of the mailing list entry. I haven't an Edit button for this post, maybe because i didn't use my normal jira login.
Have you the permission to edit my post?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974084#action_12974084 ]

Scott Gray commented on OFBIZ-4060:
-----------------------------------

Hi Sascha,

We'll probably need to go with whatever fix you had in mind, my intended fix was part of the feature described here: http://ofbiz.markmail.org/thread/zhlxhk3zvy6xwoow
but at this stage it probably won't be committed.

Regards
Scott

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974093#action_12974093 ]

Sascha Rodekamp commented on OFBIZ-4060:
----------------------------------------

Hi Scott,
yes i follow the discussion.
Ok than we create a workaround for this issue and replace it when you're (awesome) solution is ready.

Regards
Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974625#action_12974625 ]

Sascha Rodekamp commented on OFBIZ-4060:
----------------------------------------

Hi Jacques, Hi Scott, Hi *,
can we have a default i18n language file? I played a little bit around:
{code}
<set field="existLocaleJSFile" type="Boolean" value="${groovy: org.ofbiz.base.util.FileUtil.checkIfFileExists(localeJsFile)}"/>
<set field="localeJsFile" type="String" value="${groovy: existLocaleJSFile ? localeJsFile : defaultLocaleFile}" />

<set field="layoutSettings.javaScripts[+0]" value="${groovy: existLocaleJSFile ? localeJsFile : defaultLocaleFile}" global="true"/>
{code}

But my problem is, that i have to pass a value to the JS Object, if i pass nothing or an random string i got an exception (works as expected, but don't help us).

If we now extract the default language from the datepicker js file and copy it to a separate file which we load if the file with the user locale doesn't exist , solves our problem.

An alternative is to modify the JS loading directly in the header.ftl
{code}
<#list layoutSettings.javaScripts as javaScript>
<#if javaScriptsSet.contains(javaScript)>
<#assign nothing = javaScriptsSet.remove(javaScript)/>
<#assign existsJSFile = Static["org.ofbiz.base.util.FileUtil"].checkIfFileExists("framework/images/webapp" + StringUtil.wrapString(javaScript))/>
<#if existsJSFile>
<script src="<@ofbizContentUrl>${StringUtil.wrapString(javaScript)}</@ofbizContentUrl>" type="text/javascript"></script>
</#if>
</#if>
</#list>
{code}
That is of course very slow because he have to check the availability for each *.js file.

What do u think?

Cheers Sascha

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974634#action_12974634 ]

Jacques Le Roux commented on OFBIZ-4060:
----------------------------------------

Performance issue, that's why I have tried to avoid File.exists. I suggest to use my second option: a simple warning message: anyway the default is handled internally. It's only this warning message from us which is distracting

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974689#action_12974689 ]

Sascha Rodekamp commented on OFBIZ-4060:
----------------------------------------

Yes maybe the best choice.
Where would you put the warning explaining message?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-4060) Bug In Jquery Integration - js File Not Found

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4060.
----------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Jacques Le Roux

Fixed at r1052492. If you see a better solution please feel free...

> Bug In Jquery Integration - js File Not Found
> ---------------------------------------------
>
> Key: OFBIZ-4060
> URL: https://issues.apache.org/jira/browse/OFBIZ-4060
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Adrian Crum
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
>
> I'm getting this error in the log:
> 2010-12-15 09:58:38,203 (http-0.0.0.0-8443-2) [ComponentLocationResolver.java:43 :WARN ] Unable to get file URL for component location; expanded location was [C:/ofbiz/framework/images/webapp/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-en-US.js], original location was [component://images/webapp/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-en-US.js]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.