OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

33 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

Umbrella task for features which use javascript to degrade gracefully
----------------------------------------------------------------------

Key: OFBIZ-4120
URL: https://issues.apache.org/jira/browse/OFBIZ-4120
Project: OFBiz
Issue Type: Bug
Components: ALL APPLICATIONS
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux

By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4120:
-----------------------------------

Description:
By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript.

The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available

was:By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript

> Umbrella task for features which use javascript to degrade gracefully
> ----------------------------------------------------------------------
>
> Key: OFBIZ-4120
> URL: https://issues.apache.org/jira/browse/OFBIZ-4120
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
>
> By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript.
> The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982622#action_12982622 ]

Jacques Le Roux commented on OFBIZ-4120:
----------------------------------------

So far, the current cases are only the ones found on the Catalog Main page, I'm sure there are more...

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982626#action_12982626 ]

Jacques Le Roux commented on OFBIZ-4120:
----------------------------------------

Mmm, now that I think more about it I think we have a bigger problem here: for security reasons we have heavily introduced use of javascript (see https://issues.apache.org/jira/browse/OFBIZ-2330 and maybe even https://issues.apache.org/jira/browse/OFBIZ-1525) all those cases are not barely usable w/out js but unusable...

So I wonder now if OFBIZ-4120 has even any sense. We rely on js and OFBIZ-2330 is really showing it!

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982627#action_12982627 ]

Hans Bakker commented on OFBIZ-4120:
------------------------------------

what is the reason for supporting browser without javascript?
I really do not see why you want to do that? Any modern browser supports it?

Regards,
Hans

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982628#action_12982628 ]

Jacques Le Roux commented on OFBIZ-4120:
----------------------------------------

I agree, I think we will finally end with your answer. It was an attempt to seriously answer to Adrian: http://markmail.org/message/qv2fay566mfr4zjq

My conclusion is that w/out javascript currently OFBiz backend is screwed. So we should forget to try to make OFBiz running without it, it's too much work. I f you are interested you can (re?)-read the above thread

Thanks

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982630#action_12982630 ]

Jacques Le Roux commented on OFBIZ-4120:
----------------------------------------

My initial idea was to let know users that javascript is required! Adrian was against, but I think there are simply no other reasonnable solutons... And I tried to demonstrate it, I think it's *done*

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982639#action_12982639 ]

Adrian Crum commented on OFBIZ-4120:
------------------------------------

Hans,

Some users prefer to leave JavaScript turned off for security and privacy reasons. Some organizations may require it to be turned off.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982642#action_12982642 ]

Adrian Crum commented on OFBIZ-4120:
------------------------------------

Jacques,

It's great that you've consolidated the JavaScript issues under one task, but I don't think we need to make a special effort to accommodate users who have it turned off. From my perspective, as long as OFBiz detects if it is enabled and provides an indicator in the rendering context, then we've done our job. Like everything else in the project, those users who encounter problems using OFBiz with JavaScript turned off can provide patches to fix them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982644#action_12982644 ]

Jacques Le Roux commented on OFBIZ-4120:
----------------------------------------

Adrian, quoting you

{quote}
From my perspective, as long as OFBiz detects if it is enabled and provides an indicator in the rendering context, then we've done our job.
{quote}

Actually that's what I suggestged in the above thread, quoting myself

{quote}
This is user's problem not OFBiz's, we can't take care of all subtilities. But we should explain this to users. We could add an obivous (colored?) label in the header (javascript enabled). Then they should be aware and it's their responsabilites.
{quote}

I will go for that with the jQuery cookie solution and... voilà...

Also I asked
{quote}
BTW I was surprised that Ryan and you put the access to preferences and languages features in the footer. It's not always visible and seems a bit weird to me
{quote}

Any answers? ;)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Adrian Crum-2

Updated Flat Grey Visual Theme (was: [jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully)

Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content.

-Adrian

--- On Mon, 1/17/11, Jacques Le Roux (JIRA) <[hidden email]> wrote:
> Also I asked
> {quote}
> BTW I was surprised that Ryan and you put the access to
> preferences and languages features in the footer. It's not
> always visible and seems a bit weird to me
> {quote}
>
> Any answers? ;)

Ryan Foster-3

Re: Updated Flat Grey Visual Theme (was: [jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully)

That was exactly what I was trying to do. It seemed even more weird to me to have theme selection and language in the header, but have timezone selection in the footer and to have half of the application links in the header and the other half in the footer. The new grouping is much more logical in my opinion. All of the applications are now grouped together in the header, and all of the user preference selections, which are secondary, are grouped together in the footer.

Ryan L. Foster
801.671.0769
[hidden email]
ryanlfoster.com

On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote:

> Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content.
>
> -Adrian
>
> --- On Mon, 1/17/11, Jacques Le Roux (JIRA) <[hidden email]> wrote:
>> Also I asked
>> {quote}
>> BTW I was surprised that Ryan and you put the access to
>> preferences and languages features in the footer. It's not
>> always visible and seems a bit weird to me
>> {quote}
>>
>> Any answers? ;)
>
>
>
>

Jacques Le Roux

Re: Updated Flat Grey Visual Theme (was: [jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully)

Administrator

Ryan Foster wrote:
> That was exactly what I was trying to do. It seemed even more weird to me to have theme selection and language in the header,
> but have timezone selection in the footer and to have half of the application links in the header and the other half in the
> footer. The new grouping is much more logical in my opinion. All of the applications are now grouped together in the header,
> and all of the user preference selections, which are secondary, are grouped together in the footer.

That was true for the old Flat Grey but what about how it's handled in Tomahawk for instance. Maybe I'm biased though because for
testing purpose I'm always switching languages and themes... BTW the time zone selection is missing in Tomahawk...

Jacques

> Ryan L. Foster
> 801.671.0769
> [hidden email]
> ryanlfoster.com
>
> On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote:
>
>> Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content.
>>
>> -Adrian
>>
>> --- On Mon, 1/17/11, Jacques Le Roux (JIRA) <[hidden email]> wrote:
>>> Also I asked
>>> {quote}
>>> BTW I was surprised that Ryan and you put the access to
>>> preferences and languages features in the footer. It's not
>>> always visible and seems a bit weird to me
>>> {quote}
>>>
>>> Any answers? ;)

Adrian Crum

Re: Updated Flat Grey Visual Theme

Jacques,

If you're asking why JavaScript isn't used to create user preference
drop-down menus, then the answer is in the Design Objectives listed in
the Jira issue.

-Adrian

On 1/17/2011 10:07 AM, Jacques Le Roux wrote:

> Ryan Foster wrote:
>> That was exactly what I was trying to do. It seemed even more weird to
>> me to have theme selection and language in the header,
>> but have timezone selection in the footer and to have half of the
>> application links in the header and the other half in the
>> footer. The new grouping is much more logical in my opinion. All of
>> the applications are now grouped together in the header,
>> and all of the user preference selections, which are secondary, are
>> grouped together in the footer.
>
> That was true for the old Flat Grey but what about how it's handled in
> Tomahawk for instance. Maybe I'm biased though because for testing
> purpose I'm always switching languages and themes... BTW the time zone
> selection is missing in Tomahawk...
>
> Jacques
>
>> Ryan L. Foster
>> 801.671.0769
>> [hidden email]
>> ryanlfoster.com
>>
>> On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote:
>>
>>> Ryan can answer that question. I believe he was trying to keep the
>>> masthead small so there is more room for the main content.
>>>
>>> -Adrian
>>>
>>> --- On Mon, 1/17/11, Jacques Le Roux (JIRA) <[hidden email]> wrote:
>>>> Also I asked
>>>> {quote}
>>>> BTW I was surprised that Ryan and you put the access to
>>>> preferences and languages features in the footer. It's not
>>>> always visible and seems a bit weird to me
>>>> {quote}
>>>>
>>>> Any answers? ;)
>
>
>

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4120:
-----------------------------------

Description: By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier for users than wih javascript. (was: By using more an more javascript we forget sometimes that it may not available and OFBiz features should continue to work even it's not as easier than wih javascript.

The 1st thing I'd like to do is also to not depend on the javascripEnabled=Y parameter passed from the login URL (it's stored in the session) to determine if we use javascrip or not. But to use jQuery cookie plugin to test if we can create a cookie, else we know that javascrip is not available)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982784#action_12982784 ]

Jacques Le Roux commented on OFBIZ-4120:
----------------------------------------

I guess I was a bit wrong in my assumptions, since I missed the script at the end of login.ftl files (do we really need more than one?). But it's still true that collapsing screenlets were working without js in R4.0 so was (and is still in Order Manager and eCommerce, lack of consistency) the categories tree in R10.04 and we should switch on JavaScriptEnabled using the old way rather than nothing. For the Help we should at least have something, but I for all the FTL using javascript for security reasons (no parameters in URL to avoid XSS) I guess we have no solutions, so yes all I did is maybe a waste of time :(

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982786#action_12982786 ]

Jacques Le Roux commented on OFBIZ-4120:
----------------------------------------

Since a lot of actions are not availablke without js enabled, should we not warn the user about it? If we are OK on this I will close all the tasks here since we can't avoid the FTL issues (OFBIZ-2330).

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Jacques Le Roux

Re: Updated Flat Grey Visual Theme

Administrator

In reply to this post by Adrian Crum

No no, only why those information are in the footer when they are in the header for all other themes (also see my comment about time
zone missing)

Jacques

Adrian Crum wrote:

> Jacques,
>
> If you're asking why JavaScript isn't used to create user preference
> drop-down menus, then the answer is in the Design Objectives listed in
> the Jira issue.
>
> -Adrian
>
> On 1/17/2011 10:07 AM, Jacques Le Roux wrote:
>> Ryan Foster wrote:
>>> That was exactly what I was trying to do. It seemed even more weird to
>>> me to have theme selection and language in the header,
>>> but have timezone selection in the footer and to have half of the
>>> application links in the header and the other half in the
>>> footer. The new grouping is much more logical in my opinion. All of
>>> the applications are now grouped together in the header,
>>> and all of the user preference selections, which are secondary, are
>>> grouped together in the footer.
>>
>> That was true for the old Flat Grey but what about how it's handled in
>> Tomahawk for instance. Maybe I'm biased though because for testing
>> purpose I'm always switching languages and themes... BTW the time zone
>> selection is missing in Tomahawk...
>>
>> Jacques
>>
>>> Ryan L. Foster
>>> 801.671.0769
>>> [hidden email]
>>> ryanlfoster.com
>>>
>>> On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote:
>>>
>>>> Ryan can answer that question. I believe he was trying to keep the
>>>> masthead small so there is more room for the main content.
>>>>
>>>> -Adrian
>>>>
>>>> --- On Mon, 1/17/11, Jacques Le Roux (JIRA) <[hidden email]> wrote:
>>>>> Also I asked
>>>>> {quote}
>>>>> BTW I was surprised that Ryan and you put the access to
>>>>> preferences and languages features in the footer. It's not
>>>>> always visible and seems a bit weird to me
>>>>> {quote}
>>>>>
>>>>> Any answers? ;)

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982832#action_12982832 ]

BJ Freeman commented on OFBIZ-4120:
-----------------------------------

guess I am the lonely decenter I had to turn on my browser java script to see what I was missing.
looks like I will have to do more manual appliation of commits from now on.

why do I keep the JS off
a lot of sites are showing up that use js to override pop ups and install applications that are usually viruses or trojans.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Ryan Foster-3

Re: Updated Flat Grey Visual Theme (was: [jira] Commented: (OFBIZ-4120) Umbrella task for features which use javascript to degrade gracefully)

In reply to this post by Jacques Le Roux

I guess it really just comes down to the approach. The objective of the task was to update the Flat Grey theme. So, I approached the design as a realign rather than a redesign. I did not look at any other themes as examples, I simply focused on how Flat Grey looked and functioned and then tried to make the smallest amount of CSS and markup changes possible in order to achieve the objective and stay with the scope of the task.

I understand your bias, because I have it as well, as probably every other active OFBiz developer does. But for the average user, the vast majority are going to select one language, one time zone, and one theme and then never touch this section again. Also, for a developer deploying OFBiz across a large organization, they may even decide to set these preferences globally across the entire organization and not allow the user to have these selections. In that case, it becomes much easier for them because they can simply disable the footer in the theme and it does not affect anything else at all.

Ryan L. Foster
801.671.0769
[hidden email]
ryanlfoster.com

On Jan 17, 2011, at 11:07 AM, Jacques Le Roux wrote:

> Ryan Foster wrote:
>> That was exactly what I was trying to do. It seemed even more weird to me to have theme selection and language in the header,
>> but have timezone selection in the footer and to have half of the application links in the header and the other half in the
>> footer. The new grouping is much more logical in my opinion. All of the applications are now grouped together in the header,
>> and all of the user preference selections, which are secondary, are grouped together in the footer.
>
> That was true for the old Flat Grey but what about how it's handled in Tomahawk for instance. Maybe I'm biased though because for testing purpose I'm always switching languages and themes... BTW the time zone selection is missing in Tomahawk...
>
> Jacques
>
>> Ryan L. Foster
>> 801.671.0769
>> [hidden email]
>> ryanlfoster.com
>>
>> On Jan 17, 2011, at 7:30 AM, Adrian Crum wrote:
>>
>>> Ryan can answer that question. I believe he was trying to keep the masthead small so there is more room for the main content.
>>>
>>> -Adrian
>>>
>>> --- On Mon, 1/17/11, Jacques Le Roux (JIRA) <[hidden email]> wrote:
>>>> Also I asked
>>>> {quote}
>>>> BTW I was surprised that Ryan and you put the access to
>>>> preferences and languages features in the footer. It's not
>>>> always visible and seems a bit weird to me
>>>> {quote}
>>>>
>>>> Any answers? ;)
>
>