[jira] Created: (OFBIZ-4208) Product page meta-tag does not contain i18n content
Locked
[jira] Created: (OFBIZ-4208) Product page meta-tag does not contain i18n content
 
|
Product page meta-tag does not contain i18n content
--------------------------------------------------- Key: OFBIZ-4208 URL: https://issues.apache.org/jira/browse/OFBIZ-4208 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Release 09.04, Release Branch 09.04, Release Branch 10.04, SVN trunk Environment: any Reporter: Carsten Schinzer Priority: Minor Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk the groovy script that produces the content meta information is only partially using i18n information from the Content Wrapper. Namely, it does NOT use the Product or Category ContentWrapper to receive internationalized content for Product Name and Description or Category Description but rather the direct properties of the product entity. Using the ContentWrapper will overcome this shortcoming. The fix needs to be applied in applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy It is assumed that ContentWrappers will handle primitive over related Content properly, ie. if there is no related Content entity but only primitive content, it will return that. And if there is i18n content missing in the desired (current session) locale, it will return the default locale translation. The attached fixes are for the most-used releases and trunk. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-4208) Product page meta-tag does not contain i18n content
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Schinzer updated OFBIZ-4208: ------------------------------------ Attachment: OFBIZ-4208_Product page meta-tag does not contain i18n content-SVNTRUNK.patch OFBIZ-4208_Product page meta-tag does not contain i18n content-R10.04.patch OFBIZ-4208_Product page meta-tag does not contain i18n content-R09.04.patch > Product page meta-tag does not contain i18n content > --------------------------------------------------- > > Key: OFBIZ-4208 > URL: https://issues.apache.org/jira/browse/OFBIZ-4208 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Release Branch 09.04, Release 09.04, Release Branch 10.04, SVN trunk > Environment: any > Reporter: Carsten Schinzer > Priority: Minor > Labels: i18n, meta-tags > Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-4208_Product page meta-tag does not contain i18n content-R09.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-R10.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-SVNTRUNK.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > the groovy script that produces the content meta information is only partially using i18n information from the Content Wrapper. Namely, it does NOT use the Product or Category ContentWrapper to receive internationalized content for Product Name and Description or Category Description but rather the direct properties of the product entity. > Using the ContentWrapper will overcome this shortcoming. > The fix needs to be applied in applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy > It is assumed that ContentWrappers will handle primitive over related Content properly, ie. if there is no related Content entity but only primitive content, it will return that. And if there is i18n content missing in the desired (current session) locale, it will return the default locale translation. > The attached fixes are for the most-used releases and trunk. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-4208) Product page meta-tag does not contain i18n content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006079#comment-13006079 ] Jacques Le Roux commented on OFBIZ-4208: ---------------------------------------- Hi Carsten, This needs a bit more work. See https://cwiki.apache.org/confluence/display/OFBIZ/How+to+localize+Product+and+Categories+descriptions and you should explain that in https://cwiki.apache.org/confluence/display/OFBIZ/Guide+to+OFBiz-i18n%2C++Internationalisation+of+OFBiz#GuidetoOFBiz-i18n,InternationalisationofOFBiz-ProductContentspecialremarks I mean that by default Product.productName and ProductCategory.description contain the info. It's only when you need to i18n then you use contentWrapper.get("PRODUCT_NAME"). THis could be discussed but it's how it has been build from the beginning. I think i18n did not exist at the beginning and the Content mechanism has been added later. Both are still handled, direct access being the default and you need to handle it. Thanks > Product page meta-tag does not contain i18n content > --------------------------------------------------- > > Key: OFBIZ-4208 > URL: https://issues.apache.org/jira/browse/OFBIZ-4208 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Release Branch 09.04, Release 09.04, Release Branch 10.04, SVN trunk > Environment: any > Reporter: Carsten Schinzer > Priority: Minor > Labels: i18n, meta-tags > Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-4208_Product page meta-tag does not contain i18n content-R09.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-R10.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-SVNTRUNK.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > the groovy script that produces the content meta information is only partially using i18n information from the Content Wrapper. Namely, it does NOT use the Product or Category ContentWrapper to receive internationalized content for Product Name and Description or Category Description but rather the direct properties of the product entity. > Using the ContentWrapper will overcome this shortcoming. > The fix needs to be applied in applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy > It is assumed that ContentWrappers will handle primitive over related Content properly, ie. if there is no related Content entity but only primitive content, it will return that. And if there is i18n content missing in the desired (current session) locale, it will return the default locale translation. > The attached fixes are for the most-used releases and trunk. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-4208) Product page meta-tag does not contain i18n content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006081#comment-13006081 ] Jacques Le Roux commented on OFBIZ-4208: ---------------------------------------- BTW you don't need to provide a patch for each version. Trunk is enough, we have tools to automatically backport in releases (sometimes with a little manual help) > Product page meta-tag does not contain i18n content > --------------------------------------------------- > > Key: OFBIZ-4208 > URL: https://issues.apache.org/jira/browse/OFBIZ-4208 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Release Branch 09.04, Release 09.04, Release Branch 10.04, SVN trunk > Environment: any > Reporter: Carsten Schinzer > Priority: Minor > Labels: i18n, meta-tags > Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-4208_Product page meta-tag does not contain i18n content-R09.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-R10.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-SVNTRUNK.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > the groovy script that produces the content meta information is only partially using i18n information from the Content Wrapper. Namely, it does NOT use the Product or Category ContentWrapper to receive internationalized content for Product Name and Description or Category Description but rather the direct properties of the product entity. > Using the ContentWrapper will overcome this shortcoming. > The fix needs to be applied in applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy > It is assumed that ContentWrappers will handle primitive over related Content properly, ie. if there is no related Content entity but only primitive content, it will return that. And if there is i18n content missing in the desired (current session) locale, it will return the default locale translation. > The attached fixes are for the most-used releases and trunk. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-4208) Product page meta-tag does not contain i18n content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007400#comment-13007400 ] Carsten Schinzer commented on OFBIZ-4208: ----------------------------------------- Hi Jacques, my impression was that the content wrapper classes as such do handle the regular-attribute-value vs. related-content-attribute-values for me as there were references to the content wrapper before I touched the groovy scripts (e.g. for the description meta-tag). I have now updated the online documents as you sugested. Please let me know whether you think anything else would be outstanding. Regards Carsten > Product page meta-tag does not contain i18n content > --------------------------------------------------- > > Key: OFBIZ-4208 > URL: https://issues.apache.org/jira/browse/OFBIZ-4208 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Release Branch 09.04, Release 09.04, Release Branch 10.04, SVN trunk > Environment: any > Reporter: Carsten Schinzer > Priority: Minor > Labels: i18n, meta-tags > Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-4208_Product page meta-tag does not contain i18n content-R09.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-R10.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-SVNTRUNK.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > the groovy script that produces the content meta information is only partially using i18n information from the Content Wrapper. Namely, it does NOT use the Product or Category ContentWrapper to receive internationalized content for Product Name and Description or Category Description but rather the direct properties of the product entity. > Using the ContentWrapper will overcome this shortcoming. > The fix needs to be applied in applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy > It is assumed that ContentWrappers will handle primitive over related Content properly, ie. if there is no related Content entity but only primitive content, it will return that. And if there is i18n content missing in the desired (current session) locale, it will return the default locale translation. > The attached fixes are for the most-used releases and trunk. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4208) Product page meta-tag does not contain i18n content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011826#comment-13011826 ] Jacques Le Roux commented on OFBIZ-4208: ---------------------------------------- Hi Carsten, It's ok with me, good work by the way! Just that someone has worked since on the same subject and I can't merge your work. Could you please handle it? Thanks > Product page meta-tag does not contain i18n content > --------------------------------------------------- > > Key: OFBIZ-4208 > URL: https://issues.apache.org/jira/browse/OFBIZ-4208 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Release Branch 09.04, Release 09.04, Release Branch 10.04, SVN trunk > Environment: any > Reporter: Carsten Schinzer > Priority: Minor > Labels: i18n, meta-tags > Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-4208_Product page meta-tag does not contain i18n content-R09.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-R10.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-SVNTRUNK.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > the groovy script that produces the content meta information is only partially using i18n information from the Content Wrapper. Namely, it does NOT use the Product or Category ContentWrapper to receive internationalized content for Product Name and Description or Category Description but rather the direct properties of the product entity. > Using the ContentWrapper will overcome this shortcoming. > The fix needs to be applied in applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy > It is assumed that ContentWrappers will handle primitive over related Content properly, ie. if there is no related Content entity but only primitive content, it will return that. And if there is i18n content missing in the desired (current session) locale, it will return the default locale translation. > The attached fixes are for the most-used releases and trunk. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4208) Product page meta-tag does not contain i18n content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015032#comment-13015032 ] Jacques Le Roux commented on OFBIZ-4208: ---------------------------------------- Thanks Carsten, Your patches for R10.04 and R9.04 are committed respectively at r1088035 and r1088034 At least your effort to build separate patches have been useful in this peculiar case ;) > Product page meta-tag does not contain i18n content > --------------------------------------------------- > > Key: OFBIZ-4208 > URL: https://issues.apache.org/jira/browse/OFBIZ-4208 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Release Branch 09.04, Release 09.04, Release Branch 10.04, SVN trunk > Environment: any > Reporter: Carsten Schinzer > Priority: Minor > Labels: i18n, meta-tags > Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-4208_Product page meta-tag does not contain i18n content-R09.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-R10.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-SVNTRUNK.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > the groovy script that produces the content meta information is only partially using i18n information from the Content Wrapper. Namely, it does NOT use the Product or Category ContentWrapper to receive internationalized content for Product Name and Description or Category Description but rather the direct properties of the product entity. > Using the ContentWrapper will overcome this shortcoming. > The fix needs to be applied in applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy > It is assumed that ContentWrappers will handle primitive over related Content properly, ie. if there is no related Content entity but only primitive content, it will return that. And if there is i18n content missing in the desired (current session) locale, it will return the default locale translation. > The attached fixes are for the most-used releases and trunk. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4208) Product page meta-tag does not contain i18n content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029861#comment-13029861 ] Jacques Le Roux commented on OFBIZ-4208: ---------------------------------------- Hi Carsten, Did you get a chance to update your trunk working copy? It's a pity it's corrected in releases and not in trunk... (BTW I will have to put it in R11.04 also) > Product page meta-tag does not contain i18n content > --------------------------------------------------- > > Key: OFBIZ-4208 > URL: https://issues.apache.org/jira/browse/OFBIZ-4208 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Release Branch 09.04, Release 09.04, Release Branch 10.04, SVN trunk > Environment: any > Reporter: Carsten Schinzer > Priority: Minor > Labels: i18n, meta-tags > Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-4208_Product page meta-tag does not contain i18n content-R09.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-R10.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-SVNTRUNK.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > the groovy script that produces the content meta information is only partially using i18n information from the Content Wrapper. Namely, it does NOT use the Product or Category ContentWrapper to receive internationalized content for Product Name and Description or Category Description but rather the direct properties of the product entity. > Using the ContentWrapper will overcome this shortcoming. > The fix needs to be applied in applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy > It is assumed that ContentWrappers will handle primitive over related Content properly, ie. if there is no related Content entity but only primitive content, it will return that. And if there is i18n content missing in the desired (current session) locale, it will return the default locale translation. > The attached fixes are for the most-used releases and trunk. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4208) Product page meta-tag does not contain i18n content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096905#comment-13096905 ] Jacques Le Roux commented on OFBIZ-4208: ---------------------------------------- Bump...? > Product page meta-tag does not contain i18n content > --------------------------------------------------- > > Key: OFBIZ-4208 > URL: https://issues.apache.org/jira/browse/OFBIZ-4208 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Release Branch 09.04, Release 09.04, Release Branch 10.04, SVN trunk > Environment: any > Reporter: Carsten Schinzer > Priority: Minor > Labels: i18n, meta-tags > Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk > > Attachments: OFBIZ-4208_Product page meta-tag does not contain i18n content-R09.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-R10.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-SVNTRUNK.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > the groovy script that produces the content meta information is only partially using i18n information from the Content Wrapper. Namely, it does NOT use the Product or Category ContentWrapper to receive internationalized content for Product Name and Description or Category Description but rather the direct properties of the product entity. > Using the ContentWrapper will overcome this shortcoming. > The fix needs to be applied in applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy > It is assumed that ContentWrappers will handle primitive over related Content properly, ie. if there is no related Content entity but only primitive content, it will return that. And if there is i18n content missing in the desired (current session) locale, it will return the default locale translation. > The attached fixes are for the most-used releases and trunk. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Closed] (OFBIZ-4208) Product page meta-tag does not contain i18n content
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4208. ---------------------------------- Resolution: Fixed Fix Version/s: Release Branch 11.04 Assignee: Jacques Le Roux Thanks Carsten, Your patch is in trunk at r1194958 R11.04 at r1194965. > Product page meta-tag does not contain i18n content > --------------------------------------------------- > > Key: OFBIZ-4208 > URL: https://issues.apache.org/jira/browse/OFBIZ-4208 > Project: OFBiz > Issue Type: Bug > Components: order > Affects Versions: Release Branch 09.04, Release 09.04, Release Branch 10.04, SVN trunk > Environment: any > Reporter: Carsten Schinzer > Assignee: Jacques Le Roux > Priority: Minor > Labels: i18n, meta-tags > Fix For: Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk > > Attachments: OFBIZ-4208_Product page meta-tag does not contain i18n content-R09.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-R10.04.patch, OFBIZ-4208_Product page meta-tag does not contain i18n content-SVNTRUNK.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > the groovy script that produces the content meta information is only partially using i18n information from the Content Wrapper. Namely, it does NOT use the Product or Category ContentWrapper to receive internationalized content for Product Name and Description or Category Description but rather the direct properties of the product entity. > Using the ContentWrapper will overcome this shortcoming. > The fix needs to be applied in applications/order/webapp/ordermgr/WEB-INF/actions/cart/catalog/Product.groovy > It is assumed that ContentWrappers will handle primitive over related Content properly, ie. if there is no related Content entity but only primitive content, it will return that. And if there is i18n content missing in the desired (current session) locale, it will return the default locale translation. > The attached fixes are for the most-used releases and trunk. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |