[jira] Created: (OFBIZ-4213) Add <compilerarg value="-Xlint"/> to all build targets

[Nicolas Malin (Jira)]

Add <compilerarg value="-Xlint"/> to all build targets
------------------------------------------------------

                 Key: OFBIZ-4213
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4213
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Jacques Le Roux
            Assignee: Jacques Le Roux
            Priority: Trivial


THe idea is to use  <compilerarg value="-Xlint"/> and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them

I will wait to commit that we remove most, if not all, of the warning messages in order to not fill the compile log



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4213:
-----------------------------------

    Description:
THe idea is to use  <compilerarg value="-Xlint"/> and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them

I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them



  was:
THe idea is to use  <compilerarg value="-Xlint"/> and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them

I will wait to commit that we remove most, if not all, of the warning messages in order to not fill the compile log

> Add <compilerarg value="-Xlint"/> to all build targets
> ------------------------------------------------------
>
>                 Key: OFBIZ-4213
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4213
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>
> THe idea is to use  <compilerarg value="-Xlint"/> and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them
> I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4213:
-----------------------------------

    Attachment: OFBIZ-4213_Add compilerarg value=-Xlint.patch

> Add <compilerarg value="-Xlint"/> to all build targets
> ------------------------------------------------------
>
>                 Key: OFBIZ-4213
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4213
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: OFBIZ-4213_Add compilerarg value=-Xlint.patch
>
>
> THe idea is to use  <compilerarg value="-Xlint"/> and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them
> I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006191#comment-13006191 ]

Jacques Le Roux commented on OFBIZ-4213:
----------------------------------------

Thanks to Marco's continued hard work, at r1081104 it's already pretty clean.
We just have now to understand why we get the
[javac16] warning: [path] bad path element "file_name": no such file or directory

This is very mysterious to me. For instance
* commons-io-1.3.1.jar exists but in lib/commons and I don't find anything referring to it
* commons-logging-1.0.4.jar does not exist but I don't find anything referring to it
* serializer-2.7.0.jar does not exist  but I don't find anything referring to it. And serializer-2.9.1.jar exists

> Add <compilerarg value="-Xlint"/> to all build targets
> ------------------------------------------------------
>
>                 Key: OFBIZ-4213
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4213
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: OFBIZ-4213_Add compilerarg value=-Xlint.patch
>
>
> THe idea is to use  <compilerarg value="-Xlint"/> and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them
> I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006203#comment-13006203 ]

Marco Risaliti commented on OFBIZ-4213:
---------------------------------------

Hi Jacques,

I have seen that it's due to the element Class-path inside the manifest.mf fo the jars.
For example inside barcode4j-fop-ext-complete-2.0.jar there is the manifest.jar with the element Class-path set to ${manifest-classpath}.
So we could avoid it without insert those jar specified in the manifest.mf but I having no more times to dig it.

Thanks
Marco

> Add <compilerarg value="-Xlint"/> to all build targets
> ------------------------------------------------------
>
>                 Key: OFBIZ-4213
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4213
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: OFBIZ-4213_Add compilerarg value=-Xlint.patch
>
>
> THe idea is to use  <compilerarg value="-Xlint"/> and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them
> I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4213:
-----------------------------------

    Attachment: OFBIZ-4213_Add compilerarg value=-Xlint.patch

Actually we need to use <compilerarg value="-Xlint"/> only in the macros.xml file

> Add <compilerarg value="-Xlint"/> to all build targets
> ------------------------------------------------------
>
>                 Key: OFBIZ-4213
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4213
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: OFBIZ-4213_Add compilerarg value=-Xlint.patch, OFBIZ-4213_Add compilerarg value=-Xlint.patch
>
>
> THe idea is to use  <compilerarg value="-Xlint"/> and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them
> I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4213.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

ok -Xlint:-path was the solution, committed at r1081138  

No one using javac16 will escape from warnings now :) I mean even in hot-deploy (if they follow best practices and use create-component)

> Add <compilerarg value="-Xlint"/> to all build targets
> ------------------------------------------------------
>
>                 Key: OFBIZ-4213
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4213
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4213_Add compilerarg value=-Xlint.patch, OFBIZ-4213_Add compilerarg value=-Xlint.patch
>
>
> THe idea is to use  <compilerarg value="-Xlint"/> and to not care about Eclipse, if some want to fix warning messages there, perfect, else we will simply forget about them
> I will wait to commit that we remove most, if not all, of the warning messages in order to not clutter the compile log with them

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira