OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

76 messages Options

1234

Nicolas Malin (Jira)

[jira] [Comment Edited] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400136#comment-13400136 ]

Jacques Le Roux edited comment on OFBIZ-4289 at 6/24/12 12:00 PM:
------------------------------------------------------------------

== ADDING SOME WORDS ==
To keep is short, I think there is no reasons to dicuss this any longer as long as we don't clarify the need/s on those 4 Objects in session at logout. Also of course developers who want to distribute their application should either remove non serialised Objects from session or serialise them. And this is not obvious when you develop and application and after (have to) decide that it should be distributed (and was not in initial requirements).

was (Author: jacques.le.roux):
To keep is short, I think there is no reasons to dicuss this any longer as long as we don't clarify the need/s on those 4 Objects in session at logout. Also of course developers who want to distribute their application should either remove non serialised Objects from session or serialise them.

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400138#comment-13400138 ]

Jacopo Cappellato commented on OFBIZ-4289:
------------------------------------------

Just read your last comment and yes I agree with what you wrote: before implementing a fix we should research and understand why OFBiz requires these non serializable objects in the session; one we realize this we can design a proper fix, like:
* refactor code so that they are not needed and can be removed
* make them serializable (if possible)
* write specific code to remove them before serialization and read them after deserialization

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400140#comment-13400140 ]

Jacques Le Roux commented on OFBIZ-4289:
----------------------------------------

Again crossed on wire, what do you think about my last point. Seems that we have a mean to
* write specific code to remove them before serialization and read them after deserialization

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Comment Edited] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400154#comment-13400154 ]

Jacopo Cappellato edited comment on OFBIZ-4289 at 6/24/12 1:59 PM:
-------------------------------------------------------------------

Jacques, am I wrong orin this last patch the meaning of the distributableApplication field is completely inverted?

I also still see the pattern:
{code}if (!variable) {//false} else {//true}{code}
rather than the easier to read:

{code}if (variable) {//true} else {//false}{code}

Also, but this is a minor note, when I suggested to group together all the code related to distributable apple I was thinking to refactor the code in this way:
{code}
Security security = null;
try {
security = SecurityFactory.getInstance(delegator);
} catch (SecurityConfigurationException e) {
Debug.logError(e, module);
}
Authorization authz = null;
try {
authz = AuthorizationFactory.getInstance(delegator);
} catch (SecurityConfigurationException e) {
Debug.logError(e, module);
}
// set all request attributes here:
request.setAttribute("dispatcher", dispatcher);
request.setAttribute("delegator", delegator);
request.setAttribute("security", security);
request.setAttribute("authz", authz);
// set all session attributes here:
if (distributableApplication) {
// these attributes are nulled here because they are not serializable and then recreated when the session is deserialized
session.setAttribute("dispatcher", null);
session.setAttribute("delegator", null);
session.setAttribute("security", null);
session.setAttribute("authz", null);
} else {
session.setAttribute("dispatcher", dispatcher);
session.setAttribute("delegator", delegator);
session.setAttribute("security", security);
session.setAttribute("authz", authz);
}
{code}

But yeah, all these code may be ignored if you find a mechanism to remove/add before/after serialization/deserialization these objects: this would be the right way to fix the issue.

was (Author: jacopoc):
Jacques, am I wrong orin this last patch the meaning of the distributableApplication field is completely inverted?

I also still see the pattern:
{code}if (!variable) {//false} else {//true}{code}
rather than the easier to read:

{code}if (variable) {//true} else {//false}{code}

Also, but this is a minor note, when I suggested to group together all the code related to distributable apple I was thinking to refactor the code in this way:
{code}
Security security = null;
try {
security = SecurityFactory.getInstance(delegator);
session.setAttribute("security", security);
} catch (SecurityConfigurationException e) {
Debug.logError(e, module);
}
Authorization authz = null;
try {
authz = AuthorizationFactory.getInstance(delegator);
session.setAttribute("authz", authz);
} catch (SecurityConfigurationException e) {
Debug.logError(e, module);
}
// set all request attributes here:
request.setAttribute("dispatcher", dispatcher);
request.setAttribute("delegator", delegator);
request.setAttribute("security", security);
request.setAttribute("authz", authz);
// set all session attributes here:
if (distributableApplication) {
// these attributes are nulled here because they are not serializable and then recreated when the session is deserialized
session.setAttribute("dispatcher", null);
session.setAttribute("delegator", null);
session.setAttribute("security", null);
session.setAttribute("authz", null);
} else {
session.setAttribute("dispatcher", dispatcher);
session.setAttribute("delegator", delegator);
session.setAttribute("security", security);
session.setAttribute("authz", authz);
}
{code}

But yeah, all these code may be ignored if you find a mechanism to remove/add before/after serialization/deserialization these objects: this would be the right way to fix the issue.

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4289:
-----------------------------------

Attachment: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch

OK, here is the plan:

from the delegatorName sets in session

session.setAttribute("delegatorName", delegatorName);

we can easily restitute, the 4 variables which are the problem:

// String delegatorName = session.getAttribute("delegatorName"); // set above, so always present
// Delegator delegator = DelegatorFactory.getDelegator(delegatorName);
// LocalDispatcher dispatcher = ContextFilter.makeWebappDispatcher(session.getServletContext(), delegator);
// Security security = SecurityFactory.getInstance(delegator)
// Authorization authz = AuthorizationFactory.getInstance(delegator)

I checked session.getAttribute() for each names in {*.java, *.groovy}, sessionAttributes.* in *.ftl, and in *een*.xml for the names themself, they are needed in
# ControlServlet.doGet() (the 4)
# BirtWorker.setWebContextObjects() (delegator, dispatcher, security)
# ScrumEvents.timeSheetChecker() (delegator)

In ControlServlet.doGet(), getServletContext().getAttribute() is used to retrieve the 4 if missing => not a pb. Same for the others, if ever it's one then we can still use the lines of the snippet above in due places. I will not fix all OFBiz code for this issue, for instance I read in ScrumEvents.timeSheetChecker()

{code}
Delegator delegator = (Delegator) session.getAttribute("delegator");
[...]
if (UtilValidate.isEmpty(delegator)) {
delegator = (Delegator) request.getAttribute("delegator");
}
{code}
Why not? (I guess it's C/P not refactored)
{code}
Delegator delegator = (Delegator) request.getAttribute("delegator");
{code}
etc.

So I believe we simply have to not put them in session when using distributable applications, see the attached patch . I refactored for easier/safer reading, and yes reversed the condition. I finally really wonder if they are usefull in session at all. I put a NOTE2 under the NOTE:
// NOTE: we do NOT want to set this in the servletContext, only in the request and session
// NOTE2: it would have been more helpful to know the why than the what (only few words)!

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400307#comment-13400307 ]

Jacques Le Roux commented on OFBIZ-4289:
----------------------------------------

OK about the NOTE and NOTE2. I did a small research this morning and as I thought (I certainly did the same intially one year ago, but it was blured in my mind) it's related to multitenant. Look for setWebContextObjects at [r927271|http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java?r1=927271&r2=927270&pathrev=927271]

I still believe the session variables are useless. To be sure we have to test my changes in multitenant with distributed applications.

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400309#comment-13400309 ]

Jacques Le Roux commented on OFBIZ-4289:
----------------------------------------

Ha this comment is interesting
{code}
if (setupNewDelegatorEtc) {
// now set the delegator and dispatcher in a bunch of places just in case they were changed
setWebContextObjects(request, response, delegator, dispatcher);
}
{code}

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400315#comment-13400315 ]

Jacopo Cappellato commented on OFBIZ-4289:
------------------------------------------

Jacques,

there are so many things that I still don't like in your patch, I am sorry (if you think I am becoming too picky, please ask for the review of someone else, it would actually be good to get others' opinion).

A) this should be logged as info rather than error (deploying on tomcat is not mandatory):
{code}+ Debug.logError(e, "No catalina-container configuration found in container config!");{code}

B)
I am still confused by the usage of the usage of the "distributableApplication" variable; the way I understand its meaning is the following:
* distributableApplication should match the value of the xml field "apps-distributable"
* when this value is set to true then the application will be distributed and the sessions will be serialized

If the two sentences are correct then there are issues in your code.

C)
And your last patch is, by default, not setting the fields in session and this will *again* generate the error that I fixed a few days ago (introduced when you first implemented this feature).

D)
The steps to recreate the error are listed in a previous comment in this task... if you simply set to null (as you still are suggesting) the fields when apps-distributable is set to true then the error will happen again so your proposed patch doesn't fix the issue.

E)
A final note; what is the purpose of this comment:

{code}+ // NOTE2: it would have been more helpful to know the why than the what (only few words)!{code}

? I hope you are not proposing to commit it

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4289:
-----------------------------------

Attachment: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch

Jacopo,

A) Right, I will use <<Debug.logError(e, module);>> rather. Note that I don't know yet how this will work when out of the Tomcat context for distributed application. Because, at least for now, I have no means to know if we are in such a context for other application servers. The problem will be the same than with current code: those application servers will try to persist the session and will stumble upon those not serialised variables and a NPE will be thrown. This should be investigated in appserver component, another task...
B) Right, when you suggested to change the name of the distributableApplication boolean var (from sessionPersistence) it also reversed its meaning. I forgot then to change the initialisation and to remove the negation when assigning it
{code}
Boolean distributableApplication = true;
[...]
distributableApplication = !ContainerConfig.getPropertyValue(cc, "apps-distributable", false);
{code}
are now
{code}
Boolean distributableApplication = false;
[...]
distributableApplication = ContainerConfig.getPropertyValue(cc, "apps-distributable", false);
{code}
C) This was due to B. With attached patch, the vars are not put in session only in distributable mode. So current behaviour will continue, but in case of distrib apps we will not cross a NPE.
D) This was due to B, I tested it's OK with attached patch
E) Actually the comment I found
{code}
// now set the delegator and dispatcher in a bunch of places just in case they were changed
{code}
answers to this question. I have been positive and reused this knowledge in NOTE2 rather than complaining

I think my last patch answers to all your questions. It works in both cases: apps-distributable being true or false

The bright side of this brainstorming is that it's now really easy to test. The confusion I intially introduced with DeltaManager no longer exists. And since the default Manager (StandardManager) is also able to persist sessions only changing the value of apps-distributable to true or false allows to test the "feature"

Just curious: why did you not use the Jira automatic numbering (ie #) and used instead A), B) etc. ?

Thanks for your continued reviews!

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400358#comment-13400358 ]

Jacopo Cappellato commented on OFBIZ-4289:
------------------------------------------

Jacques... there are still issues and I am running out of time :-(

* if you use Debug.logError(e, module), all deployments using Jetty will get an error logged; please use logInfo instead as I suggested earlier

* the default method calls are still all wrong:
{code}setWebContextObjects(request, response, delegator, dispatcher, true);{code}
should be:
{code}setWebContextObjects(request, response, delegator, dispatcher, false);{code}

* and maybe I was not clear enough but I don't see how the issue that I reported with testing steps (login/logout/login with different account/visit another web app) could be fixed (for distributed applications) by your patch

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400380#comment-13400380 ]

Jacopo Cappellato commented on OFBIZ-4289:
------------------------------------------

I tested it and I see errors in the log (cause by delegator not being serializable) and this is actually what I was expecting since you call
{code}setWebContextObjects(request, response, delegator, dispatcher, false);{code}

at login and you only check apps-distributable at logout... I don't see how this could work for you.

But as I said several times, the idea of the fix is wrong at least until you figure out why these attributes are set in the session (are they used somewhere? is it to improve performance? other reasons?): you cannot fix it by removing the values and not taking care of providing a mechanism to restore them without causing too much overhead when the session is deserialized (and the comments you added simply indicate that some ootb code could be broken but they don't fix the issue).

Am I the only one who thinks that this is wrong way to tackle the problem?

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400405#comment-13400405 ]

Jacopo Cappellato commented on OFBIZ-4289:
------------------------------------------

With reference to the error in the logs I reported in my last comment: it could be caused by a session object created before the code change.
I am reviewing the ootb code to see if we can get rid of a few old code.

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400409#comment-13400409 ]

Jacopo Cappellato commented on OFBIZ-4289:
------------------------------------------

No, the error is actually:

2012-06-25 12:55:34,799 (0.0.0.0-startStop-1) [ StandardSession.java:1677:WARN ] Cannot serialize session attribute _LAST_VIEW_PARAMS_ for session 22BA02AF26EA4852DB8C79CF0052F22B.jvm1
java.io.NotSerializableException: org.ofbiz.entity.GenericDelegator
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164)
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1518)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1483)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1400)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1158)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330)
at javolution.util.FastMap.writeObject(FastMap.java:1513)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:940)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1469)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1400)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1158)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330)
at org.apache.catalina.session.StandardSession.writeObject(StandardSession.java:1671)
at org.apache.catalina.session.StandardSession.writeObjectData(StandardSession.java:1077)
at org.apache.catalina.session.StandardManager.doUnload(StandardManager.java:432)
at org.apache.catalina.session.StandardManager.unload(StandardManager.java:353)
at org.apache.catalina.session.StandardManager.stopInternal(StandardManager.java:518)
at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232)
at org.apache.catalina.core.StandardContext.stopInternal(StandardContext.java:5473)
at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232)
at org.apache.catalina.core.ContainerBase$StopChild.call(ContainerBase.java:1611)
at org.apache.catalina.core.ContainerBase$StopChild.call(ContainerBase.java:1600)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:680)

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff, ofbiz.log
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400479#comment-13400479 ]

Jacques Le Roux commented on OFBIZ-4289:
----------------------------------------

I get this also (in a customised instance but not much cannched for framework)
2012-06-12 10:35:29,921 (OFBiz_Shutdown_Hook) [ StandardSession.java:1567:WARN ] Cannot serialize session attribute _LAST_VIEW_PARAMS_ for session 00C48D0D76821C98403482FAE8B77C24.jvm1
java.io.NotSerializableException: net.sf.json.JSONObject
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1164)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:330)
at javolution.util.FastMap.writeObject(FastMap.java:1513)

Do _LAST_VIEW_PARAMS_ is a FastMap<String, Object> returned by UtilHttp.getParameterMap(). I read it implements javolution.xml.XMLSerializable but not sure what this is and the Tomcat StandarManager does not seems to appreciate (StandardSession.java:1567:WARN). We can replace by an HashMap which implements Serializable
{code}
Index: framework/base/src/org/ofbiz/base/util/UtilHttp.java
===================================================================
--- framework/base/src/org/ofbiz/base/util/UtilHttp.java (revision 1353393)
+++ framework/base/src/org/ofbiz/base/util/UtilHttp.java (working copy)
@@ -113,7 +113,7 @@
*/
public static Map<String, Object> getParameterMap(HttpServletRequest request, Set<? extends String> nameSet, Boolean onlyIncludeOrSkip) {
boolean onlyIncludeOrSkipPrim = onlyIncludeOrSkip == null ? true : onlyIncludeOrSkip.booleanValue();
- Map<String, Object> paramMap = FastMap.newInstance();
+ Map<String, Object> paramMap = new HashMap<String, Object>();

// add all the actual HTTP request parameters
Enumeration<String> e = UtilGenerics.cast(request.getParameterNames());
{code}

I tried it seems to work fine (small test, see attached log)

Note that LAST_VIEW_PARAMS was introduced previously to multitenant changes. There are maybe other such Objects put in session, but (quickly) looking around in RequestHandler found none (others are simple String).

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff, ofbiz.log
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400486#comment-13400486 ]

Jacopo Cappellato commented on OFBIZ-4289:
------------------------------------------

The way I see it is that the map in the session may contain non serializable objects like for example the Delegator or a JSONObject object.

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff, ofbiz.log
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4289) Login out on a cluster handled by DeltaManager causes a NPE

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400510#comment-13400510 ]

Jacques Le Roux commented on OFBIZ-4289:
----------------------------------------

Yes, I tried to fix an issue I crossed because it was *blocking*. For the others it depends on the needs, in the eCommerce world, round robin LB and sticky sessions do it, you rarely need to really persist sessions.

> Login out on a cluster handled by DeltaManager causes a NPE
> -----------------------------------------------------------
>
> Key: OFBIZ-4289
> URL: https://issues.apache.org/jira/browse/OFBIZ-4289
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
> Environment: Ubuntu
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Critical
> Labels: cluster, logout
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, OFBIZ-4289_Login_out_on_a cluster_handled_by_DeltaManager_causes_a_NPE.patch, changeset_2510.diff, ofbiz.log
>
>
> It works locally but not on clusters. You simply get a NPE.
> h3. Problem
> * When we logout we cross an issue due to Tomcat sessions persistence.
> * Because we set distributable to true, to allow sessions failover,
> * and use and DeltaManager for replication.
> * Delegator and other main Classes (notably Dispatcher) are not serialized in OFBiz. This is the origin of the problem
> h3. Tried solutions
> By default DeltaManager save active sessions on disk. It uses a private String variable pathname for that (default to "SESSIONS.ser"). You can set it to null, to avoid session persistence, using a context.xml file in the WEB-INF folder with content like below. But I tried it in webtools app on staging qs001 (only) and it did not work (with distributable set to false). And we have no other means to set it from OFBiz (OOTB).
> {code}
> <Context>
> <Manager className="org.apache.catalina.session.DeltatManager" pathname="">
> </Manager>
> </Context>
> {code}

1234