[jira] [Created] (OFBIZ-4293) Set TransactionUtil#debugResources default value to false and make it configurable

[Nicolas Malin (Jira)]

Set TransactionUtil#debugResources default value to false and make it configurable
----------------------------------------------------------------------------------

                 Key: OFBIZ-4293
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4293
             Project: OFBiz
          Issue Type: Sub-task
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Philippe Mouawad


As asked by David and Jacques:
"I didn't say I'm against a configurable setting, like a properties file setting. I said I'm against changing the default in the code for all of OFBiz without making it configurable.
On the topic of configuration: I'm against business-level configuration in properties files (that should go in the DB), I'm not against technical or system configuration in properties files, in fact that's just where it belongs."
"About debugResources (debug stack)
We could easily create a properties for that"



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038089#comment-13038089 ]

Philippe Mouawad commented on OFBIZ-4293:
-----------------------------------------

Hello,
I plan to add this configuration in entityengine.xml and call it:
        <debug-xa-resources value="false" />

Are you OK with this ?

Thank you
Regards
Philippe

> Set TransactionUtil#debugResources default value to false and make it configurable
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4293
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4293
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Philippe Mouawad
>              Labels: performance
>
> As asked by David and Jacques:
> "I didn't say I'm against a configurable setting, like a properties file setting. I said I'm against changing the default in the code for all of OFBiz without making it configurable.
> On the topic of configuration: I'm against business-level configuration in properties files (that should go in the DB), I'm not against technical or system configuration in properties files, in fact that's just where it belongs."
> "About debugResources (debug stack)
> We could easily create a properties for that"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philippe Mouawad updated OFBIZ-4293:
------------------------------------

    Attachment: patch-OFBIZ-4293.patch

The patch, sorry it also contains removal of synchronized in internalBegin.

Philippe
http://www.ubik-ingenierie.com

> Set TransactionUtil#debugResources default value to false and make it configurable
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4293
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4293
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Philippe Mouawad
>              Labels: performance
>         Attachments: patch-OFBIZ-4293.patch
>
>
> As asked by David and Jacques:
> "I didn't say I'm against a configurable setting, like a properties file setting. I said I'm against changing the default in the code for all of OFBiz without making it configurable.
> On the topic of configuration: I'm against business-level configuration in properties files (that should go in the DB), I'm not against technical or system configuration in properties files, in fact that's just where it belongs."
> "About debugResources (debug stack)
> We could easily create a properties for that"

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4293.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Thanks Philippe,

Your patch is in trunk at r1226234  

Minor points: please don't use tabs in your patch (entityengine.xml), follow the standard formatting way (no new lines for else, EntityConfigUtil.java), avoid to put changes from another patch in a patch (internalBegin)
               

> Set TransactionUtil#debugResources default value to false and make it configurable
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4293
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4293
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Philippe Mouawad
>            Assignee: Jacques Le Roux
>              Labels: performance
>             Fix For: SVN trunk
>
>         Attachments: patch-OFBIZ-4293.patch
>
>
> As asked by David and Jacques:
> "I didn't say I'm against a configurable setting, like a properties file setting. I said I'm against changing the default in the code for all of OFBiz without making it configurable.
> On the topic of configuration: I'm against business-level configuration in properties files (that should go in the DB), I'm not against technical or system configuration in properties files, in fact that's just where it belongs."
> "About debugResources (debug stack)
> We could easily create a properties for that"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira