OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4300) Make doctype as a configuration

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4300) Make doctype as a configuration

Make doctype as a configuration
-------------------------------

Key: OFBIZ-4300
URL: https://issues.apache.org/jira/browse/OFBIZ-4300
Project: OFBiz
Issue Type: Sub-task
Reporter: Patrick Antivackis
Priority: Minor

Today doctype is either generated by java (hard coded) or ftl macros.
The idea is :
- to externalize doctypes to a config file (framework/base/config/doctype.properties)
- define a default doctype in the previous config file for all ofbiz application
- allow a specific doctype at an application level (web.xml)
- allow a specific doctype at a view level (controller.xml)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4300) Make doctype as a configuration

[ https://issues.apache.org/jira/browse/OFBIZ-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Antivackis updated OFBIZ-4300:
--------------------------------------

Description:
Today doctype is either generated by java (hard coded) or ftl macros.
The idea is :
- to externalize doctypes to a config file (framework/base/config/doctype.properties)
- define a default doctype in the previous config file for all ofbiz application
- allow a specific doctype at an application level (web.xml)
- allow a specific doctype at a view level (controller.xml)

I imagine the config file like this :

{code:title=/framework/base/config/doctype.properties|borderStyle=solid}
####
# OFBiz Doctype properties File
####
w3c.html-4.01-strict=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
w3c.html-4.01-transitional=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
w3c.html-4.01-frameset=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN" "http://www.w3.org/TR/html4/frameset.dtd">
w3c.xhtml-1.0-transitional=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
w3c.xhtml-1.0-strict=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
w3c.xhtml-1.0-frameset=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">
w3c.xhtml-1.1=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
w3c.html5=<!DOCTYPE HTML>
{code}

was:
Today doctype is either generated by java (hard coded) or ftl macros.
The idea is :
- to externalize doctypes to a config file (framework/base/config/doctype.properties)
- define a default doctype in the previous config file for all ofbiz application
- allow a specific doctype at an application level (web.xml)
- allow a specific doctype at a view level (controller.xml)

> Make doctype as a configuration
> -------------------------------
>
> Key: OFBIZ-4300
> URL: https://issues.apache.org/jira/browse/OFBIZ-4300
> Project: OFBiz
> Issue Type: Sub-task
> Reporter: Patrick Antivackis
> Priority: Minor
>
> Today doctype is either generated by java (hard coded) or ftl macros.
> The idea is :
> - to externalize doctypes to a config file (framework/base/config/doctype.properties)
> - define a default doctype in the previous config file for all ofbiz application
> - allow a specific doctype at an application level (web.xml)
> - allow a specific doctype at a view level (controller.xml)
> I imagine the config file like this :
> {code:title=/framework/base/config/doctype.properties|borderStyle=solid}
> ####
> # OFBiz Doctype properties File
> ####
> w3c.html-4.01-strict=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
> w3c.html-4.01-transitional=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
> w3c.html-4.01-frameset=<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN" "http://www.w3.org/TR/html4/frameset.dtd">
> w3c.xhtml-1.0-transitional=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> w3c.xhtml-1.0-strict=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> w3c.xhtml-1.0-frameset=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">
> w3c.xhtml-1.1=<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
> w3c.html5=<!DOCTYPE HTML>
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4300) Make doctype as a configuration

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224962#comment-13224962 ]

Hans Bakker commented on OFBIZ-4300:
------------------------------------

Anybody any objections against or a favor of implementing this issue?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4300) Make doctype as a configuration

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225028#comment-13225028 ]

Jacopo Cappellato commented on OFBIZ-4300:
------------------------------------------

Before we proceed I would like to better understand what is the problem that we are trying to solve with this change.
Please also consider that ftl macros are intended to be customized while the Java code with hardcoded DOCTYPE is probably old code (HtmlScreenRenderer) that has been superseded by the newer macro code.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4300) Make doctype as a configuration

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225033#comment-13225033 ]

Adrian Crum commented on OFBIZ-4300:
------------------------------------

The hard coded DOCTYPE was necessary because of the screen widget boundary comments. The DOCTYPE element needs to be emitted before passing control to the screen widgets, otherwise you will have widget boundary comments appear before the DOCTYPE element - which causes problems with some browsers.

Changing the hard-coded DOCTYPE text to a property would be fine, but we still need to write the DOCTYPE before passing control to the screen widgets.

Nicolas Malin (Jira)

[jira] [Issue Comment Edited] (OFBIZ-4300) Make doctype as a configuration

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225033#comment-13225033 ]

Adrian Crum edited comment on OFBIZ-4300 at 3/8/12 6:29 AM:
------------------------------------------------------------

The hard coded DOCTYPE was necessary because of the screen widget boundary comments. The DOCTYPE element needs to be emitted before passing control to the screen widgets, otherwise you will have widget boundary comments appear before the DOCTYPE element - which causes problems with some browsers.

Changing the hard-coded DOCTYPE text to a property would be fine, but we still need to write the DOCTYPE element before passing control to the screen widgets.

was (Author: [hidden email]):
The hard coded DOCTYPE was necessary because of the screen widget boundary comments. The DOCTYPE element needs to be emitted before passing control to the screen widgets, otherwise you will have widget boundary comments appear before the DOCTYPE element - which causes problems with some browsers.

Changing the hard-coded DOCTYPE text to a property would be fine, but we still need to write the DOCTYPE before passing control to the screen widgets.