[jira] [Created] (OFBIZ-4308) CalendarDateSelect Shows wrong selected date

[Nicolas Malin (Jira)]

CalendarDateSelect Shows wrong selected date
---------------------------------------------

                 Key: OFBIZ-4308
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 10.04
            Reporter: Stephen Rufle


When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Rufle updated OFBIZ-4308:
---------------------------------

    Attachment: OrderPurchaseReportOptions-CalendarDateSelect.jpg

This shows the issue. I entered 2011-05-03, the image shows 2011-05-02 selected

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>         Attachments: OrderPurchaseReportOptions-CalendarDateSelect.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Rufle updated OFBIZ-4308:
---------------------------------

    Attachment: OFBIZ-4308.patch

Changing the standard '-' to a '/' and then letting parseFormattedString be called seems to fix the issue locally

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044619#comment-13044619 ]

Jacques Le Roux commented on OFBIZ-4308:
----------------------------------------

Sorry Stephen,

Which revision are you using: I don't reproduce with latest

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044805#comment-13044805 ]

Stephen Rufle commented on OFBIZ-4308:
--------------------------------------

r1104428
http://svn.apache.org/repos/asf/ofbiz/branches/release10.04

I definitely see the issue as per the image. I have tracked it to how new Date(string) creates a date. Having said that I am using FF4, not sure that should make a difference.

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4308:
-----------------------------------

    Attachment: screenshot-1.jpg

Sorry again, I tried with the same revision, same language, same theme and I use also FF4 and I still don't reproduce (see screenshot-1)

It would be interesting ot have other persons tests

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg, screenshot-1.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045083#comment-13045083 ]

Jacques Le Roux commented on OFBIZ-4308:
----------------------------------------

BTW the only changes I got when goipng back to r1104428 were these,

Command: Update  
Updated: D:\workspace\release10.04\framework\widget\templates\xmlFormMacroLibrary.ftl  text/plain
Updated: D:\workspace\release10.04\framework\widget\templates\foFormMacroLibrary.ftl  text/plain
Updated: D:\workspace\release10.04\framework\widget\templates\textFormMacroLibrary.ftl  text/plain
Updated: D:\workspace\release10.04\framework\widget\templates\csvFormMacroLibrary.ftl  text/plain
Updated: D:\workspace\release10.04\framework\service\src\org\ofbiz\service\ServiceDispatcher.java  text/plain
Updated: D:\workspace\release10.04\framework\entity\src\org\ofbiz\entity\Delegator.java  text/plain
Updated: D:\workspace\release10.04\framework\entity\src\org\ofbiz\entity\GenericDelegator.java  text/plain
Updated: D:\workspace\release10.04\specialpurpose\pos\config\xpos.properties  text/plain
Updated: D:\workspace\release10.04  
Completed: At revision: 1104428  

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg, screenshot-1.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045084#comment-13045084 ]

Jacques Le Roux commented on OFBIZ-4308:
----------------------------------------

Also note that I use a French system, sets as a French system

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg, screenshot-1.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045489#comment-13045489 ]

Stephen Rufle commented on OFBIZ-4308:
--------------------------------------

I did a fresh checkout of http://svn.apache.org/repos/asf/ofbiz/branches/release10.04
ant run-install
startofbiz.bat
Changed to "Flat Grey" theme (I am sure it happens with any theme)

https://localhost:8443/ordermgr/control/OrderPurchaseReportOptions
 
Enter 2011-05-03 in "Sales by Store Report" > "From Date"
Pop Open calendar (see wrong date selected)

In the firebug console, this is where I saw the issue most clearly
BAD: new Date("2011-05-03") -> Date {Mon May 02 2011 17:00:00 GMT-0700 (US Mountain Standard Time)}
GOOD: new Date("2011/05/03") -> Date {Tue May 03 2011 00:00:00 GMT-0700 (US Mountain Standard Time)}

You may not see the issue because your time offset from GMT is enough that when you do the testing you fall on the correct day <shrug>.

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg, screenshot-1.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4308.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 10.04
                   Release Branch 09.04
         Assignee: Jacques Le Roux

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 09.04, Release Branch 10.04
>
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg, screenshot-1.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-4308:
------------------------------------


Another time got by this damned cancel button :/

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 09.04, Release Branch 10.04
>
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg, screenshot-1.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045572#comment-13045572 ]

Jacques Le Roux commented on OFBIZ-4308:
----------------------------------------

Stephen,

You convinced me, I tried the change and using either 2005-05-03 or 2005/05/03 it worked. I then commited your change (without the
{code}
-    // mod for ofbiz
+    // mod for ofbiz
{code}
part) at r1133111.

But then I just had a doubt about the slash used in date and I suddenly remembered that we need also to handle time in such fields. And this change breaks it. For instance try to add 20:00:00.000 after the date... (using either 2005-05-03 or 2005/05/03). So it needs more work...

Reverted at r1133119

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 09.04, Release Branch 10.04
>
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg, screenshot-1.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178135#comment-13178135 ]

Jacques Le Roux commented on OFBIZ-4308:
----------------------------------------

Any update?
               

> CalendarDateSelect Shows wrong selected date
> ---------------------------------------------
>
>                 Key: OFBIZ-4308
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4308
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 09.04, Release Branch 10.04
>
>         Attachments: OFBIZ-4308.patch, OrderPurchaseReportOptions-CalendarDateSelect.jpg, screenshot-1.jpg
>
>
> When a date value is initially specified ex.2011-05-03 and then the calendar is popped open the date is off by one.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira