[jira] [Created] (OFBIZ-4327) deny list

[Nicolas Malin (Jira)]

deny list
---------

                 Key: OFBIZ-4327
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
             Project: OFBiz
          Issue Type: New Feature
          Components: framework
    Affects Versions: SVN trunk
            Reporter: BJ Freeman
            Priority: Minor


the allows on the fly addition of deny parms before a lot of resources are allocated.
The goal is to filter out the requests that are not relevant to the site.
Like the image bots that just want you images.
or someone that copies you content.
the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054999#comment-13054999 ]

BJ Freeman commented on OFBIZ-4327:
-----------------------------------

I left some hooks and parms in to expand this further.
as I get time i will add to it.
It does what I want now so I doubt I will do anything more till next year.

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-4327:
------------------------------

    Attachment: OFBIZ-4327.patch

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: OFBIZ-4327.patch
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-4327:
------------------------------

    Attachment: VisitFllter.xml

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: OFBIZ-4327.patch, VisitFllter.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-4327:
------------------------------

    Attachment: OFBIZ-4327.patch

typo

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: OFBIZ-4327.patch, OFBIZ-4327.patch, VisitFllter.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-4327:
------------------------------

    Attachment: VisitFllterIP.xml

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: OFBIZ-4327.patch, OFBIZ-4327.patch, VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056862#comment-13056862 ]

Jacques Le Roux commented on OFBIZ-4327:
----------------------------------------

Hi BJ,

Some remarks after a quick review:

# Minor: bad indentation and formatting in ControlServlet.java, for instance
{code}
if(VisitHandler.filterVisitor(request, response)==Boolean.TRUE){
{code}
should be
{code}
if (VisitHandler.filterVisitor(request, response) == Boolean.TRUE) {
{code}
# You use tabs in your patch.
# I did not see a mean to deactivate this option (for instance if you already filter with HTTPD in front)

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: OFBIZ-4327.patch, OFBIZ-4327.patch, VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056930#comment-13056930 ]

BJ Freeman commented on OFBIZ-4327:
-----------------------------------

thought I had eclipse set to 4 spaces though it would not have caught ==

#3 if the VisitFllter entity is empty it returns a false so not action taken. an indirect option. putting in code to disable would have about the same time as the way it is set up now.

Note this is not ready yet. I thought it was working but it was not loaded.
once loaded I found errors I am working on.
that is why I removed the patch provided flag

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: OFBIZ-4327.patch, OFBIZ-4327.patch, VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057049#comment-13057049 ]

Jacques Le Roux commented on OFBIZ-4327:
----------------------------------------

3. if the data are put as demo it's OK with me. The idea is also to prevent the overhead it it's done in HHTPD or like

Better to remove patches than simply remove the feather, it's not obvious to spot the change

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4327:
-----------------------------------

    Attachment:     (was: OFBIZ-4327.patch)

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4327:
-----------------------------------

    Attachment:     (was: OFBIZ-4327.patch)

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059151#comment-13059151 ]

BJ Freeman commented on OFBIZ-4327:
-----------------------------------

I did not find the way to delete the patches.
I did not expect it to be put in trunk.
and yes the filter of the web.xml is where it programmaticly go.
my understanding, is in ofbiz, unlike TC it takes a restart.
This is not acceptable for productions.

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059164#comment-13059164 ]

Jacques Le Roux commented on OFBIZ-4327:
----------------------------------------

I meant you can do that in Apache HTTPD conf, which is completly unrelated to OFBiz.

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059167#comment-13059167 ]

BJ Freeman commented on OFBIZ-4327:
-----------------------------------

Yes, that assumes using AJP.
I am migrating from that since it seems the AJP gets clogged up.
we can close this and I will put it on my site.

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059168#comment-13059168 ]

Jacques Le Roux commented on OFBIZ-4327:
----------------------------------------

For my information, what do you mean exaclty by "AJP gets clogged up"?

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059169#comment-13059169 ]

Jacques Le Roux commented on OFBIZ-4327:
----------------------------------------

BTW why do you give up? Should we really close?

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059207#comment-13059207 ]

BJ Freeman commented on OFBIZ-4327:
-----------------------------------

though some messages of broken pipes comes from the handling of errors in Controlserverlet.java, there are some AJP broken pipes messages of data that does not get transfer to the Browser. I have not address it specifically here because I can not pinpoint the cause.

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059212#comment-13059212 ]

BJ Freeman commented on OFBIZ-4327:
-----------------------------------

what you call give up I call taking the path of least resistance.
I see the difference in being most want stuff in ofbiz svn so they can use the svn to further their business.
From the get go my view was I would like to contribute what I am already planning
Now I don't mind  someone doing a Code review, to maintain best practices. But when the overhead to contributed exceeds a limit of what I want to do, I cut if off so I can direct my energy to those things the have a higher priority.

It is NOT important to me to have what I contribute in the SVN.

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4327.
----------------------------------

    Resolution: Later
      Assignee: Jacques Le Roux

Maybe later...

> deny list
> ---------
>
>                 Key: OFBIZ-4327
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4327
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Assignee: Jacques Le Roux
>            Priority: Minor
>              Labels: deny, list, obiz
>         Attachments: VisitFllter.xml, VisitFllterIP.xml
>
>
> the allows on the fly addition of deny parms before a lot of resources are allocated.
> The goal is to filter out the requests that are not relevant to the site.
> Like the image bots that just want you images.
> or someone that copies you content.
> the two seed data are from mod rewrite for bots(171) and Ip's that are known to attempt to hack, or do unnecessary requests.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira