[jira] [Created] (OFBIZ-4333) Refactoring send email engine
Locked
[jira] [Created] (OFBIZ-4333) Refactoring send email engine
 
|
Refactoring send email engine
----------------------------- Key: OFBIZ-4333 URL: https://issues.apache.org/jira/browse/OFBIZ-4333 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS, content, framework Affects Versions: SVN trunk Reporter: Nicolas Malin Fix For: SVN trunk In OFBiz history, the first entity used was ProductStoreEmailSetting, for automatic email during ecommerce process and in last time the EmailTemplateSetting for specific notification. Both entities have the same field : bodyScreenLocation, xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject, contentType. Just primary key are differents. To simplify the notification system, I will suggest : * use only EmailTemplateSetting to edit email configuration * associate ProductStoreEmailSetting to EmailTemplateSetting * convert all service and screen that use ProductStoreEmailSetting * create convert service. * add contentId on EmailTemplateSetting (or templaceContentId) to use a content for rendering email -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4333) Refactoring send email engine
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4333: --------------------------------- Attachment: OFBIZ-4322.patch I propose to advance step by step. The first patch contains model data refactoring : * associate ProductStoreEmailSetting to EmailTemplateSetting * Create view ProductStoreEmailAndSetting * Extend EmailTemplateSetting on content component to add contentId (don't create dependency between framework and content) I change also ProductStoreEmailSetting call by ProductStoreEmailAndSetting to view impact on code. I wait your comment to continue. When the data model conversion will be validate, I will complete the patch with refactoring service. > Refactoring send email engine > ----------------------------- > > Key: OFBIZ-4333 > URL: https://issues.apache.org/jira/browse/OFBIZ-4333 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, content, framework > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Labels: content, mail, notification > Fix For: SVN trunk > > Attachments: OFBIZ-4322.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > In OFBiz history, the first entity used was ProductStoreEmailSetting, for automatic email during ecommerce process and in last time the EmailTemplateSetting for specific notification. > Both entities have the same field : bodyScreenLocation, xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject, contentType. Just primary key are differents. > To simplify the notification system, I will suggest : > * use only EmailTemplateSetting to edit email configuration > * associate ProductStoreEmailSetting to EmailTemplateSetting > * convert all service and screen that use ProductStoreEmailSetting > * create convert service. > * add contentId on EmailTemplateSetting (or templaceContentId) to use a content for rendering email -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4333) Refactoring send email engine
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4333: --------------------------------- Attachment: OFBIZ-4333.patch Oups, not load the good patch :) > Refactoring send email engine > ----------------------------- > > Key: OFBIZ-4333 > URL: https://issues.apache.org/jira/browse/OFBIZ-4333 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, content, framework > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Labels: content, mail, notification > Fix For: SVN trunk > > Attachments: OFBIZ-4322.patch, OFBIZ-4333.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > In OFBiz history, the first entity used was ProductStoreEmailSetting, for automatic email during ecommerce process and in last time the EmailTemplateSetting for specific notification. > Both entities have the same field : bodyScreenLocation, xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject, contentType. Just primary key are differents. > To simplify the notification system, I will suggest : > * use only EmailTemplateSetting to edit email configuration > * associate ProductStoreEmailSetting to EmailTemplateSetting > * convert all service and screen that use ProductStoreEmailSetting > * create convert service. > * add contentId on EmailTemplateSetting (or templaceContentId) to use a content for rendering email -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4333) Refactoring send email engine
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4333: --------------------------------- Attachment: (was: OFBIZ-4322.patch) > Refactoring send email engine > ----------------------------- > > Key: OFBIZ-4333 > URL: https://issues.apache.org/jira/browse/OFBIZ-4333 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, content, framework > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Labels: content, mail, notification > Fix For: SVN trunk > > Attachments: OFBIZ-4333.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > In OFBiz history, the first entity used was ProductStoreEmailSetting, for automatic email during ecommerce process and in last time the EmailTemplateSetting for specific notification. > Both entities have the same field : bodyScreenLocation, xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject, contentType. Just primary key are differents. > To simplify the notification system, I will suggest : > * use only EmailTemplateSetting to edit email configuration > * associate ProductStoreEmailSetting to EmailTemplateSetting > * convert all service and screen that use ProductStoreEmailSetting > * create convert service. > * add contentId on EmailTemplateSetting (or templaceContentId) to use a content for rendering email -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4333) Refactoring send email engine
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061241#comment-13061241 ] BJ Freeman commented on OFBIZ-4333: ----------------------------------- there is a Jira open already https://issues.apache.org/jira/browse/OFBIZ-3894 > Refactoring send email engine > ----------------------------- > > Key: OFBIZ-4333 > URL: https://issues.apache.org/jira/browse/OFBIZ-4333 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, content, framework > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Labels: content, mail, notification > Fix For: SVN trunk > > Attachments: OFBIZ-4333.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > In OFBiz history, the first entity used was ProductStoreEmailSetting, for automatic email during ecommerce process and in last time the EmailTemplateSetting for specific notification. > Both entities have the same field : bodyScreenLocation, xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject, contentType. Just primary key are differents. > To simplify the notification system, I will suggest : > * use only EmailTemplateSetting to edit email configuration > * associate ProductStoreEmailSetting to EmailTemplateSetting > * convert all service and screen that use ProductStoreEmailSetting > * create convert service. > * add contentId on EmailTemplateSetting (or templaceContentId) to use a content for rendering email -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Resolved] (OFBIZ-4333) Refactoring send email engine
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin resolved OFBIZ-4333. ---------------------------------- Resolution: Duplicate Issue exist : OFBIZ-3894 > Refactoring send email engine > ----------------------------- > > Key: OFBIZ-4333 > URL: https://issues.apache.org/jira/browse/OFBIZ-4333 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, content, framework > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Labels: content, mail, notification > Fix For: SVN trunk > > Attachments: OFBIZ-4333.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > In OFBiz history, the first entity used was ProductStoreEmailSetting, for automatic email during ecommerce process and in last time the EmailTemplateSetting for specific notification. > Both entities have the same field : bodyScreenLocation, xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject, contentType. Just primary key are differents. > To simplify the notification system, I will suggest : > * use only EmailTemplateSetting to edit email configuration > * associate ProductStoreEmailSetting to EmailTemplateSetting > * convert all service and screen that use ProductStoreEmailSetting > * create convert service. > * add contentId on EmailTemplateSetting (or templaceContentId) to use a content for rendering email -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Closed] (OFBIZ-4333) Refactoring send email engine
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-4333. ------------------------------------ > Refactoring send email engine > ----------------------------- > > Key: OFBIZ-4333 > URL: https://issues.apache.org/jira/browse/OFBIZ-4333 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, content, framework > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Labels: content, mail, notification > Fix For: SVN trunk > > Attachments: OFBIZ-4333.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > In OFBiz history, the first entity used was ProductStoreEmailSetting, for automatic email during ecommerce process and in last time the EmailTemplateSetting for specific notification. > Both entities have the same field : bodyScreenLocation, xslfoAttachScreenLocation, fromAddress, ccAddress, bccAddress, subject, contentType. Just primary key are differents. > To simplify the notification system, I will suggest : > * use only EmailTemplateSetting to edit email configuration > * associate ProductStoreEmailSetting to EmailTemplateSetting > * convert all service and screen that use ProductStoreEmailSetting > * create convert service. > * add contentId on EmailTemplateSetting (or templaceContentId) to use a content for rendering email -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |