Static text for reports at the ordermanager replaced by labels
-------------------------------------------------------------- Key: OFBIZ-4351 URL: https://issues.apache.org/jira/browse/OFBIZ-4351 Project: OFBiz Issue Type: Improvement Reporter: Christian Fischer Attachments: AccountingUiLabels.xml.patch, OrderUiLabels.xml.patch, ReportForms.xml.patch, ReportScreens.xml.patch Patch includes AccountinguiLabels (one missing translation) OrderUiLabels (added missing labels for the reports) and of course the edited ReportForms and ReportScreens -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ https://issues.apache.org/jira/browse/OFBIZ-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Fischer updated OFBIZ-4351: ------------------------------------- Attachment: ReportScreens.xml.patch ReportForms.xml.patch OrderUiLabels.xml.patch AccountingUiLabels.xml.patch > Static text for reports at the ordermanager replaced by labels > -------------------------------------------------------------- > > Key: OFBIZ-4351 > URL: https://issues.apache.org/jira/browse/OFBIZ-4351 > Project: OFBiz > Issue Type: Improvement > Reporter: Christian Fischer > Attachments: AccountingUiLabels.xml.patch, OrderUiLabels.xml.patch, ReportForms.xml.patch, ReportScreens.xml.patch > > > Patch includes > AccountinguiLabels (one missing translation) > OrderUiLabels (added missing labels for the reports) > and of course the edited ReportForms and ReportScreens -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-4351: ------------------------------------ Assignee: Jacques Le Roux > Static text for reports at the ordermanager replaced by labels > -------------------------------------------------------------- > > Key: OFBIZ-4351 > URL: https://issues.apache.org/jira/browse/OFBIZ-4351 > Project: OFBiz > Issue Type: Improvement > Reporter: Christian Fischer > Assignee: Jacques Le Roux > Attachments: AccountingUiLabels.xml.patch, OrderUiLabels.xml.patch, ReportForms.xml.patch, ReportScreens.xml.patch > > > Patch includes > AccountinguiLabels (one missing translation) > OrderUiLabels (added missing labels for the reports) > and of course the edited ReportForms and ReportScreens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184838#comment-13184838 ] Jacques Le Roux commented on OFBIZ-4351: ---------------------------------------- Hi Christian, This is great but: # don't put as Resolved status (done for us) rather Provide Patch (waiting review) # AccountingUiLabels.xml.patch and OrderUiLabels.xml.patch are useless (already applied or maybe rather missing your real additions) # So from point2 the Report patches seems good but are missing new labels (maybe not all, but some for sure) Could you please check? Thanks > Static text for reports at the ordermanager replaced by labels > -------------------------------------------------------------- > > Key: OFBIZ-4351 > URL: https://issues.apache.org/jira/browse/OFBIZ-4351 > Project: OFBiz > Issue Type: Improvement > Reporter: Christian Fischer > Assignee: Jacques Le Roux > Attachments: AccountingUiLabels.xml.patch, OrderUiLabels.xml.patch, ReportForms.xml.patch, ReportScreens.xml.patch > > > Patch includes > AccountinguiLabels (one missing translation) > OrderUiLabels (added missing labels for the reports) > and of course the edited ReportForms and ReportScreens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184872#comment-13184872 ] Christian Fischer commented on OFBIZ-4351: ------------------------------------------ Hello Jacques 1. Sorry for that, I was new and thought, that it was the right status. Won't happen again. 2. They are pretty old and had only minor translations. These translations were necassary for a project and after we finished it, I comitted these changes. Maybe in the last 5 months, someone updated the labels. 3. I compared the ReportForms/Screens with the revision from 5 months ago and it looks like this is indeed the complete patch. Like I said before, this is a little patch. Also, by the time I created the patch, there wasn't that much static text left. I hope this answers your question. Regards, Christian > Static text for reports at the ordermanager replaced by labels > -------------------------------------------------------------- > > Key: OFBIZ-4351 > URL: https://issues.apache.org/jira/browse/OFBIZ-4351 > Project: OFBiz > Issue Type: Improvement > Reporter: Christian Fischer > Assignee: Jacques Le Roux > Attachments: AccountingUiLabels.xml.patch, OrderUiLabels.xml.patch, ReportForms.xml.patch, ReportScreens.xml.patch > > > Patch includes > AccountinguiLabels (one missing translation) > OrderUiLabels (added missing labels for the reports) > and of course the edited ReportForms and ReportScreens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184878#comment-13184878 ] Jacques Le Roux commented on OFBIZ-4351: ---------------------------------------- Christian, # No worries ;) # You can forget about those 2 patches, see below # My point is that you use some labels in you patches which are not in OFBiz OOBT, like OrderAllReferrer OrderSaleChannel OrderAllDiscount OrderSalesReport OrderNetBeforeOverheadReport OrderProductDemandReport OrderSaleOrdersByReferrerReport .... So if you want these 2 patches to be applied, we need the corresponding labels (check your patches for the complete list) # Also you should remove comments like <!-- MOD CF 22.07.11 Festen Titel durch Label ersetzt --> in your patch > Static text for reports at the ordermanager replaced by labels > -------------------------------------------------------------- > > Key: OFBIZ-4351 > URL: https://issues.apache.org/jira/browse/OFBIZ-4351 > Project: OFBiz > Issue Type: Improvement > Reporter: Christian Fischer > Assignee: Jacques Le Roux > Attachments: AccountingUiLabels.xml.patch, OrderUiLabels.xml.patch, ReportForms.xml.patch, ReportScreens.xml.patch > > > Patch includes > AccountinguiLabels (one missing translation) > OrderUiLabels (added missing labels for the reports) > and of course the edited ReportForms and ReportScreens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184887#comment-13184887 ] Christian Fischer commented on OFBIZ-4351: ------------------------------------------ 3. I see, I will deal with it later and upload the updated labels. 4. Yeah, beginner's mistake :D > Static text for reports at the ordermanager replaced by labels > -------------------------------------------------------------- > > Key: OFBIZ-4351 > URL: https://issues.apache.org/jira/browse/OFBIZ-4351 > Project: OFBiz > Issue Type: Improvement > Reporter: Christian Fischer > Assignee: Jacques Le Roux > Attachments: AccountingUiLabels.xml.patch, OrderUiLabels.xml.patch, ReportForms.xml.patch, ReportScreens.xml.patch > > > Patch includes > AccountinguiLabels (one missing translation) > OrderUiLabels (added missing labels for the reports) > and of course the edited ReportForms and ReportScreens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253789#comment-13253789 ] Jacques Le Roux commented on OFBIZ-4351: ---------------------------------------- Ping (before closing) > Static text for reports at the ordermanager replaced by labels > -------------------------------------------------------------- > > Key: OFBIZ-4351 > URL: https://issues.apache.org/jira/browse/OFBIZ-4351 > Project: OFBiz > Issue Type: Improvement > Reporter: Christian Fischer > Assignee: Jacques Le Roux > Attachments: AccountingUiLabels.xml.patch, OrderUiLabels.xml.patch, ReportForms.xml.patch, ReportScreens.xml.patch > > > Patch includes > AccountinguiLabels (one missing translation) > OrderUiLabels (added missing labels for the reports) > and of course the edited ReportForms and ReportScreens -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |