[jira] Created: (OFBIZ-438) setInvoiceStatus not updating invoice.paidDate
Locked
[jira] Created: (OFBIZ-438) setInvoiceStatus not updating invoice.paidDate
 
|
setInvoiceStatus not updating invoice.paidDate
----------------------------------------------- Key: OFBIZ-438 URL: http://issues.apache.org/jira/browse/OFBIZ-438 Project: OFBiz (The Open for Business Project) Issue Type: Bug Components: accounting Reporter: Si Chen setInvoiceStatus currently is not setting Invoice.paidDate if the invoice status is being set to PAID but there is no paidDate supplied in the parameter. Invoices are being marked PAID because checkInvoicePaymentApplication will supply a paidDate parameter based on the Payments applied to invoice. The change would be to modify setInvoiceStatus so that IF statusId = INVOICE_PAID and parameters.paidDate is null (empty), then set paidDate to current timestamp -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Assigned: (OFBIZ-438) setInvoiceStatus not updating invoice.paidDate
|
|
[ http://issues.apache.org/jira/browse/OFBIZ-438?page=all ]
Si Chen reassigned OFBIZ-438: ----------------------------- Assignee: Si Chen > setInvoiceStatus not updating invoice.paidDate > ---------------------------------------------- > > Key: OFBIZ-438 > URL: http://issues.apache.org/jira/browse/OFBIZ-438 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Si Chen > Assigned To: Si Chen > > setInvoiceStatus currently is not setting Invoice.paidDate if the invoice status is being set to PAID but there is no paidDate supplied in the parameter. Invoices are being marked PAID because checkInvoicePaymentApplication will supply a paidDate parameter based on the Payments applied to invoice. > The change would be to modify setInvoiceStatus so that IF statusId = INVOICE_PAID and parameters.paidDate is null (empty), then set paidDate to current timestamp -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-438) setInvoiceStatus not updating invoice.paidDate
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-438?page=comments#action_12448909 ]
Si Chen commented on OFBIZ-438: ------------------------------- What does this block do? + + <if-not-empty field-name="parameters.paidDate"> + <if-compare field-name="parameters.statusId" operator="equals" value="INVOICE_READY"> + <clear-field field-name="invoice.paidDate" /> + </if-compare> + </if-not-empty> + > setInvoiceStatus not updating invoice.paidDate > ---------------------------------------------- > > Key: OFBIZ-438 > URL: http://issues.apache.org/jira/browse/OFBIZ-438 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Si Chen > Assigned To: Si Chen > > setInvoiceStatus currently is not setting Invoice.paidDate if the invoice status is being set to PAID but there is no paidDate supplied in the parameter. Invoices are being marked PAID because checkInvoicePaymentApplication will supply a paidDate parameter based on the Payments applied to invoice. > The change would be to modify setInvoiceStatus so that IF statusId = INVOICE_PAID and parameters.paidDate is null (empty), then set paidDate to current timestamp -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-438) setInvoiceStatus not updating invoice.paidDate
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-438?page=comments#action_12448912 ]
Ashish Vijaywargiya commented on OFBIZ-438: ------------------------------------------- Si, I added this condition to clear out the paidDate field of the invoice entity. This condition will run when paidDate exists and we are changing the status from INVOICE_PAID into INVOICE_READY. In the InvoiceServices.xml we are setting the status to "INVOICE_READY" and calling the service "setInvoiceStatus". Is there any better way in your mind to clear out paid date ??? Regards Ashish Vijaywargiya > setInvoiceStatus not updating invoice.paidDate > ---------------------------------------------- > > Key: OFBIZ-438 > URL: http://issues.apache.org/jira/browse/OFBIZ-438 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Si Chen > Assigned To: Si Chen > > setInvoiceStatus currently is not setting Invoice.paidDate if the invoice status is being set to PAID but there is no paidDate supplied in the parameter. Invoices are being marked PAID because checkInvoicePaymentApplication will supply a paidDate parameter based on the Payments applied to invoice. > The change would be to modify setInvoiceStatus so that IF statusId = INVOICE_PAID and parameters.paidDate is null (empty), then set paidDate to current timestamp -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Commented: (OFBIZ-438) setInvoiceStatus not updating invoice.paidDate
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-438?page=comments#action_12448914 ]
Si Chen commented on OFBIZ-438: ------------------------------- In that case, why do you need the <if-not-empty field-name="parameters.paidDate">? It should be "invoice.paidDate" right? Otherwise, if I try to set the invoice to READY but don't supply a paidDate parameter, you won't be clearing the invoice's paidDate. > setInvoiceStatus not updating invoice.paidDate > ---------------------------------------------- > > Key: OFBIZ-438 > URL: http://issues.apache.org/jira/browse/OFBIZ-438 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Si Chen > Assigned To: Si Chen > > setInvoiceStatus currently is not setting Invoice.paidDate if the invoice status is being set to PAID but there is no paidDate supplied in the parameter. Invoices are being marked PAID because checkInvoicePaymentApplication will supply a paidDate parameter based on the Payments applied to invoice. > The change would be to modify setInvoiceStatus so that IF statusId = INVOICE_PAID and parameters.paidDate is null (empty), then set paidDate to current timestamp -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Updated: (OFBIZ-438) setInvoiceStatus not updating invoice.paidDate
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-438?page=all ]
Ashish Vijaywargiya updated OFBIZ-438: -------------------------------------- Attachment: SwitchInvoice_Nov_13.patch Si, Here is the patch for Ofbiz-433 & Ofbiz-438 which resolves all of your comments. Regards Ashish Vijaywargiya > setInvoiceStatus not updating invoice.paidDate > ---------------------------------------------- > > Key: OFBIZ-438 > URL: http://issues.apache.org/jira/browse/OFBIZ-438 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Si Chen > Assigned To: Si Chen > Attachments: SwitchInvoice_Nov_13.patch > > > setInvoiceStatus currently is not setting Invoice.paidDate if the invoice status is being set to PAID but there is no paidDate supplied in the parameter. Invoices are being marked PAID because checkInvoicePaymentApplication will supply a paidDate parameter based on the Payments applied to invoice. > The change would be to modify setInvoiceStatus so that IF statusId = INVOICE_PAID and parameters.paidDate is null (empty), then set paidDate to current timestamp -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] Closed: (OFBIZ-438) setInvoiceStatus not updating invoice.paidDate
|
|
In reply to this post by Nicolas Malin (Jira)
[ http://issues.apache.org/jira/browse/OFBIZ-438?page=all ]
Si Chen closed OFBIZ-438. ------------------------- Resolution: Fixed > setInvoiceStatus not updating invoice.paidDate > ---------------------------------------------- > > Key: OFBIZ-438 > URL: http://issues.apache.org/jira/browse/OFBIZ-438 > Project: OFBiz (The Open for Business Project) > Issue Type: Bug > Components: accounting > Reporter: Si Chen > Assigned To: Si Chen > Attachments: SwitchInvoice_Nov_13.patch > > > setInvoiceStatus currently is not setting Invoice.paidDate if the invoice status is being set to PAID but there is no paidDate supplied in the parameter. Invoices are being marked PAID because checkInvoicePaymentApplication will supply a paidDate parameter based on the Payments applied to invoice. > The change would be to modify setInvoiceStatus so that IF statusId = INVOICE_PAID and parameters.paidDate is null (empty), then set paidDate to current timestamp -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |