[jira] Created: (OFBIZ-444) add a while-compare operation to minilang

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12449182 ]
           
Scott Gray commented on OFBIZ-444:
----------------------------------

Thanks for the feedback Jacques, I'll wait to hear from David (no rush), but am more than happy to change anything that isn't suitable

Regards
Scott

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: test.patch, while-compare.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-444?page=all ]

David E. Jones updated OFBIZ-444:
---------------------------------

    Attachment:     (was: while-compare.patch)

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: test.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-444?page=all ]

David E. Jones closed OFBIZ-444.
--------------------------------

    Resolution: Fixed

Thanks Scott, this looks good. You did a good job of reusing the code and XSD elements from the if operation, minimizing the changes needed to implement this, and that's perfect for this circumstance. The only change I made was to simplify the while loop a bit in the While.java file so that it is a bit more direct.

The changes are in SVN rev 474048.

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: test.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12449189 ]
           
Scott Gray commented on OFBIZ-444:
----------------------------------

Thanks David, your code looks much better.  I think I was still in the while-compare mindset which required more coding for the condition.  I was surprised how easy the minilang is to code, the design is fantastic.

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: test.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12449265 ]
           
Jacques Le Roux commented on OFBIZ-444:
---------------------------------------

Scott,

I apologize about my last comment, it's not true, please see https://issues.apache.org/jira/browse/OFBIZ-450#action_12449263

Thanks

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: test.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira