[jira] [Created] (OFBIZ-4516) OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-4516) OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice

Nicolas Malin (Jira)
OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice
------------------------------------------------------------------------------------

                 Key: OFBIZ-4516
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4516
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Martin Kreidenweis


When we already created an invoice for an order and we want to change the order (e.g. cancel items from the order), we might want to cancel the whole invoice and create a new one.

This does not work as expected: For the new invoice the invoice items that already were in the old invoice are not created with the right quantities any more.

What we expect would be that while creating the new invoice the canceled invoice is ignored when checking if the OrderItems have already been invoiced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4516) OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Kreidenweis updated OFBIZ-4516:
--------------------------------------

    Attachment: OFBIZ-4516.patch

Patch: resetting amount/quantity in OrderItemBilling and OrderAdjustmentBilling on invoice cancelation
* this causes order items and order adjustments to be invoiced again by the ofbiz createInvoiceForOrder service
** (this service checks the quantity in OrderItemBilling and the amount in OrderAdjustmentBilling when creating new invoice items)
* for OrderItemBilling just the quantity is set to 0, not the amount, as these two are always multiplied with each other
* for OrderAdjustmentBilling the amount is set to 0
               

> OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4516
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4516
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Martin Kreidenweis
>         Attachments: OFBIZ-4516.patch
>
>
> When we already created an invoice for an order and we want to change the order (e.g. cancel items from the order), we might want to cancel the whole invoice and create a new one.
> This does not work as expected: For the new invoice the invoice items that already were in the old invoice are not created with the right quantities any more.
> What we expect would be that while creating the new invoice the canceled invoice is ignored when checking if the OrderItems have already been invoiced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Assigned] (OFBIZ-4516) OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-4516:
-----------------------------------

    Assignee: Anil K Patel
   

> OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4516
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4516
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Martin Kreidenweis
>            Assignee: Anil K Patel
>         Attachments: OFBIZ-4516.patch
>
>
> When we already created an invoice for an order and we want to change the order (e.g. cancel items from the order), we might want to cancel the whole invoice and create a new one.
> This does not work as expected: For the new invoice the invoice items that already were in the old invoice are not created with the right quantities any more.
> What we expect would be that while creating the new invoice the canceled invoice is ignored when checking if the OrderItems have already been invoiced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (OFBIZ-4516) OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel resolved OFBIZ-4516.
---------------------------------

    Resolution: Fixed

Fix applied to Ofbiz r1189601. Martin, Thanks for contribution.
               

> OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4516
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4516
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Martin Kreidenweis
>            Assignee: Anil K Patel
>         Attachments: OFBIZ-4516.patch
>
>
> When we already created an invoice for an order and we want to change the order (e.g. cancel items from the order), we might want to cancel the whole invoice and create a new one.
> This does not work as expected: For the new invoice the invoice items that already were in the old invoice are not created with the right quantities any more.
> What we expect would be that while creating the new invoice the canceled invoice is ignored when checking if the OrderItems have already been invoiced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-4516) OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel closed OFBIZ-4516.
-------------------------------

   

> OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4516
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4516
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Martin Kreidenweis
>            Assignee: Anil K Patel
>         Attachments: OFBIZ-4516.patch
>
>
> When we already created an invoice for an order and we want to change the order (e.g. cancel items from the order), we might want to cancel the whole invoice and create a new one.
> This does not work as expected: For the new invoice the invoice items that already were in the old invoice are not created with the right quantities any more.
> What we expect would be that while creating the new invoice the canceled invoice is ignored when checking if the OrderItems have already been invoiced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4516) OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136763#comment-13136763 ]

Anil K Patel commented on OFBIZ-4516:
-------------------------------------

Next logical step will be to provide action for creating new invoice on Order View page. May be some other day :)
               

> OrderItemBilling and OrderAdjustmentBilling are not reset when cancelling an invoice
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4516
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4516
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Martin Kreidenweis
>            Assignee: Anil K Patel
>         Attachments: OFBIZ-4516.patch
>
>
> When we already created an invoice for an order and we want to change the order (e.g. cancel items from the order), we might want to cancel the whole invoice and create a new one.
> This does not work as expected: For the new invoice the invoice items that already were in the old invoice are not created with the right quantities any more.
> What we expect would be that while creating the new invoice the canceled invoice is ignored when checking if the OrderItems have already been invoiced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira