[jira] Created: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
21 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
Invoice item sequence ids are ordered alphabetically, not numerically
---------------------------------------------------------------------

                 Key: OFBIZ-456
                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: accounting
            Reporter: Iain Fogg
            Priority: Minor


Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.

I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12450759 ]
           
Jacopo Cappellato commented on OFBIZ-456:
-----------------------------------------

Iain,

that's odd and I don't know why it's happening; in fact the format of the order items should be 00001, 00002 etc...

as you can see from here:

https://demo.dejc.com:8443/webtools/control/FindGeneric?entityName=InvoiceItem&find=true&VIEW_SIZE=50&VIEW_INDEX=0


> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12450793 ]
           
Iain Fogg commented on OFBIZ-456:
---------------------------------

Very strange. I just double checked, and all my invoices (sales and purchase) do not have 5 significant digits as your example does. I ahve not knowingly made any changes to any apps that could affect this.

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-456?page=all ]

Si Chen reassigned OFBIZ-456:
-----------------------------

    Assignee: Si Chen

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12450799 ]
           
Si Chen commented on OFBIZ-456:
-------------------------------

can you send a screenshot?

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

Oracle OdbcPackageIn "not found"

Chandresh Turakhia
In reply to this post by Nicolas Malin (Jira)
hi ,

do I need to something for these warnings.... or change / add something in
the mappings.

chand
===

2006-11-17 10:56:04,578 (main) [   GenericDelegator.java:148:WARN ]
=-=-=-=-= Found 53 warnings when checking the entity definitions:
2006-11-17 10:56:04,578 (main) [   GenericDelegator.java:152:WARN ]
[HelperNotFound] No Helper (DataSource) definition found for entity
OdbcPackageIn.
2006-11-17 10:56:04,578 (main) [   GenericDelegator.java:152:WARN ]
[FieldTypeNotFound] Field type id-ne of entity OdbcPackageIn not found in
field type definitions (no helper definition found).
2006-11-17 10:56:04,578 (main) [   GenericDelegator.java:152:WARN ]
[FieldTypeNotFound] Field type id-ne of entity OdbcPackageIn not found in
field type definitions (no helper definition found).
2006-11-17 10:56:04,578 (main) [   GenericDelegator.java:152:WARN ]
[FieldTypeNotFound] Field type id-ne of entity OdbcPackageIn not found in
field type definitions (no helper definition found).


Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12450940 ]
           
Iain Fogg commented on OFBIZ-456:
---------------------------------

I just attached the screenshot

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

Re: Oracle OdbcPackageIn "not found"

David E Jones-2
In reply to this post by Chandresh Turakhia

Take a look at the Entity Engine Configuration guide for general stuff.

In particular it sounds like you don't have a group mapping in your  
delegator definition for the "org.ofbiz.odbc" group of entities.

-David


On Nov 17, 2006, at 12:02 PM, Chandresh Turakhia wrote:

> hi ,
>
> do I need to something for these warnings.... or change / add  
> something in the mappings.
>
> chand
> ===
>
> 2006-11-17 10:56:04,578 (main) [   GenericDelegator.java:148:WARN ]  
> =-=-=-=-= Found 53 warnings when checking the entity definitions:
> 2006-11-17 10:56:04,578 (main) [   GenericDelegator.java:152:WARN ]  
> [HelperNotFound] No Helper (DataSource) definition found for entity  
> OdbcPackageIn.
> 2006-11-17 10:56:04,578 (main) [   GenericDelegator.java:152:WARN ]  
> [FieldTypeNotFound] Field type id-ne of entity OdbcPackageIn not  
> found in field type definitions (no helper definition found).
> 2006-11-17 10:56:04,578 (main) [   GenericDelegator.java:152:WARN ]  
> [FieldTypeNotFound] Field type id-ne of entity OdbcPackageIn not  
> found in field type definitions (no helper definition found).
> 2006-11-17 10:56:04,578 (main) [   GenericDelegator.java:152:WARN ]  
> [FieldTypeNotFound] Field type id-ne of entity OdbcPackageIn not  
> found in field type definitions (no helper definition found).
>
>

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12450945 ]
           
David E. Jones commented on OFBIZ-456:
--------------------------------------

Hmmm... I don't see any screen shot... try attaching it as a file. I think there is something screwy with the screenshot stuff.

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12456720 ]
           
Jacopo Cappellato commented on OFBIZ-456:
-----------------------------------------

Iain,

are you still having this issue or can we now close it?
If the issue is already there, could you please attach a screenshot (as a file, as suggested by David)?

Thanks

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12457012 ]
           
Iain Fogg commented on OFBIZ-456:
---------------------------------

Jacopo,

Yes, the issue is still there. I'll try to get to the screen shot asap,
but I'm completely snowed under with work at the moment. Fortunately,
this is just a minor annoyance.

Cheers, Iain




--
No virus found in this outgoing message.
Checked by AVG Free Edition.
Version: 7.1.409 / Virus Database: 268.15.15/580 - Release Date: 8/12/2006



> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459167 ]
           
Chris Howe commented on OFBIZ-456:
----------------------------------

The demo shows correctly because it comes from demo data.  

Most invoices are created by the service createInvoiceForOrder.  This calls the java method InvoiceServices.createInvoiceForOrder.  This java method sets the padding on line 357:

String invoiceItemSeqId = UtilFormatOut.formatPaddedNumber(invoiceItemSeqNum, 2);

There are a couple more instances which set the padding in this method
1) for the incremented sequence num : line 475
2) for the adjusments: line 536

I would offer a patch for this, however I'm not sure if you would want to send invoiceItemSeqNum to the service createInvoiceItem instead of the invoiceItemSeqId and let the service deal with the padding or if you would just want to change the padding settings in these lines.  Either way, those who have deployments will be affected by the change of padding as reports containing old data may not render consistantly without updating all instances of invoiceItemSeqId already in their database.  IMO, This issue should resolve that instance as well.


> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459203 ]
           
Jacopo Cappellato commented on OFBIZ-456:
-----------------------------------------

I think that Chris has found the root of the problem that Iain is having (thanks).
However I still don't understand why in the demo data  the creation of a new invoice is leading to the 00001, 00002 etc... result...
About the backward compatibility issue: I don't know but maybe it is not so important in this case since the items in older invoices will be numbed as 01, 02, 03 and the items in new ones will be numbered 00001, 00002... I don't see big issues with this (but I could be wrong).


> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459214 ]
           
Chris Howe commented on OFBIZ-456:
----------------------------------

The demo data is imported using the complete entity record (accounting/data/PaymentsInvoices.xml) which contains a 5 place padded invoiceItemSeqId.  That data gets entered without utilizing the service that gets called when an order changes status to "Completed" and an invoice is created.

Backward Compatibility: It's not a big issue, but does need to be considered before closing this issue.  Iain discovered this issue obviously because his report is listing invoiceItemSeqId 100 before it lists invoiceItemSeqId 2.  As I see it there are a few options:

1) change the method that is gathering the information for the report in question to convert the string to an integer
2) create a service that will update all fields of *.invoiceItemSeqId to the correct padding
3) ignore the issue

I would prefer Iain say that it doesn't need to be addressed.   It's not an encouragement for people to report bugs if they have the impression that they will need  to develop a personal solution anyway.   For someone that has invoices that have 100+ invoice line items I suspect he'll be finding extreme use case bugs more often than the rest of us.  Better for all of us that he feel encouraged to report them than have all of us get hit with the bugs when we reach that level of usage.

In any case, which fix would you prefer?
1) changing the individual lines in the java method
2) removing the padding  from the java method and letting the service handle it

1 is the quickest, but 2 allows for a centralized place

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459269 ]
           
Iain Fogg commented on OFBIZ-456:
---------------------------------

Chris/Jacopo,

Many thanks for keeping this on the radar.

From my perspective, having future invoices not exhibit the behaviour is fine (ie, no need to invest any effort in tweaking existing invoices).

Re: the suggested solutions, I suspect I'd vote for #2. The reason is slightly obtuse. I very frequently have to make invoice adjustments, especially for Purchase Orders. This is to account for slight price differences that arise on the system generated invoices, compared to the suppliers (definitive) invoice. I also need to adjust the OFBiz invoices for GST.

For all these adjustments, I need to add new invoice items, and currently I have to be careful to include the 0 padding to ensure the new items end up in the right sequence. For example, if I have 8 items on the invoice, I need to specify a seq # of 09 for the new one. This is OK, but if we change the default 2-padding to (say) 5-padding, it becomes a pain to enter all those padding 0's. If I can just specify the significant digits (eg, 9) and let the system work out how to store this information and display, then that makes it easy for me.

Cheers, Iain

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459278 ]
           
Jacopo Cappellato commented on OFBIZ-456:
-----------------------------------------

I personally would opt for the first solution (changing the padding from 2 to 5 digits in individual lines in the java method).

And yes, I can confirm that Chris is correct... newly created invoice items are created with two digits (still I'm wondering what kind of ugly tests I did some time ago :-(

Backward compatibility: I think we could ignore the (minor) backward issue in this case (changing old order items could cause problems since they are in the pk and also there could be company that don't like this solution).

If we can quickly add support for +100 items in invoices (as is here) I think we should go for the change... even if this is something that it will not happen in my deployment or the ones of my customers.

Iain: about your last requirement (i.e. keeping the adjustments 'near' the invoice items to which they are applied) I'd say that, it would be better if you handle it in the report (maybe with custom code); in fact it should be easy to accomplish since the InvoiceItems of type 'adjustment' are associated to the parent InvoiceItem thru the PARENT_INVOICE_ID and PARENT_INVOICE_ITEM_SEQ_ID fields.


> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459331 ]
           
Iain Fogg commented on OFBIZ-456:
---------------------------------

Jacopo,

To clarify, I rarely make ITEM adjustments to my invoices - almost always invoice-level adjustments - so I don't need the manual adjustments to be in any sort of close proximity,

The only (small) improvement I was looking for was to minimise the amount of typing I need to do to add the adjustments - if I can type "9" instead of "00009", then it makes adding items a bit easier (actually it would be better to not have to specify the seq # at all when I am adding a new one, but I seem to recall this is a required param - not sure why, other than making the implementation slightly easier).

I should stress, this is NOT a big deal - if I have to type some leading 0's, I'm not going to be too concerned... The key thing is to support invoices with hundreds of line items and get them displayed in sequence.

Cheers, Iain

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459358 ]
           
Chris Howe commented on OFBIZ-456:
----------------------------------

Iain,

The proposed #2 solution would not help in this regard.  Your lookup/update won't be calling the createInvoiceitem to benefit.  However, it should be fairly small work to take care of your concern.  What screen are you playing with that's requiring the correct pattern for search?

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459480 ]
           
Iain Fogg commented on OFBIZ-456:
---------------------------------

Chris,

It's the "Items" screen of the Invoice. Whenever you fill in the form at the bottom of the screen you have to explicitly enter the sequence number, even if it's a brand new item. Having this field makes sense if you "Update" an existing item, but it would be better to leave it blank and let the system work out the next seq number if you are adding a new one.

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-456?page=comments#action_12459571 ]
           
Jacopo Cappellato commented on OFBIZ-456:
-----------------------------------------

Iain,

in that screen you can just leave empty the Item No field and the next available sequence id will be used.


> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Si Chen
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
12