[jira] [Created] (OFBIZ-4602) Null values are not synchronized in http mode

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200818#comment-13200818 ]

Jacques Le Roux commented on OFBIZ-4602:
----------------------------------------

Hi Divesh,

Sure, I'm looking at it...
               

> Null values are not synchronized in http mode
> ---------------------------------------------
>
>                 Key: OFBIZ-4602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Using entity synchronization over HTTP (not RMI)
>            Reporter: Patrick Antivackis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200820#comment-13200820 ]

Jacques Le Roux commented on OFBIZ-4602:
----------------------------------------

Paul,

Thanks to mention the nillable possiblity. Actually, for 2 weeks, I'm considering to use it also in another case but have still to test the changes I did in ModelService.getTypes(). This other case is not directly related. It's when you use an exported service (SOAP) which may return null elements (in my case a list of maps where some elements may be null). When you try to unmarshall the SOAP response from CXF side you get an error like
{code}
Unmarshalling Error: unexpected element (uri:"http://ofbiz.apache.org/service/", local:"null")
{code}
As soon as I will have fixed this, I hope to have a better experience of setting nillable attributes and I will consider to use it also in the case at hand.

----
Divesh,

So it's a WIP and I don't want to revert anything for now. If you have an issue with your production system and have not yet reverted the 2 changes above then you may consider to do it in the meantime. Of course, I expect to fix that soon (this week) ... Sorry for the inconvenient...
               

> Null values are not synchronized in http mode
> ---------------------------------------------
>
>                 Key: OFBIZ-4602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Using entity synchronization over HTTP (not RMI)
>            Reporter: Patrick Antivackis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206083#comment-13206083 ]

Jacques Le Roux commented on OFBIZ-4602:
----------------------------------------

At [r1243026|http://svn.apache.org/viewvc?view=revision&revision=1243026] I introduced the use of the xsi:nil attribute.

More to come, but unfortunately not this week I think...
               

> Null values are not synchronized in http mode
> ---------------------------------------------
>
>                 Key: OFBIZ-4602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Using entity synchronization over HTTP (not RMI)
>            Reporter: Patrick Antivackis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207278#comment-13207278 ]

Alexander Reelsen commented on OFBIZ-4602:
------------------------------------------

Hi

some parts of this patch seem to have broken services in the job_sandbox. Suddenly the runtime_data entity with its XML based runtimeInfo field is filled with tons of entity values called foo="[null-field]" which are not serialized back into null, but rather is written as "[null-field]" into the database. Not too cool to cleanup...


--Alexander
               

> Null values are not synchronized in http mode
> ---------------------------------------------
>
>                 Key: OFBIZ-4602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Using entity synchronization over HTTP (not RMI)
>            Reporter: Patrick Antivackis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207559#comment-13207559 ]

Jacques Le Roux commented on OFBIZ-4602:
----------------------------------------

Thanks for repor Alexander,

Unfortunately I don't expect to have a new look before this weekend. Reverting all from start seems the easier way. But I hope to rather follow the same way I did in r1243026 (which is only related to web services and not general)
               

> Null values are not synchronized in http mode
> ---------------------------------------------
>
>                 Key: OFBIZ-4602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Using entity synchronization over HTTP (not RMI)
>            Reporter: Patrick Antivackis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216812#comment-13216812 ]

Jacques Le Roux commented on OFBIZ-4602:
----------------------------------------

OK, I did not get enough time to completly look at it yet. But I doubt using simply an xsi:nil attribute will solve the problem. Because nullFied (and "[null-field]") has been introduced because of issues with null in (at least) Freemarker...

I believe the issue I crossed and reported above, has actually been solved by r1226065.

Divesh, did you test if the same (r1226065) solved your issue?
               

> Null values are not synchronized in http mode
> ---------------------------------------------
>
>                 Key: OFBIZ-4602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Using entity synchronization over HTTP (not RMI)
>            Reporter: Patrick Antivackis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216813#comment-13216813 ]

Jacques Le Roux commented on OFBIZ-4602:
----------------------------------------

I let some links here for future possible work:
https://fisheye6.atlassian.com/changelog/ofbiz?cs=1222241
https://fisheye6.atlassian.com/changelog/ofbiz?cs=1226065
https://fisheye6.atlassian.com/changelog/ofbiz?cs=1243026
               

> Null values are not synchronized in http mode
> ---------------------------------------------
>
>                 Key: OFBIZ-4602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Using entity synchronization over HTTP (not RMI)
>            Reporter: Patrick Antivackis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222261#comment-13222261 ]

Nicolas Malin commented on OFBIZ-4602:
--------------------------------------

Hi Jacques,

I tested the entity-sync process, and I confirm the [null-field] break it when an entity field is an other type that String.
I not solve it, I will check it if I need implement the entity-sync.
               

> Null values are not synchronized in http mode
> ---------------------------------------------
>
>                 Key: OFBIZ-4602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Using entity synchronization over HTTP (not RMI)
>            Reporter: Patrick Antivackis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264599#comment-13264599 ]

Jacques Le Roux commented on OFBIZ-4602:
----------------------------------------

OK, for now at r1331996 I commented out the line

element.setAttribute(name, GenericEntity.NULL_FIELD.toString());

It's not a complete solution and induces more problems thant it solves (notably in RuntimeData for jobs), to be continued...
               

> Null values are not synchronized in http mode
> ---------------------------------------------
>
>                 Key: OFBIZ-4602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release 10.04, SVN trunk
>         Environment: Using entity synchronization over HTTP (not RMI)
>            Reporter: Patrick Antivackis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 4.0, Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: patch-OFBIZ-4602.txt
>
>
> In order to send over http the values to create, store and remove, Ofbiz is Xml serializing the values. GenericValue xml serialization is managed in GenericEntity.makeXmlElement, unfortunately this method just don't serialized null valued fields.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira