OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4628) re-enable the disabled submit button in ListInvoice and batchPayments

_‹ Previous Topic Next Topic _›

Classic

List

7 messages Options

Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4628) re-enable the disabled submit button in ListInvoice and batchPayments

re-enable the disabled submit button in ListInvoice and batchPayments
---------------------------------------------------------------------

Key: OFBIZ-4628
URL: https://issues.apache.org/jira/browse/OFBIZ-4628
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk
Reporter: Leon
Priority: Minor
Fix For: SVN trunk

To enable a disabled html element, there're only two ways, remove "disabled" attribute or use javascript to set disable property to false. The patch updates trivial to enable submit button in ListInvoices.ftl and batchPayments.ftl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4628) re-enable the disabled submit button in ListInvoice and batchPayments

[ https://issues.apache.org/jira/browse/OFBIZ-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4628:
------------------------

Attachment: OFBIZ-4628.patch

> re-enable the disabled submit button in ListInvoice and batchPayments
> ---------------------------------------------------------------------
>
> Key: OFBIZ-4628
> URL: https://issues.apache.org/jira/browse/OFBIZ-4628
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4628.patch
>
>
> To enable a disabled html element, there're only two ways, remove "disabled" attribute or use javascript to set disable property to false. The patch updates trivial to enable submit button in ListInvoices.ftl and batchPayments.ftl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4628) re-enable the disabled submit button in ListInvoice and batchPayments

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174010#comment-13174010 ]

Jacques Le Roux commented on OFBIZ-4628:
----------------------------------------

Hi Leon,

Quicky browsing, I did not find anything clear in the jQuery doc, but from http://jquery-howto.blogspot.com/2008/12/how-to-disableenable-element-with.html it seems both syntax are correct, has this changed (2008 is pretty old for jQuery)

> re-enable the disabled submit button in ListInvoice and batchPayments
> ---------------------------------------------------------------------
>
> Key: OFBIZ-4628
> URL: https://issues.apache.org/jira/browse/OFBIZ-4628
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4628.patch
>
>
> To enable a disabled html element, there're only two ways, remove "disabled" attribute or use javascript to set disable property to false. The patch updates trivial to enable submit button in ListInvoices.ftl and batchPayments.ftl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Issue Comment Edited] (OFBIZ-4628) re-enable the disabled submit button in ListInvoice and batchPayments

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174010#comment-13174010 ]

Jacques Le Roux edited comment on OFBIZ-4628 at 12/21/11 11:08 AM:
-------------------------------------------------------------------

========== EDIT: missed a ? ========
Hi Leon,

Quicky browsing, I did not find anything clear in the jQuery doc, but from http://jquery-howto.blogspot.com/2008/12/how-to-disableenable-element-with.html it seems both syntax are correct, has this changed (2008 is pretty old for jQuery)?

was (Author: jacques.le.roux):
Hi Leon,

Quicky browsing, I did not find anything clear in the jQuery doc, but from http://jquery-howto.blogspot.com/2008/12/how-to-disableenable-element-with.html it seems both syntax are correct, has this changed (2008 is pretty old for jQuery)

> re-enable the disabled submit button in ListInvoice and batchPayments
> ---------------------------------------------------------------------
>
> Key: OFBIZ-4628
> URL: https://issues.apache.org/jira/browse/OFBIZ-4628
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4628.patch
>
>
> To enable a disabled html element, there're only two ways, remove "disabled" attribute or use javascript to set disable property to false. The patch updates trivial to enable submit button in ListInvoices.ftl and batchPayments.ftl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4628) re-enable the disabled submit button in ListInvoice and batchPayments

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174153#comment-13174153 ]

Leon commented on OFBIZ-4628:
-----------------------------

not very clear about what changed to jquery, but there're much change to browser. I test the old source in latest IE9 and FF, the disabled button is unable to be enabled again by setting 'disabled' attribute to empty.

btw, it's not w2c compliance to set disabled attribute to other value than 'disabled'.

> re-enable the disabled submit button in ListInvoice and batchPayments
> ---------------------------------------------------------------------
>
> Key: OFBIZ-4628
> URL: https://issues.apache.org/jira/browse/OFBIZ-4628
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4628.patch
>
>
> To enable a disabled html element, there're only two ways, remove "disabled" attribute or use javascript to set disable property to false. The patch updates trivial to enable submit button in ListInvoices.ftl and batchPayments.ftl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4628) re-enable the disabled submit button in ListInvoice and batchPayments

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174240#comment-13174240 ]

Jacques Le Roux commented on OFBIZ-4628:
----------------------------------------

{quote}
btw, it's not w2c compliance to set disabled attribute to other value than 'disabled'.
{quote}

Great, thanks for your answer it clearly clarfies things. I will commit... soon...

> re-enable the disabled submit button in ListInvoice and batchPayments
> ---------------------------------------------------------------------
>
> Key: OFBIZ-4628
> URL: https://issues.apache.org/jira/browse/OFBIZ-4628
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4628.patch
>
>
> To enable a disabled html element, there're only two ways, remove "disabled" attribute or use javascript to set disable property to false. The patch updates trivial to enable submit button in ListInvoices.ftl and batchPayments.ftl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4628) re-enable the disabled submit button in ListInvoice and batchPayments

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4628.
----------------------------------

Resolution: Fixed
Fix Version/s: Release Branch 11.04
Assignee: Jacques Le Roux

Thanks Leon,

Your modified patch is in
trunk at r1221889
R11.04 r1221890

You were right at 1st << there're only two ways, remove "disabled" attribute or use javascript to set disable property to false>>

Actually W3C does not define any value for disabled http://www.w3.org/TR/html4/interact/forms.html#adef-disabled and its value in javascript is a boolean so we should rather use true instead of 'disabled' (as you said we could also use false instead of remove, but... anyway...)

So more files needed to be changed, though they all use ".removeAttr('disabled')"

> re-enable the disabled submit button in ListInvoice and batchPayments
> ---------------------------------------------------------------------
>
> Key: OFBIZ-4628
> URL: https://issues.apache.org/jira/browse/OFBIZ-4628
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4628.patch
>
>
> To enable a disabled html element, there're only two ways, remove "disabled" attribute or use javascript to set disable property to false. The patch updates trivial to enable submit button in ListInvoices.ftl and batchPayments.ftl.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira