[jira] [Created] (OFBIZ-4656) Enforcing Nonintantiability to Utility Classes in OFBiz
Locked
[jira] [Created] (OFBIZ-4656) Enforcing Nonintantiability to Utility Classes in OFBiz
 
|
Enforcing Nonintantiability to Utility Classes in OFBiz
------------------------------------------------------- Key: OFBIZ-4656 URL: https://issues.apache.org/jira/browse/OFBIZ-4656 Project: OFBiz Issue Type: Improvement Components: framework, product Reporter: Rishi Solanki Priority: Minor Fix For: SVN trunk With reference to discussion on list - http://ofbiz.markmail.org/search/?q=noninstantiability#query:noninstantiability+page:1+mid:y5xyypxuswydv3lv+state:results Here I'm covering the CatalogWorker.java, CategoryWorker.java, ProductWorker.java, UtilMisc.java and UomWorker.java There may be few more, will found and fix them soon. I'm not sure the patch will go to release or not so not including them in fix version. Please add them if this improvement goes there as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4656) Enforcing Nonintantiability to Utility Classes in OFBiz
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-4656: --------------------------------- Attachment: OFBIZ-4656.patch Here is the patch for the set of utility classes I found OFBiz. Thanks! > Enforcing Nonintantiability to Utility Classes in OFBiz > ------------------------------------------------------- > > Key: OFBIZ-4656 > URL: https://issues.apache.org/jira/browse/OFBIZ-4656 > Project: OFBiz > Issue Type: Improvement > Components: framework, product > Reporter: Rishi Solanki > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4656.patch > > > With reference to discussion on list - http://ofbiz.markmail.org/search/?q=noninstantiability#query:noninstantiability+page:1+mid:y5xyypxuswydv3lv+state:results > Here I'm covering the CatalogWorker.java, CategoryWorker.java, ProductWorker.java, UtilMisc.java and UomWorker.java > There may be few more, will found and fix them soon. > I'm not sure the patch will go to release or not so not including them in fix version. Please add them if this improvement goes there as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4656) Enforcing Noninstantiability to Utility Classes in OFBiz
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-4656: --------------------------------- Summary: Enforcing Noninstantiability to Utility Classes in OFBiz (was: Enforcing Nonintantiability to Utility Classes in OFBiz) > Enforcing Noninstantiability to Utility Classes in OFBiz > -------------------------------------------------------- > > Key: OFBIZ-4656 > URL: https://issues.apache.org/jira/browse/OFBIZ-4656 > Project: OFBiz > Issue Type: Improvement > Components: framework, product > Reporter: Rishi Solanki > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4656.patch > > > With reference to discussion on list - http://ofbiz.markmail.org/search/?q=noninstantiability#query:noninstantiability+page:1+mid:y5xyypxuswydv3lv+state:results > Here I'm covering the CatalogWorker.java, CategoryWorker.java, ProductWorker.java, UtilMisc.java and UomWorker.java > There may be few more, will found and fix them soon. > I'm not sure the patch will go to release or not so not including them in fix version. Please add them if this improvement goes there as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4656) Enforcing Noninstantiability to Utility Classes in OFBiz
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184747#comment-13184747 ] Adrian Crum commented on OFBIZ-4656: ------------------------------------ Thanks Rishi! Please remove the comments. We usually reserve comments for code that is unusual or hard to understand, and private constructors are understood by most Java programmers. > Enforcing Noninstantiability to Utility Classes in OFBiz > -------------------------------------------------------- > > Key: OFBIZ-4656 > URL: https://issues.apache.org/jira/browse/OFBIZ-4656 > Project: OFBiz > Issue Type: Improvement > Components: framework, product > Reporter: Rishi Solanki > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4656.patch > > > With reference to discussion on list - http://ofbiz.markmail.org/search/?q=noninstantiability#query:noninstantiability+page:1+mid:y5xyypxuswydv3lv+state:results > Here I'm covering the CatalogWorker.java, CategoryWorker.java, ProductWorker.java, UtilMisc.java and UomWorker.java > There may be few more, will found and fix them soon. > I'm not sure the patch will go to release or not so not including them in fix version. Please add them if this improvement goes there as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4656) Enforcing Noninstantiability to Utility Classes in OFBiz
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-4656: --------------------------------- Attachment: OFBIZ-4656.patch Thanks Adrian for your review and comment. With your changes I found few more classes namely; ContactHelper, ContactMechWorker, PartyHelper, PartyWorker. Added them in new patch. Thanks! > Enforcing Noninstantiability to Utility Classes in OFBiz > -------------------------------------------------------- > > Key: OFBIZ-4656 > URL: https://issues.apache.org/jira/browse/OFBIZ-4656 > Project: OFBiz > Issue Type: Improvement > Components: framework, product > Reporter: Rishi Solanki > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4656.patch, OFBIZ-4656.patch > > > With reference to discussion on list - http://ofbiz.markmail.org/search/?q=noninstantiability#query:noninstantiability+page:1+mid:y5xyypxuswydv3lv+state:results > Here I'm covering the CatalogWorker.java, CategoryWorker.java, ProductWorker.java, UtilMisc.java and UomWorker.java > There may be few more, will found and fix them soon. > I'm not sure the patch will go to release or not so not including them in fix version. Please add them if this improvement goes there as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Assigned] (OFBIZ-4656) Enforcing Noninstantiability to Utility Classes in OFBiz
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-4656: ---------------------------------- Assignee: Adrian Crum > Enforcing Noninstantiability to Utility Classes in OFBiz > -------------------------------------------------------- > > Key: OFBIZ-4656 > URL: https://issues.apache.org/jira/browse/OFBIZ-4656 > Project: OFBiz > Issue Type: Improvement > Components: framework, product > Reporter: Rishi Solanki > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4656.patch, OFBIZ-4656.patch > > > With reference to discussion on list - http://ofbiz.markmail.org/search/?q=noninstantiability#query:noninstantiability+page:1+mid:y5xyypxuswydv3lv+state:results > Here I'm covering the CatalogWorker.java, CategoryWorker.java, ProductWorker.java, UtilMisc.java and UomWorker.java > There may be few more, will found and fix them soon. > I'm not sure the patch will go to release or not so not including them in fix version. Please add them if this improvement goes there as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4656) Enforcing Noninstantiability to Utility Classes in OFBiz
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki updated OFBIZ-4656: --------------------------------- Component/s: party > Enforcing Noninstantiability to Utility Classes in OFBiz > -------------------------------------------------------- > > Key: OFBIZ-4656 > URL: https://issues.apache.org/jira/browse/OFBIZ-4656 > Project: OFBiz > Issue Type: Improvement > Components: framework, party, product > Reporter: Rishi Solanki > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4656.patch, OFBIZ-4656.patch > > > With reference to discussion on list - http://ofbiz.markmail.org/search/?q=noninstantiability#query:noninstantiability+page:1+mid:y5xyypxuswydv3lv+state:results > Here I'm covering the CatalogWorker.java, CategoryWorker.java, ProductWorker.java, UtilMisc.java and UomWorker.java > There may be few more, will found and fix them soon. > I'm not sure the patch will go to release or not so not including them in fix version. Please add them if this improvement goes there as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Closed] (OFBIZ-4656) Enforcing Noninstantiability to Utility Classes in OFBiz
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-4656. ------------------------------ Resolution: Fixed Fixed, rev 1243364. Thanks Rishi! > Enforcing Noninstantiability to Utility Classes in OFBiz > -------------------------------------------------------- > > Key: OFBIZ-4656 > URL: https://issues.apache.org/jira/browse/OFBIZ-4656 > Project: OFBiz > Issue Type: Improvement > Components: framework, party, product > Reporter: Rishi Solanki > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4656.patch, OFBIZ-4656.patch > > > With reference to discussion on list - http://ofbiz.markmail.org/search/?q=noninstantiability#query:noninstantiability+page:1+mid:y5xyypxuswydv3lv+state:results > Here I'm covering the CatalogWorker.java, CategoryWorker.java, ProductWorker.java, UtilMisc.java and UomWorker.java > There may be few more, will found and fix them soon. > I'm not sure the patch will go to release or not so not including them in fix version. Please add them if this improvement goes there as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4656) Enforcing Noninstantiability to Utility Classes in OFBiz
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206733#comment-13206733 ] Rishi Solanki commented on OFBIZ-4656: -------------------------------------- Thanks Adrian. > Enforcing Noninstantiability to Utility Classes in OFBiz > -------------------------------------------------------- > > Key: OFBIZ-4656 > URL: https://issues.apache.org/jira/browse/OFBIZ-4656 > Project: OFBiz > Issue Type: Improvement > Components: framework, party, product > Reporter: Rishi Solanki > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4656.patch, OFBIZ-4656.patch > > > With reference to discussion on list - http://ofbiz.markmail.org/search/?q=noninstantiability#query:noninstantiability+page:1+mid:y5xyypxuswydv3lv+state:results > Here I'm covering the CatalogWorker.java, CategoryWorker.java, ProductWorker.java, UtilMisc.java and UomWorker.java > There may be few more, will found and fix them soon. > I'm not sure the patch will go to release or not so not including them in fix version. Please add them if this improvement goes there as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |