[jira] [Created] (OFBIZ-4701) renderFormClose is missing arguments containerId, hasRequiredField

[Nicolas Malin (Jira)]

renderFormClose is missing arguments containerId, hasRequiredField
------------------------------------------------------------------

                 Key: OFBIZ-4701
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4701
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: Release Branch 11.04, SVN trunk
            Reporter: Kiran Gawde


In htmlFormMacrolLibrary.ftl, renderFormClose has containerId, hasRequiredField.
But csv, fo, text, xml FormMacroLibary.ftl don't have these fields for this macro.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Gawde updated OFBIZ-4701:
-------------------------------

    Attachment: OFBIZ-4701-xxxFormMacroLibrary.patch

Added missing arguments to macros
               

> renderFormClose is missing arguments containerId, hasRequiredField
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4701
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4701
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>         Attachments: OFBIZ-4701-xxxFormMacroLibrary.patch
>
>
> In htmlFormMacrolLibrary.ftl, renderFormClose has containerId, hasRequiredField.
> But csv, fo, text, xml FormMacroLibary.ftl don't have these fields for this macro.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4701.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Thanks Kiran,

It was missing from [r1096293|http://svn.apache.org/viewvc?rev=1096293&view=rev]

Your patch is in trunk at r1245778. It should not be needed in R11.04


               

> renderFormClose is missing arguments containerId, hasRequiredField
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4701
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4701
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4701-xxxFormMacroLibrary.patch
>
>
> In htmlFormMacrolLibrary.ftl, renderFormClose has containerId, hasRequiredField.
> But csv, fo, text, xml FormMacroLibary.ftl don't have these fields for this macro.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Kiran-2]

Thanks Jacques. I was getting error on 11.04 branch hence I added it
there.

Regards,
Kiran

[Jacques Le Roux]

Hi Kiran,

Ha interesting, for the same reason? Because, as I explained in the Jira (again, please guys use Jira for comments to keep the flow
there, even if it's readable here) I did not backport the change

Jacques

From: <[hidden email]>
> Thanks Jacques. I was getting error on 11.04 branch hence I added it
> there.
>
> Regards,
> Kiran

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239182#comment-13239182 ]

Ashish Vijaywargiya commented on OFBIZ-4701:
--------------------------------------------

It was bug fix and was creating problem on relase branch 11.04 too so I have committed it in rb at r1305732.
               

> renderFormClose is missing arguments containerId, hasRequiredField
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4701
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4701
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4701-xxxFormMacroLibrary.patch
>
>
> In htmlFormMacrolLibrary.ftl, renderFormClose has containerId, hasRequiredField.
> But csv, fo, text, xml FormMacroLibary.ftl don't have these fields for this macro.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239269#comment-13239269 ]

Jacques Le Roux commented on OFBIZ-4701:
----------------------------------------

Thanks Ashish!
               

> renderFormClose is missing arguments containerId, hasRequiredField
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4701
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4701
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 11.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4701-xxxFormMacroLibrary.patch
>
>
> In htmlFormMacrolLibrary.ftl, renderFormClose has containerId, hasRequiredField.
> But csv, fo, text, xml FormMacroLibary.ftl don't have these fields for this macro.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira