[ https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238297#comment-13238297 ] Jacques Le Roux commented on OFBIZ-4723: ---------------------------------------- Done at r1305316 > Support validation of resource xml files > ---------------------------------------- > > Key: OFBIZ-4723 > URL: https://issues.apache.org/jira/browse/OFBIZ-4723 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: REV 1297286 > Reporter: Anne Jessel > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4723_UtilProperties_only.patch, OFBIZ-4723_both.patch, OFBIZ-4723_code_cleanups.patch, OFBIZ-4723_combined.patch, OFBIZ-4723_support-validation-resource-xml.patch > > > The xsd for the resource xml files is invalid. In addition, the format of the value of the xml:lang attribute in resource xml files is invalid, according to the xml standard. > The attached patch: > * provides a valid xsd > * updates UtilProperties and the Label Manager to deal with the correct formatting of the xml:lang value, while still working with the old format, following Adrian Crum's recommendation on the mailing list > * includes simple unit tests for UtilProperties to ensure it does work with both formats > * changes the Label Manager to include a reference to the new xsd, and to use the correct format of the xml:lang value, when writing a resource xml file. > This problem exists in released versions, but I doubt it is important enough to back port. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238943#comment-13238943 ] Anne Jessel commented on OFBIZ-4723: ------------------------------------ Thank you Jacques. > Support validation of resource xml files > ---------------------------------------- > > Key: OFBIZ-4723 > URL: https://issues.apache.org/jira/browse/OFBIZ-4723 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Environment: REV 1297286 > Reporter: Anne Jessel > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4723_UtilProperties_only.patch, OFBIZ-4723_both.patch, OFBIZ-4723_code_cleanups.patch, OFBIZ-4723_combined.patch, OFBIZ-4723_support-validation-resource-xml.patch > > > The xsd for the resource xml files is invalid. In addition, the format of the value of the xml:lang attribute in resource xml files is invalid, according to the xml standard. > The attached patch: > * provides a valid xsd > * updates UtilProperties and the Label Manager to deal with the correct formatting of the xml:lang value, while still working with the old format, following Adrian Crum's recommendation on the mailing list > * includes simple unit tests for UtilProperties to ensure it does work with both formats > * changes the Label Manager to include a reference to the new xsd, and to use the correct format of the xml:lang value, when writing a resource xml file. > This problem exists in released versions, but I doubt it is important enough to back port. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |